Skip to content

Add IAM headless to CI #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2019
Merged

Add IAM headless to CI #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c22bee
Add IAM headless to CI
paulb777 Feb 2, 2019
8594406
underscores not dashes in scheme name
paulb777 Feb 2, 2019
4698fe5
xcode 9 build issue
paulb777 Feb 2, 2019
9830140
Fix new Xcode 10.2 warning
paulb777 Feb 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Firebase/InAppMessaging/Data/FIRIAMFetchResponseParser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ NS_ASSUME_NONNULL_BEGIN
// @param fetchWaitTime would be non nil if fetch wait time data is found in the api response.
- (NSArray<FIRIAMMessageDefinition *> *)parseAPIResponseDictionary:(NSDictionary *)responseDict
discardedMsgCount:(NSInteger *)discardCount
fetchWaitTimeInSeconds:(NSNumber **)fetchWaitTime;
fetchWaitTimeInSeconds:
(NSNumber *_Nullable *_Nonnull)fetchWaitTime;

- (instancetype)init NS_UNAVAILABLE;
- (instancetype)initWithTimeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher;
Expand Down
1 change: 0 additions & 1 deletion InAppMessaging/Example/App/InAppMessaging-Example-iOS/AppDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ - (BOOL)application:(UIApplication *)application
sdkSetting.loggerSizeAfterReduce = 600;
sdkSetting.appFGRenderMinIntervalInMinutes = 0.1;
sdkSetting.loggerInVerboseMode = YES;
sdkSetting.conversionTrackingExpiresInSeconds = 180;
sdkSetting.firebaseAutoDataCollectionEnabled = NO;

sdkSetting.clearcutStrategy =
Expand Down
5 changes: 2 additions & 3 deletions InAppMessaging/Example/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@

use_frameworks!

# Uncomment the next two lines for pre-release testing on public repo
source 'https://github.com/Firebase/SpecsStaging.git'
source 'https://github.com/CocoaPods/Specs.git'
# source 'https://github.com/Firebase/SpecsStaging.git'
# source 'https://github.com/CocoaPods/Specs.git'

pod 'FirebaseCore', :path => '../..'

Expand Down
7 changes: 7 additions & 0 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,13 @@ case "$product-$method-$platform" in
;;

InAppMessagingDisplay-xcodebuild-iOS)
RunXcodebuild \
-workspace 'InAppMessaging/Example/InAppMessaging-Example-iOS.xcworkspace' \
-scheme 'InAppMessaging_Example_iOS' \
"${xcb_flags[@]}" \
build \
test

# Run UI tests on both iPad and iPhone simulators
# TODO: Running two destinations from one xcodebuild command stopped working with Xcode 10.
# Consider separating static library tests to a separate job.
Expand Down
1 change: 1 addition & 0 deletions scripts/install_prereqs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ case "$PROJECT-$PLATFORM-$METHOD" in
InAppMessagingDisplay-iOS-xcodebuild)
gem install xcpretty
bundle exec pod install --project-directory=InAppMessagingDisplay/Example --repo-update
bundle exec pod install --project-directory=InAppMessaging/Example --repo-update
;;

Firestore-*-xcodebuild | Firestore-*-fuzz)
Expand Down