PR feedback

Author: avolkovi

packages-exp/auth-exp/src/core/strategies/action_code_settings.test.ts

@@ -21,7 +21,7 @@ import { ActionCodeSettings } from '@firebase/auth-types-exp';
 
 import { testAuth, TestAuth } from '../../../test/helpers/mock_auth';
 import { GetOobCodeRequest } from '../../api/authentication/email_and_password';
-import { setActionCodeSettingsOnRequest_ } from './action_code_settings';
+import { _setActionCodeSettingsOnRequest } from './action_code_settings';
 
 describe('core/strategies/action_code_settings', () => {
   let auth: TestAuth;
@@ -32,25 +32,9 @@ describe('core/strategies/action_code_settings', () => {
     auth = await testAuth();
   });
 
-
-  it('should require a continue URL', () => {
-    expect(() =>
-      setActionCodeSettingsOnRequest_(auth, request, {
-        handleCodeInApp: true,
-        iOS: {
-          bundleId: 'my-bundle'
-        },
-        dynamicLinkDomain: 'fdl-domain'
-      } as unknown as ActionCodeSettings)
-    ).to.throw(
-      FirebaseError,
-      '(auth/missing-continue-uri)'
-    );
-  });
-
   it('should require a non empty continue URL', () => {
     expect(() =>
-      setActionCodeSettingsOnRequest_(auth, request, {
+      _setActionCodeSettingsOnRequest(auth, request, {
         handleCodeInApp: true,
         iOS: {
           bundleId: 'my-bundle'
@@ -66,7 +50,7 @@ describe('core/strategies/action_code_settings', () => {
 
   it('should allow undefined dynamic link URL', () => {
     expect(() =>
-      setActionCodeSettingsOnRequest_(auth, request, {
+      _setActionCodeSettingsOnRequest(auth, request, {
         handleCodeInApp: true,
         iOS: {
           bundleId: 'my-´bundle'
@@ -78,7 +62,7 @@ describe('core/strategies/action_code_settings', () => {
 
   it('should require a non empty dynamic link URL', () => {
     expect(() =>
-      setActionCodeSettingsOnRequest_(auth, request, {
+      _setActionCodeSettingsOnRequest(auth, request, {
         handleCodeInApp: true,
         iOS: {
           bundleId: 'my-´bundle'
@@ -94,7 +78,7 @@ describe('core/strategies/action_code_settings', () => {
 
   it('should require a non-empty bundle ID', () => {
     expect(() =>
-      setActionCodeSettingsOnRequest_(auth, request, {
+      _setActionCodeSettingsOnRequest(auth, request, {
         handleCodeInApp: true,
         iOS: {
           bundleId: ''
@@ -110,7 +94,7 @@ describe('core/strategies/action_code_settings', () => {
 
   it('should require a non-empty package name', () => {
     expect(() =>
-      setActionCodeSettingsOnRequest_(auth, request, {
+      _setActionCodeSettingsOnRequest(auth, request, {
         handleCodeInApp: true,
         android: {
           packageName: ''

packages-exp/auth-exp/src/core/strategies/action_code_settings.ts

@@ -22,14 +22,11 @@ import { AuthErrorCode } from '../errors';
 import { assert } from '../util/assert';
 import { AuthCore } from '../../model/auth'; 
 
-export function setActionCodeSettingsOnRequest_(
+export function _setActionCodeSettingsOnRequest(
   auth: AuthCore,
   request: GetOobCodeRequest,
   actionCodeSettings: ActionCodeSettings
 ): void {
-  assert(typeof actionCodeSettings.url !== 'undefined', AuthErrorCode.MISSING_CONTINUE_URI, {
-    appName: auth.name
-  });
   assert(actionCodeSettings.url.length > 0, AuthErrorCode.INVALID_CONTINUE_URI, {
     appName: auth.name
   });

packages-exp/auth-exp/src/core/strategies/email.ts

@@ -24,7 +24,7 @@ import {
 import * as api from '../../api/authentication/email_and_password';
 import { User } from '../../model/user';
 import { _getCurrentUrl, _isHttpOrHttps } from '../util/location';
-import { setActionCodeSettingsOnRequest_ } from './action_code_settings';
+import { _setActionCodeSettingsOnRequest } from './action_code_settings';
 import { _castAuth } from '../auth/auth_impl';
 
 export async function fetchSignInMethodsForEmail(
@@ -56,7 +56,7 @@ export async function sendEmailVerification(
     idToken
   };
   if (actionCodeSettings) {
-    setActionCodeSettingsOnRequest_(user.auth, request, actionCodeSettings);
+    _setActionCodeSettingsOnRequest(user.auth, request, actionCodeSettings);
   }
 
   const { email } = await api.sendEmailVerification(user.auth, request);
@@ -79,7 +79,7 @@ export async function verifyBeforeUpdateEmail(
     newEmail
   };
   if (actionCodeSettings) {
-    setActionCodeSettingsOnRequest_(user.auth, request, actionCodeSettings);
+    _setActionCodeSettingsOnRequest(user.auth, request, actionCodeSettings);
   }
 
   const { email } = await api.verifyAndChangeEmail(user.auth, request);

packages-exp/auth-exp/src/core/strategies/email_and_password.ts

@@ -24,7 +24,7 @@ import { MultiFactorInfo } from '../../mfa/mfa_info';
 import { EmailAuthProvider } from '../providers/email';
 import { UserCredentialImpl } from '../user/user_credential_impl';
 import { assert } from '../util/assert';
-import { setActionCodeSettingsOnRequest_ } from './action_code_settings';
+import { _setActionCodeSettingsOnRequest } from './action_code_settings';
 import { signInWithCredential } from './credential';
 import { _castAuth } from '../auth/auth_impl';
 import { AuthErrorCode } from '../errors';
@@ -39,7 +39,7 @@ export async function sendPasswordResetEmail(
     email
   };
   if (actionCodeSettings) {
-    setActionCodeSettingsOnRequest_(auth, request, actionCodeSettings);
+    _setActionCodeSettingsOnRequest(auth, request, actionCodeSettings);
   }
 
   await authentication.sendPasswordResetEmail(auth, request);

packages-exp/auth-exp/src/core/strategies/email_link.ts

@@ -21,7 +21,7 @@ import * as api from '../../api/authentication/email_and_password';
 import { ActionCodeURL } from '../action_code_url';
 import { EmailAuthProvider } from '../providers/email';
 import { _getCurrentUrl } from '../util/location';
-import { setActionCodeSettingsOnRequest_ } from './action_code_settings';
+import { _setActionCodeSettingsOnRequest } from './action_code_settings';
 import { signInWithCredential } from './credential';
 import { AuthErrorCode } from '../errors';
 import { assert } from '../util/assert';
@@ -36,7 +36,7 @@ export async function sendSignInLinkToEmail(
     email
   };
   if (actionCodeSettings) {
-    setActionCodeSettingsOnRequest_(auth ,request, actionCodeSettings);
+    _setActionCodeSettingsOnRequest(auth ,request, actionCodeSettings);
   }
 
   await api.sendSignInLinkToEmail(auth, request);