Use const enums for better inlining in auth-exp

Author: avolkovi

packages-exp/auth-exp/src/api/account_management/account.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Endpoint, HttpMethod, _performApiRequest } from '../';
+import { Endpoint, HttpMethod, _performApiRequest } from '../index';
 import { MfaEnrollment } from './mfa';
 import { Auth } from '@firebase/auth-types-exp';
 

packages-exp/auth-exp/src/api/account_management/email_and_password.ts

@@ -17,7 +17,7 @@
 
 import { Operation, Auth } from '@firebase/auth-types-exp';
 
-import { Endpoint, HttpMethod, _performApiRequest } from '..';
+import { Endpoint, HttpMethod, _performApiRequest } from '../index';
 import { IdTokenResponse } from '../../model/id_token';
 import { MfaEnrollment } from './mfa';
 

packages-exp/auth-exp/src/api/account_management/mfa.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Endpoint, HttpMethod, _performApiRequest } from '..';
+import { Endpoint, HttpMethod, _performApiRequest } from '../index';
 import { SignInWithPhoneNumberRequest } from '../authentication/sms';
 import { FinalizeMfaResponse } from '../authentication/mfa';
 import { Auth } from '../../model/auth';

packages-exp/auth-exp/src/api/account_management/profile.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Endpoint, HttpMethod, _performApiRequest } from '..';
+import { Endpoint, HttpMethod, _performApiRequest } from '../index';
 import { IdTokenResponse } from '../../model/id_token';
 import { Auth } from '@firebase/auth-types-exp';
 

packages-exp/auth-exp/src/api/authentication/create_auth_uri.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Endpoint, HttpMethod, _performApiRequest } from '..';
+import { Endpoint, HttpMethod, _performApiRequest } from '../index';
 import { Auth } from '@firebase/auth-types-exp';
 
 export interface CreateAuthUriRequest {

packages-exp/auth-exp/src/api/authentication/custom_token.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Endpoint, HttpMethod, _performSignInRequest } from '..';
+import { Endpoint, HttpMethod, _performSignInRequest } from '../index';
 import { IdTokenResponse } from '../../model/id_token';
 import { Auth } from '@firebase/auth-types-exp';
 

packages-exp/auth-exp/src/api/authentication/email_and_password.ts

@@ -22,7 +22,7 @@ import {
   HttpMethod,
   _performApiRequest,
   _performSignInRequest
-} from '..';
+} from '../index';
 import { IdToken, IdTokenResponse } from '../../model/id_token';
 
 export interface SignInWithPasswordRequest {

packages-exp/auth-exp/src/api/authentication/email_link.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { _performSignInRequest, Endpoint, HttpMethod } from '../';
+import { _performSignInRequest, Endpoint, HttpMethod } from '../index';
 import { IdTokenResponse } from '../../model/id_token';
 import { Auth } from '@firebase/auth-types-exp';
 

packages-exp/auth-exp/src/api/authentication/idp.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Endpoint, HttpMethod, _performSignInRequest } from '..';
+import { Endpoint, HttpMethod, _performSignInRequest } from '../index';
 import { IdToken, IdTokenResponse } from '../../model/id_token';
 import { Auth } from '@firebase/auth-types-exp';
 

packages-exp/auth-exp/src/api/authentication/mfa.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { _performApiRequest, Endpoint, HttpMethod } from '../';
+import { _performApiRequest, Endpoint, HttpMethod } from '../index';
 import { Auth } from '@firebase/auth-types-exp';
 import { IdTokenResponse } from '../../model/id_token';
 import { MfaEnrollment } from '../account_management/mfa';

packages-exp/auth-exp/src/api/authentication/recaptcha.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Endpoint, HttpMethod, _performApiRequest } from '..';
+import { Endpoint, HttpMethod, _performApiRequest } from '../index';
 import { Auth } from '@firebase/auth-types-exp';
 
 interface GetRecaptchaParamResponse {

packages-exp/auth-exp/src/api/authentication/sign_up.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Endpoint, HttpMethod, _performSignInRequest } from '..';
+import { Endpoint, HttpMethod, _performSignInRequest } from '../index';
 import { IdTokenResponse } from '../../model/id_token';
 import { Auth } from '@firebase/auth-types-exp';
 

packages-exp/auth-exp/src/api/authentication/sms.ts

@@ -20,7 +20,7 @@ import {
   HttpMethod,
   _performApiRequest,
   _performSignInRequest
-} from '..';
+} from '../index';
 import { AuthErrorCode } from '../../core/errors';
 import { IdTokenResponse } from '../../model/id_token';
 import { ServerError, ServerErrorMap } from '../errors';

packages-exp/auth-exp/src/api/authentication/token.ts

@@ -23,7 +23,7 @@ import {
   _getFinalTarget,
   _performFetchWithErrorHandling,
   HttpMethod
-} from '../';
+} from '../index';
 import { FetchProvider } from '../../core/util/fetch_provider';
 import { Auth } from '@firebase/auth-types-exp';
 

packages-exp/auth-exp/src/api/errors.ts

@@ -20,7 +20,7 @@ import { AuthErrorCode } from '../core/errors';
 /**
  * Errors that can be returned by the backend
  */
-export enum ServerError {
+export const enum ServerError {
   ADMIN_ONLY_OPERATION = 'ADMIN_ONLY_OPERATION',
   CAPTCHA_CHECK_FAILED = 'CAPTCHA_CHECK_FAILED',
   CORS_UNSUPPORTED = 'CORS_UNSUPPORTED',

packages-exp/auth-exp/src/api/index.ts

@@ -32,18 +32,18 @@ import { IdTokenResponse, TaggedWithTokenResponse } from '../model/id_token';
 import { IdTokenMfaResponse } from './authentication/mfa';
 import { SERVER_ERROR_MAP, ServerError, ServerErrorMap } from './errors';
 
-export enum HttpMethod {
+export const enum HttpMethod {
   POST = 'POST',
   GET = 'GET'
 }
 
-export enum HttpHeader {
+export const enum HttpHeader {
   CONTENT_TYPE = 'Content-Type',
   X_FIREBASE_LOCALE = 'X-Firebase-Locale',
   X_CLIENT_VERSION = 'X-Client-Version'
 }
 
-export enum Endpoint {
+export const enum Endpoint {
   CREATE_AUTH_URI = '/v1/accounts:createAuthUri',
   DELETE_ACCOUNT = '/v1/accounts:delete',
   RESET_PASSWORD = '/v1/accounts:resetPassword',

packages-exp/auth-exp/src/api/project_config/get_project_config.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { _performApiRequest, Endpoint, HttpMethod } from '../';
+import { _performApiRequest, Endpoint, HttpMethod } from '../index';
 import { Auth } from '@firebase/auth-types-exp';
 
 export interface GetProjectConfigRequest {}

packages-exp/auth-exp/src/core/persistence/index.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-export enum PersistenceType {
+export const enum PersistenceType {
   SESSION = 'SESSION',
   LOCAL = 'LOCAL',
   NONE = 'NONE'

packages-exp/auth-exp/src/core/util/browser.ts

@@ -28,7 +28,7 @@ interface Document {
 /**
  * Enums for Browser name.
  */
-export enum BrowserName {
+export const enum BrowserName {
   ANDROID = 'Android',
   BLACKBERRY = 'Blackberry',
   EDGE = 'Edge',

packages-exp/auth-exp/src/core/util/version.ts

@@ -21,7 +21,7 @@ import { getUA } from '@firebase/util';
 
 const CLIENT_IMPLEMENTATION = 'JsCore';
 
-export enum ClientPlatform {
+export const enum ClientPlatform {
   BROWSER = 'Browser',
   NODE = 'Node',
   REACT_NATIVE = 'ReactNative',

packages-exp/auth-exp/src/mfa/assertions/index.ts renamed to packages-exp/auth-exp/src/mfa/mfa_assertion.ts

@@ -15,10 +15,10 @@
  * limitations under the License.
  */
 import * as externs from '@firebase/auth-types-exp';
-import { debugFail } from '../../core/util/assert';
-import { MultiFactorSession, MultiFactorSessionType } from '../mfa_session';
-import { FinalizeMfaResponse } from '../../api/authentication/mfa';
-import { Auth } from '../../model/auth';
+import { debugFail } from '../core/util/assert';
+import { MultiFactorSession, MultiFactorSessionType } from './mfa_session';
+import { FinalizeMfaResponse } from '../api/authentication/mfa';
+import { Auth } from '../model/auth';
 
 export abstract class MultiFactorAssertion
   implements externs.MultiFactorAssertion {

packages-exp/auth-exp/src/mfa/mfa_resolver.test.ts

@@ -31,7 +31,7 @@ import { PhoneAuthCredential } from '../core/credentials/phone';
 import { AUTH_ERROR_FACTORY, AuthErrorCode } from '../core/errors';
 import { EmailAuthProvider } from '../core/providers/email';
 import { User, UserCredential } from '../model/user';
-import { MultiFactorAssertion } from './assertions';
+import { MultiFactorAssertion } from './mfa_assertion';
 import { PhoneMultiFactorAssertion } from '../platform_browser/mfa/assertions/phone';
 import { MultiFactorError } from './mfa_error';
 import { getMultiFactorResolver, MultiFactorResolver } from './mfa_resolver';

packages-exp/auth-exp/src/mfa/mfa_resolver.ts

@@ -22,7 +22,7 @@ import { AuthErrorCode } from '../core/errors';
 import { UserCredentialImpl } from '../core/user/user_credential_impl';
 import { assert, fail } from '../core/util/assert';
 import { UserCredential } from '../model/user';
-import { MultiFactorAssertion } from './assertions';
+import { MultiFactorAssertion } from './mfa_assertion';
 import { MultiFactorError } from './mfa_error';
 import { MultiFactorInfo } from './mfa_info';
 import { MultiFactorSession } from './mfa_session';

packages-exp/auth-exp/src/mfa/mfa_session.ts

@@ -16,7 +16,7 @@
  */
 import * as externs from '@firebase/auth-types-exp';
 
-export enum MultiFactorSessionType {
+export const enum MultiFactorSessionType {
   ENROLL = 'enroll',
   SIGN_IN = 'signin'
 }

packages-exp/auth-exp/src/mfa/mfa_user.test.ts

@@ -31,7 +31,7 @@ import { User } from '../model/user';
 import { MultiFactorInfo } from './mfa_info';
 import { MultiFactorSession, MultiFactorSessionType } from './mfa_session';
 import { multiFactor, MultiFactorUser } from './mfa_user';
-import { MultiFactorAssertion } from './assertions';
+import { MultiFactorAssertion } from './mfa_assertion';
 import { Auth } from '../model/auth';
 
 use(chaiAsPromised);

packages-exp/auth-exp/src/mfa/mfa_user.ts

@@ -20,7 +20,7 @@ import { withdrawMfa } from '../api/account_management/mfa';
 import { AuthErrorCode } from '../core/errors';
 import { _logoutIfInvalidated } from '../core/user/invalidation';
 import { User } from '../model/user';
-import { MultiFactorAssertion } from './assertions';
+import { MultiFactorAssertion } from './mfa_assertion';
 import { MultiFactorInfo } from './mfa_info';
 import { MultiFactorSession } from './mfa_session';
 

packages-exp/auth-exp/src/platform_browser/mfa/assertions/phone.ts

@@ -16,7 +16,7 @@
  */
 import * as externs from '@firebase/auth-types-exp';
 
-import { MultiFactorAssertion } from '../../../mfa/assertions';
+import { MultiFactorAssertion } from '../../../mfa/mfa_assertion';
 import { Auth } from '../../../model/auth';
 import { finalizeEnrollPhoneMfa } from '../../../api/account_management/mfa';
 import { PhoneAuthCredential } from '../../../core/credentials/phone';