Skip to content

Commit 08eafdf

Browse files
committed
Add FieldMask.empty().
1 parent db4f6c1 commit 08eafdf

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

packages/firestore/src/local/local_documents_view.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ export class LocalDocumentsView {
217217
batch.keys().forEach(key => {
218218
let mask: FieldMask | null = masks.has(key)
219219
? masks.get(key)!
220-
: new FieldMask([]);
220+
: FieldMask.empty();
221221
mask = batch.applyToLocalViewWithFieldMask(docs.get(key)!, mask);
222222
masks.set(key, mask);
223223
if (documentsByBatchId.get(batch.batchId) === null) {

packages/firestore/src/model/field_mask.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ export class FieldMask {
4242
);
4343
}
4444

45+
static empty(): FieldMask {
46+
return new FieldMask([]);
47+
}
48+
4549
/**
4650
* Verifies that `fieldPath` is included by at least one field in this field
4751
* mask.

packages/firestore/src/model/mutation_batch.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,7 @@ export class MutationBatch {
101101
* @returns A `FieldMask` representing all the fields that are mutated.
102102
*/
103103
applyToLocalView(document: MutableDocument): FieldMask | null {
104-
const mutatedFields = new FieldMask([]);
105-
return this.applyToLocalViewWithFieldMask(document, mutatedFields);
104+
return this.applyToLocalViewWithFieldMask(document, FieldMask.empty());
106105
}
107106

108107
/**

0 commit comments

Comments
 (0)