performance and remote-config

Author: hsubox76

packages/performance-compat/package.json

@@ -51,7 +51,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2",
+    "typescript": "4.7.4",
     "@firebase/app-compat": "0.1.39"
   },
   "repository": {

packages/performance-compat/test/util.ts

@@ -31,12 +31,14 @@ export function getFakeApp(): FirebaseApp {
       appId: '1:777777777777:web:d93b5ca1475efe57'
     },
     automaticDataCollectionEnabled: true,
+    performance: () => ({} as any),
     delete: async () => {}
   };
 }
 
 export function getFakeModularPerformance(): FirebasePerformance {
   return {
+    app: getFakeApp(),
     instrumentationEnabled: true,
     dataCollectionEnabled: true
   };

packages/performance-types/package.json

@@ -12,7 +12,7 @@
     "index.d.ts"
   ],
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/performance-types",

packages/performance/package.json

@@ -51,7 +51,7 @@
     "rollup": "2.79.1",
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/performance",

packages/performance/src/resources/trace.test.ts

@@ -199,6 +199,7 @@ describe('Firebase Performance > trace', () => {
     });
 
     it('replaces undefined metrics with 0', () => {
+      // @ts-ignore A non-TS user could provide undefined.
       trace.putMetric('cacheHits', undefined);
 
       expect(trace.getMetric('cacheHits')).to.eql(0);

packages/performance/src/services/oob_resources_service.test.ts

@@ -62,6 +62,7 @@ describe('Firebase Performance > oob_resources_service', () => {
     responseEnd: 9.305000072345138,
     responseStart: 8.940000087022781,
     secureConnectionStart: 0,
+    serverTiming: [],
     startTime: 0,
     transferSize: 1259,
     type: 'reload',

packages/performance/src/services/perf_logger.test.ts

@@ -307,6 +307,7 @@ describe('Performance Monitoring > perf_logger', () => {
         responseEnd: 5685.300000011921,
         responseStart: 0,
         secureConnectionStart: 0,
+        serverTiming: [],
         startTime: 5645.689999917522,
         transferSize: 0,
         workerStart: 0,
@@ -369,6 +370,7 @@ describe('Performance Monitoring > perf_logger', () => {
         responseEnd: 5685.300000011921,
         responseStart: 0,
         secureConnectionStart: 0,
+        serverTiming: [],
         startTime: 5645.689999917522,
         transferSize: 0,
         workerStart: 0,
@@ -413,6 +415,7 @@ describe('Performance Monitoring > perf_logger', () => {
         responseEnd: 5685.300000011921,
         responseStart: 0,
         secureConnectionStart: 0,
+        serverTiming: [],
         startTime: 5645.689999917522,
         transferSize: 0,
         workerStart: 0,

packages/performance/src/services/remote_config_service.test.ts

@@ -88,7 +88,7 @@ describe('Performance Monitoring > remote_config_service', () => {
     fetchConfig?: { reject: boolean; value?: Response }
   ): {
     storageGetItemStub: SinonStub<[string], string | null>;
-    fetchStub: SinonStub<[RequestInfo, RequestInit?], Promise<Response>>;
+    fetchStub: SinonStub<[RequestInfo | URL, RequestInit?], Promise<Response>>;
   } {
     const fetchStub = stub(self, 'fetch');
 

packages/performance/src/services/transport_service.test.ts

@@ -28,7 +28,7 @@ import { SettingsService } from './settings_service';
 use(sinonChai);
 
 describe('Firebase Performance > transport_service', () => {
-  let fetchStub: SinonStub<[RequestInfo, RequestInit?], Promise<Response>>;
+  let fetchStub: SinonStub<[RequestInfo | URL, RequestInit?], Promise<Response>>;
   const INITIAL_SEND_TIME_DELAY_MS = 5.5 * 1000;
   const DEFAULT_SEND_INTERVAL_MS = 10 * 1000;
   const MAX_EVENT_COUNT_PER_REQUEST = 1000;

packages/performance/src/utils/attributes_utils.ts

@@ -44,12 +44,12 @@ const enum EffectiveConnectionType {
  *
  * ref: https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation
  */
-interface NetworkInformation {
+interface NetworkInformationWithEffectiveType extends NetworkInformation {
   readonly effectiveType?: 'slow-2g' | '2g' | '3g' | '4g';
 }
 
 interface NavigatorWithConnection extends Navigator {
-  readonly connection: NetworkInformation;
+  readonly connection: NetworkInformationWithEffectiveType;
 }
 
 const RESERVED_ATTRIBUTE_PREFIXES = ['firebase_', 'google_', 'ga_'];

packages/remote-config-compat/package.json

@@ -50,7 +50,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2",
+    "typescript": "4.7.4",
     "@firebase/app-compat": "0.1.39"
   },
   "repository": {

packages/remote-config-compat/test/util.ts

@@ -38,6 +38,7 @@ export function getFakeApp(): FirebaseApp {
 
 export function getFakeModularRemoteConfig(): RemoteConfig {
   return {
+    app: getFakeApp(),
     defaultConfig: {},
     fetchTimeMillis: 0,
     lastFetchStatus: 'no-fetch-yet',

packages/remote-config-types/package.json

@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }

packages/remote-config/package.json

@@ -52,7 +52,7 @@
     "@firebase/app": "0.8.4",
     "rollup": "2.79.1",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/remote-config",

packages/remote-config/test/client/rest_client.test.ts

@@ -55,7 +55,7 @@ describe('RestClient', () => {
 
   describe('fetch', () => {
     let fetchStub: sinon.SinonStub<
-      [RequestInfo, RequestInit?],
+      [RequestInfo | URL, RequestInit?],
       Promise<Response>
     >;