Merge 9a68f38 into 8d9a09e

Author: schmidt-sebastian

packages/firestore/src/local/memory_remote_document_cache.ts

@@ -98,7 +98,7 @@ class MemoryRemoteDocumentCacheImpl implements MemoryRemoteDocumentCache {
     const currentSize = this.sizer(doc);
 
     this.docs = this.docs.insert(key, {
-      document: doc.clone(),
+      document: doc.mutableCopy(),
       size: currentSize,
       readTime
     });
@@ -132,7 +132,7 @@ class MemoryRemoteDocumentCacheImpl implements MemoryRemoteDocumentCache {
     const entry = this.docs.get(documentKey);
     return PersistencePromise.resolve(
       entry
-        ? entry.document.clone()
+        ? entry.document.mutableCopy()
         : MutableDocument.newInvalidDocument(documentKey)
     );
   }
@@ -147,7 +147,7 @@ class MemoryRemoteDocumentCacheImpl implements MemoryRemoteDocumentCache {
       results = results.insert(
         documentKey,
         entry
-          ? entry.document.clone()
+          ? entry.document.mutableCopy()
           : MutableDocument.newInvalidDocument(documentKey)
       );
     });
@@ -183,7 +183,7 @@ class MemoryRemoteDocumentCacheImpl implements MemoryRemoteDocumentCache {
       if (!queryMatches(query, document)) {
         continue;
       }
-      results = results.insert(document.key, document.clone());
+      results = results.insert(document.key, document.mutableCopy());
     }
     return PersistencePromise.resolve(results);
   }

packages/firestore/src/model/collections.ts

@@ -26,7 +26,7 @@ import { DocumentKey } from './document_key';
 
 /** Miscellaneous collection types / constants. */
 export interface DocumentSizeEntry {
-  document: MutableDocument;
+  document: Document;
   size: number;
 }
 

packages/firestore/src/model/document.ts

@@ -135,6 +135,9 @@ export interface Document {
 
   isEqual(other: Document | null | undefined): boolean;
 
+  /** Creates a mutable copy of this document. */
+  mutableCopy(): MutableDocument;
+
   toString(): string;
 }
 
@@ -318,7 +321,7 @@ export class MutableDocument implements Document {
     );
   }
 
-  clone(): MutableDocument {
+  mutableCopy(): MutableDocument {
     return new MutableDocument(
       this.key,
       this.documentType,

packages/firestore/test/unit/model/mutation.test.ts

@@ -505,7 +505,7 @@ describe('Mutation', () => {
     mutationResult: MutationResult,
     expected: MutableDocument
   ): void {
-    const documentCopy = base.clone();
+    const documentCopy = base.mutableCopy();
     mutationApplyToRemoteDocument(mutation, documentCopy, mutationResult);
     expect(documentCopy).to.deep.equal(expected);
   }