Merge

Author: schmidt-sebastian

.changeset/clean-numbers-flow.md

@@ -0,0 +1,9 @@
+---
+"@firebase/analytics": minor
+"firebase": minor
+---
+
+Issue 2393 fix - analytics module
+
+- Added a public method `isSupported` to Analytics module which returns true if current browser context supports initialization of analytics module.
+- Added runtime checks to Analytics module that validate if cookie is enabled in current browser and if current browser environment supports indexedDB functionalities. 

.changeset/config.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
-  "changelog": ["@changesets/changelog-github", { "repo": "firebase/firebase-js-sdk"}],
+  "changelog": ["../repo-scripts/changelog-generator", { "repo": "firebase/firebase-js-sdk"}],
   "commit": false,
   "linked": [],
   "access": "public",

.changeset/gorgeous-beers-build.md

@@ -0,0 +1,5 @@
+---
+"@firebase/storage": patch
+---
+
+Error messages for backend errors now include the backend's reponse message.

.changeset/late-ladybugs-wash.md

@@ -8,7 +8,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "@babel/core": "7.10.4",
     "@babel/preset-env": "7.10.4",
     "browserify": "16.5.1",

.changeset/nice-deers-suffer.md

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "typescript": "3.9.6"
   }
 }

.changeset/popular-cups-melt.md

@@ -0,0 +1,57 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as firebase from 'firebase/app';
+import 'firebase/firestore';
+
+// This file replaces "packages/firestore/test/integration/util/firebase_export"
+// and depends on the minified sources.
+
+let appCount = 0;
+
+export function newTestFirestore(
+  projectId: string,
+  nameOrApp?: string | firebase.app.App,
+  settings?: firebase.firestore.Settings
+): firebase.firestore.Firestore {
+  if (nameOrApp === undefined) {
+    nameOrApp = 'test-app-' + appCount++;
+  }
+  const app =
+    typeof nameOrApp === 'string'
+      ? firebase.initializeApp({ apiKey: 'fake-api-key', projectId }, nameOrApp)
+      : nameOrApp;
+
+  const firestore = firebase.firestore(app);
+  if (settings) {
+    firestore.settings(settings);
+  }
+  return firestore;
+}
+
+export function usesFunctionalApi(): false {
+  return false;
+}
+
+const Firestore = firebase.firestore.Firestore;
+const FieldPath = firebase.firestore.FieldPath;
+const Timestamp = firebase.firestore.Timestamp;
+const GeoPoint = firebase.firestore.GeoPoint;
+const FieldValue = firebase.firestore.FieldValue;
+const Blob = firebase.firestore.Blob;
+
+export { Firestore, FieldValue, FieldPath, Timestamp, Blob, GeoPoint };

.changeset/rotten-owls-drive.md

@@ -0,0 +1,57 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as firebase from 'firebase/app';
+import 'firebase/firestore/memory';
+
+// This file replaces "packages/firestore/test/integration/util/firebase_export"
+// and depends on the minified sources.
+
+let appCount = 0;
+
+export function newTestFirestore(
+  projectId: string,
+  nameOrApp?: string | firebase.app.App,
+  settings?: firebase.firestore.Settings
+): firebase.firestore.Firestore {
+  if (nameOrApp === undefined) {
+    nameOrApp = 'test-app-' + appCount++;
+  }
+  const app =
+    typeof nameOrApp === 'string'
+      ? firebase.initializeApp({ apiKey: 'fake-api-key', projectId }, nameOrApp)
+      : nameOrApp;
+
+  const firestore = firebase.firestore(app);
+  if (settings) {
+    firestore.settings(settings);
+  }
+  return firestore;
+}
+
+export function usesFunctionalApi(): false {
+  return false;
+}
+
+const Firestore = firebase.firestore.Firestore;
+const FieldPath = firebase.firestore.FieldPath;
+const Timestamp = firebase.firestore.Timestamp;
+const GeoPoint = firebase.firestore.GeoPoint;
+const FieldValue = firebase.firestore.FieldValue;
+const Blob = firebase.firestore.Blob;
+
+export { Firestore, FieldValue, FieldPath, Timestamp, Blob, GeoPoint };

.changeset/smart-cars-doubt.md

@@ -38,13 +38,6 @@ function copyTests() {
    * Therefore these tests and helpers cannot have any src/ dependencies.
    */
   const testBase = resolve(__dirname, '../../packages/firestore/test');
-  const firebaseAppSdk = 'firebase/app/dist/index.esm.js';
-  const firebaseFirestoreSdk = resolve(
-    __dirname,
-    isPersistenceEnabled()
-      ? '../../packages/firestore/dist/index.esm.js'
-      : '../../packages/firestore/dist/index.memory.esm.js'
-  );
   return gulp
     .src(
       [
@@ -63,21 +56,24 @@ function copyTests() {
          * This regex is designed to match the following statement used in our
          * firestore integration test suites:
          *
-         * import firebase from '../../util/firebase_export';
+         * import * as firebaseExport from '../../util/firebase_export';
          *
          * It will handle variations in whitespace, single/double quote
          * differences, as well as different paths to a valid firebase_export
          */
-        /import\s+firebase\s+from\s+('|")[^\1]+firebase_export\1;?/,
-        `import firebase from '${firebaseAppSdk}';
-         import '${firebaseFirestoreSdk}';
-         
+        /import\s+\* as firebaseExport\s+from\s+('|")[^\1]+firebase_export\1;?/,
+        `import * as firebaseExport from '${resolve(
+          __dirname,
+          isPersistenceEnabled()
+            ? './firebase_export'
+            : './firebase_export_memory'
+        )}';
+        
          if (typeof process === 'undefined') {
            process = { env: { INCLUDE_FIRESTORE_PERSISTENCE: '${isPersistenceEnabled()}' } } as any;
          } else {
            process.env.INCLUDE_FIRESTORE_PERSISTENCE = '${isPersistenceEnabled()}';
-         }
-         `
+         }`
       )
     )
     .pipe(

.changeset/friendly-crews-dream.md renamed to .changeset/smooth-shirts-teach.md

@@ -1,17 +1,21 @@
 {
   "name": "firebase-firestore-integration-test",
   "version": "1.0.1",
-  "private": true,
+  "private": true, 
   "scripts": {
-    "build:deps": "cd ../../packages/firestore ; yarn build",
+    "build:deps": "lerna run --scope @firebase/'{app,firestore}' --include-dependencies build",
     "build:persistence": "INCLUDE_FIRESTORE_PERSISTENCE=true gulp compile-tests",
     "build:memory": "INCLUDE_FIRESTORE_PERSISTENCE=false gulp compile-tests",
     "test": "yarn build:memory; karma start --single-run; yarn build:persistence; karma start --single-run;",
     "test:ci": "node ../../scripts/run_tests_in_ci.js",
     "test:persistence": " yarn build:persistence; karma start --single-run",
+    "test:persistence:debug:": "yarn build:persistence; karma start --auto-watch --browsers Chrome",
     "test:memory": "yarn build:memory; karma start --single-run",
-    "test:debug:persistence": "yarn build:deps; yarn build:persistence; karma start --auto-watch --browsers Chrome",
-    "test:debug:memory": "yarn build:deps; yarn build:memory; karma start --single-run"
+    "test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
+  },
+  "peerDependencies": {
+    "@firebase/app": "0.x",
+    "@firebase/firestore": "0.x"
   },
   "devDependencies": {
     "@types/mocha": "7.0.2",

.changeset/strange-lions-dress.md

@@ -8,7 +8,7 @@
     "test:manual": "mocha --exit"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "chai": "4.2.0",
     "chromedriver": "83.0.1",
     "express": "4.17.1",

.changeset/thick-rabbits-guess.md

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "@babel/core": "7.10.4",
     "@babel/preset-env": "7.10.4",
     "@types/chai": "4.2.11",

.changeset/wild-otters-fly.md

@@ -8,7 +8,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "@babel/core": "7.10.4",
     "@babel/preset-env": "7.10.4",
     "chai": "4.2.0",

integration/browserify/package.json

@@ -48,7 +48,8 @@
     "lint": "lerna run --scope @firebase/* --scope rxfire lint",
     "size-report": "node scripts/report_binary_size.js",
     "api-report": "lerna run --scope @firebase/*-exp api-report",
-    "docgen:exp": "node scripts/exp/docgen.js"
+    "docgen:exp": "node scripts/exp/docgen.js",
+    "postinstall": "yarn --cwd repo-scripts/changelog-generator build"
   },
   "repository": {
     "type": "git",
@@ -57,7 +58,8 @@
   "workspaces": [
     "packages/*",
     "packages-exp/*",
-    "integration/*"
+    "integration/*",
+    "repo-scripts/*"
   ],
   "devDependencies": {
     "@changesets/changelog-github": "0.2.6",

integration/firebase-typings/package.json

@@ -213,9 +213,11 @@ export async function deleteApp(app: FirebaseApp): Promise<void> {
   const name = app.name;
   if (_apps.has(name)) {
     _apps.delete(name);
-    await (app as _FirebaseAppInternal).container
-      .getProviders()
-      .map(provider => provider.delete());
+    await Promise.all(
+      (app as _FirebaseAppInternal).container
+        .getProviders()
+        .map(provider => provider.delete())
+    );
     (app as _FirebaseAppInternal).isDeleted = true;
   }
 }

integration/firestore/firebase_export.ts

@@ -32,7 +32,11 @@ import {
   ComponentContainer
 } from '@firebase/component';
 import { ERROR_FACTORY, AnalyticsError } from './src/errors';
-
+import {
+  isIndexedDBAvailable,
+  validateIndexedDBOpenable,
+  areCookiesEnabled
+} from '@firebase/util';
 import { name, version } from './package.json';
 
 declare global {
@@ -45,6 +49,7 @@ declare global {
  * Type constant for Firebase Analytics.
  */
 const ANALYTICS_TYPE = 'analytics';
+
 export function registerAnalytics(instance: _FirebaseNamespace): void {
   instance.INTERNAL.registerComponent(
     new Component(
@@ -55,13 +60,13 @@ export function registerAnalytics(instance: _FirebaseNamespace): void {
         const installations = container
           .getProvider('installations')
           .getImmediate();
-
         return factory(app, installations);
       },
       ComponentType.PUBLIC
     ).setServiceProps({
       settings,
-      EventName
+      EventName,
+      isSupported
     })
   );
 
@@ -97,8 +102,31 @@ registerAnalytics(firebase as _FirebaseNamespace);
 declare module '@firebase/app-types' {
   interface FirebaseNamespace {
     analytics(app?: FirebaseApp): FirebaseAnalytics;
+    isSupported(): Promise<boolean>;
   }
   interface FirebaseApp {
     analytics(): FirebaseAnalytics;
   }
 }
+
+/**
+ * this is a public static method provided to users that wraps three different checks:
+ *
+ * 1. check if cookie is enabled in current browser.
+ * 2. check if IndexedDB is supported by the browser environment.
+ * 3. check if the current browser context is valid for using IndexedDB.
+ */
+async function isSupported(): Promise<boolean> {
+  if (!areCookiesEnabled()) {
+    return false;
+  }
+  if (!isIndexedDBAvailable()) {
+    return false;
+  }
+  try {
+    const isDBOpenable: boolean = await validateIndexedDBOpenable();
+    return isDBOpenable;
+  } catch (error) {
+    return false;
+  }
+}