Skip to content

Commit 13b4b9d

Browse files
committed
failed test
1 parent dd97567 commit 13b4b9d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/test-changed-firestore.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ jobs:
3535
yarn
3636
- name: build
3737
id: build
38-
run: yarn build:changed firestore | tee ${{ runner.temp }}/yarn.log.txt
38+
run: |
39+
set -o pipefail
40+
yarn build:changed firestore | tee ${{ runner.temp }}/yarn.log.txt
3941
- name: Check if Firestore is changed
4042
id: check-changed
4143
run: egrep "Skipping all" ${{ runner.temp }}/yarn.log.txt

packages/firestore/test/integration/api/database.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -828,10 +828,9 @@ apiDescribe('Database', persistence => {
828828
})
829829
.then(() => storeEvent.awaitEvent())
830830
.then(snap => {
831-
expect(snap.data()).to.deep.equal(changedData);
831+
expect(snap.data()).to.deep.equal({});
832832
// This event could be a metadata change for fromCache as well.
833833
// We comment this line out to reduce flakiness.
834-
835834
// TODO(b/295872012): Figure out a way to check for all scenarios.
836835
// expect(snap.metadata.hasPendingWrites).to.be.false;
837836
});

0 commit comments

Comments
 (0)