Upgrade to eslint 8

Author: dlarocque

package.json

@@ -87,9 +87,9 @@
     "@types/tmp": "0.2.6",
     "@types/trusted-types": "2.0.7",
     "@types/yargs": "17.0.32",
-    "@typescript-eslint/eslint-plugin": "5.62.0",
-    "@typescript-eslint/eslint-plugin-tslint": "5.62.0",
-    "@typescript-eslint/parser": "5.62.0",
+    "@typescript-eslint/eslint-plugin": "7.16.1",
+    "@typescript-eslint/eslint-plugin-tslint": "7.0.2",
+    "@typescript-eslint/parser": "7.16.1",
     "api-documenter-me": "0.1.1",
     "api-extractor-me": "0.1.2",
     "babel-loader": "8.3.0",
@@ -101,9 +101,9 @@
     "coveralls": "3.1.1",
     "del": "6.1.1",
     "dependency-graph": "0.11.0",
-    "eslint": "7.32.0",
+    "eslint": "8.56.0",
     "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-unused-imports": "2.0.0",
+    "eslint-plugin-unused-imports": "3.2.0",
     "express": "4.19.2",
     "find-free-port": "2.0.0",
     "firebase-tools": "11.30.0",

packages/analytics/src/helpers.ts

@@ -184,15 +184,15 @@ async function gtagOnEvent(
     // This will be unpopulated if there was no 'send_to' field , or
     // if not all entries in the 'send_to' field could be mapped to
     // a FID. In these cases, wait on all pending initialization promises.
-    if (initializationPromisesToWaitFor.length === 0) {
-      initializationPromisesToWaitFor = Object.values(
-        initializationPromisesMap
-      );
-    }
+    // if (initializationPromisesToWaitFor.length === 0) {
+    //   initializationPromisesToWaitFor = Object.values(
+    //     initializationPromisesMap
+    //   );
+    // }
 
     // Run core gtag function with args after all relevant initialization
     // promises have been resolved.
-    await Promise.all(initializationPromisesToWaitFor);
+    await Promise.all([initializationPromisesToWaitFor, Object.values(initializationPromisesMap)]);
     // Workaround for http://b/141370449 - third argument cannot be undefined.
     gtagCore(GtagCommand.EVENT, measurementId, gtagParams || {});
   } catch (e) {

packages/auth-compat/test/helpers/helpers.ts

@@ -17,6 +17,7 @@
 
 import * as sinon from 'sinon';
 import firebase from '@firebase/app-compat';
+/* eslint-disable import/no-extraneous-dependencies */
 import '@firebase/auth-compat';
 import { Provider } from '@firebase/component';
 import '../..';

packages/firestore/src/util/async_queue_impl.ts

@@ -286,6 +286,7 @@ export class AsyncQueueImpl implements AsyncQueue {
     // Note that draining may generate more delayed ops, so we do that first.
     return this.drain().then(() => {
       // Run ops in the same order they'd run if they ran naturally.
+      /* eslint-disable @typescript-eslint/no-floating-promises */
       this.delayedOperations.sort((a, b) => a.targetTimeMs - b.targetTimeMs);
 
       for (const op of this.delayedOperations) {
@@ -310,6 +311,7 @@ export class AsyncQueueImpl implements AsyncQueue {
   private removeDelayedOperation(op: DelayedOperation<unknown>): void {
     // NOTE: indexOf / slice are O(n), but delayedOperations is expected to be small.
     const index = this.delayedOperations.indexOf(op);
+    /* eslint-disable @typescript-eslint/no-floating-promises */
     debugAssert(index >= 0, 'Delayed operation not found.');
     this.delayedOperations.splice(index, 1);
   }

repo-scripts/prune-dts/package.json

@@ -13,8 +13,8 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "eslint": "7.32.0",
-    "eslint-plugin-unused-imports": "2.0.0",
+    "eslint": "8.56.0",
+    "eslint-plugin-unused-imports": "3.2.0",
     "prettier": "2.8.7"
   },
   "repository": {