Updated info test and moved util to helper

Author: maneesht

packages/database-compat/test/info.test.ts

@@ -130,8 +130,7 @@ describe('.info Tests', function () {
 
     await ea.promise;
 
-    expect(typeof offsets[0]).to.equal('number');
-    expect(offsets[0]).to.be.greaterThanOrEqual(0); // There is no way for us to guarantee that the latency will be exactly 0.
+    expect(offsets[0]).to.be.a('number');
 
     // Make sure push still works
     ref.push();

packages/database/test/exp/integration.test.ts

@@ -46,6 +46,7 @@ import {
   getFreshRepo,
   getRWRefs,
   waitFor,
+  waitUntil,
   writeAndValidate
 } from '../helpers/util';
 
@@ -143,19 +144,6 @@ describe('Database@exp Tests', () => {
     );
   });
 
-  async function waitUntil(cb: () => boolean, maxRetries = 5) {
-    let count = 1;
-    return new Promise((resolve, reject) => {
-      if (cb()) {
-        resolve(true);
-      } else {
-        if (count++ === maxRetries) {
-          reject('waited too many times for conditional to be true');
-        }
-      }
-    });
-  }
-
   it('[smoketest] - calls onValue() listener when get() is called on a parent node', async () => {
     // Test that when get() is pending on a parent node, and then onValue is called on a child node, that after the get() comes back, the onValue() listener fires.
     const db = getDatabase(defaultApp);
@@ -170,9 +158,9 @@ describe('Database@exp Tests', () => {
     });
     await waitUntil(() => {
       // Because this is a test reliant on network latency, it can be difficult to reproduce. There are situations when get() resolves immediately, and the above behavior is not observed.
-      let resolved = false;
-      get(readerRef).then(() => (resolved = true));
-      return !resolved;
+      let pending = false;
+      get(readerRef).then(() => (pending = true));
+      return !pending;
     });
     const childPath = child(readerRef, 'foo1');
     const ec = EventAccumulatorFactory.waitsForExactCount(1);

packages/database/test/helpers/util.ts

@@ -130,3 +130,17 @@ export async function writeAndValidate(
   const [snap] = await ec.promise;
   expect(snap.val()).to.deep.eq(toWrite);
 }
+
+// Waits until callback function returns true
+export async function waitUntil(cb: () => boolean, maxRetries = 5) {
+  let count = 1;
+  return new Promise((resolve, reject) => {
+    if (cb()) {
+      resolve(true);
+    } else {
+      if (count++ === maxRetries) {
+        reject('waited too many times for conditional to be true');
+      }
+    }
+  });
+}