Tree-shake UMD builds (#3493)

Author: schmidt-sebastian

packages/firestore/exp/package.json

@@ -2,6 +2,7 @@
   "name": "@firebase/firestore/exp",
   "description": "A tree-shakeable version of the Firestore SDK",
   "main": "../dist/exp/index.node.umd.js",
+  "main-esm": "../dist/exp/index.node.esm2017.js",
   "module": "../dist/exp/index.browser.esm2017.js",
   "browser": "../dist/exp/index.browser.esm2017.js",
   "react-native": "../dist/exp/index.rn.esm2017.js",

packages/firestore/lite/package.json

@@ -1,7 +1,8 @@
 {
   "name": "@firebase/firestore/lite",
   "description": "A lite version of the Firestore SDK",
-  "main": "../dist/lite/index.node.esm2017.js",
+  "main": "../dist/lite/index.node.umd.js",
+  "main-esm": "../dist/lite/index.node.esm2017.js",
   "module": "../dist/lite/index.browser.esm2017.js",
   "browser": "../dist/lite/index.browser.esm2017.js",
   "react-native": "../dist/lite/index.rn.esm2017.js",

packages/firestore/rollup.config.exp.js

@@ -20,6 +20,7 @@ import alias from '@rollup/plugin-alias';
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import path from 'path';
+import sourcemaps from 'rollup-plugin-sourcemaps';
 import { terser } from 'rollup-plugin-terser';
 import { importPathTransformer } from '../../scripts/exp/ts-transform-import-path';
 
@@ -32,14 +33,14 @@ const nodePlugins = [
     typescript,
     tsconfigOverride: {
       compilerOptions: {
-        target: 'es5'
+        target: 'es2017'
       }
     },
     clean: true,
     abortOnError: false,
     transformers: [util.removeAssertTransformer, importPathTransformer]
   }),
-  json()
+  json({ preferConst: true })
 ];
 
 const browserPlugins = [
@@ -62,15 +63,41 @@ const browserPlugins = [
 ];
 
 const allBuilds = [
-  // Node build
+  // Node ESM build
   {
     input: './exp/index.ts',
+    output: {
+      file: path.resolve('./exp', pkg['main-esm']),
+      format: 'es',
+      sourcemap: true
+    },
+    plugins: [alias(util.generateAliasConfig('node')), ...nodePlugins],
+    external: util.resolveNodeExterns,
+    treeshake: {
+      moduleSideEffects: false
+    }
+  },
+  // Node UMD build
+  {
+    input: path.resolve('./exp', pkg['main-esm']),
     output: {
       file: path.resolve('./exp', pkg.main),
       format: 'umd',
-      name: 'firebase.firestore'
+      name: 'firebase.firestore',
+      sourcemap: true
     },
-    plugins: [alias(util.generateAliasConfig('node')), ...nodePlugins],
+    plugins: [
+      typescriptPlugin({
+        typescript,
+        compilerOptions: {
+          allowJs: true,
+          target: 'es5'
+        },
+        include: ['dist/exp/*.js']
+      }),
+      json(),
+      sourcemaps()
+    ],
     external: util.resolveNodeExterns,
     treeshake: {
       moduleSideEffects: false
@@ -81,7 +108,8 @@ const allBuilds = [
     input: './exp/index.ts',
     output: {
       file: path.resolve('./exp', pkg.browser),
-      format: 'es'
+      format: 'es',
+      sourcemap: true
     },
     plugins: [alias(util.generateAliasConfig('browser')), ...browserPlugins],
     external: util.resolveBrowserExterns,
@@ -94,7 +122,8 @@ const allBuilds = [
     input: './exp/index.ts',
     output: {
       file: path.resolve('./exp', pkg['react-native']),
-      format: 'es'
+      format: 'es',
+      sourcemap: true
     },
     plugins: [alias(util.generateAliasConfig('rn')), ...browserPlugins],
     external: util.resolveBrowserExterns,

packages/firestore/rollup.config.lite.js

@@ -20,6 +20,7 @@ import json from 'rollup-plugin-json';
 import alias from '@rollup/plugin-alias';
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
+import sourcemaps from 'rollup-plugin-sourcemaps';
 import { terser } from 'rollup-plugin-terser';
 import { importPathTransformer } from '../../scripts/exp/ts-transform-import-path';
 
@@ -32,14 +33,14 @@ const nodePlugins = [
     typescript,
     tsconfigOverride: {
       compilerOptions: {
-        target: 'es5'
+        target: 'es2017'
       }
     },
     clean: true,
     abortOnError: false,
     transformers: [util.removeAssertTransformer, importPathTransformer]
   }),
-  json()
+  json({ preferConst: true })
 ];
 
 const browserPlugins = [
@@ -62,15 +63,41 @@ const browserPlugins = [
 ];
 
 const allBuilds = [
-  // Node build
+  // Node ESM build
   {
     input: './lite/index.ts',
+    output: {
+      file: path.resolve('./lite', pkg['main-esm']),
+      format: 'es',
+      sourcemap: true
+    },
+    plugins: [alias(util.generateAliasConfig('node')), ...nodePlugins],
+    external: util.resolveNodeExterns,
+    treeshake: {
+      moduleSideEffects: false
+    }
+  },
+  // Node UMD build
+  {
+    input: path.resolve('./lite', pkg['main-esm']),
     output: {
       file: path.resolve('./lite', pkg.main),
       format: 'umd',
-      name: 'firebase.firestore'
+      name: 'firebase.firestore',
+      sourcemap: true
     },
-    plugins: [alias(util.generateAliasConfig('node')), ...nodePlugins],
+    plugins: [
+      typescriptPlugin({
+        typescript,
+        compilerOptions: {
+          allowJs: true,
+          target: 'es5'
+        },
+        include: ['dist/lite/*.js']
+      }),
+      json(),
+      sourcemaps()
+    ],
     external: util.resolveNodeExterns,
     treeshake: {
       moduleSideEffects: false
@@ -81,7 +108,8 @@ const allBuilds = [
     input: './lite/index.ts',
     output: {
       file: path.resolve('./lite', pkg.browser),
-      format: 'es'
+      format: 'es',
+      sourcemap: true
     },
     plugins: [alias(util.generateAliasConfig('browser')), ...browserPlugins],
     external: util.resolveBrowserExterns,
@@ -94,7 +122,8 @@ const allBuilds = [
     input: './lite/index.ts',
     output: {
       file: path.resolve('./lite', pkg['react-native']),
-      format: 'es'
+      format: 'es',
+      sourcemap: true
     },
     plugins: [alias(util.generateAliasConfig('rn')), ...browserPlugins],
     external: util.resolveBrowserExterns,