Addressed comments

Author: maneesht

config/mocharc.node.js

@@ -25,7 +25,7 @@
 const config = {
   require: 'ts-node/register',
   timeout: 5000,
-  retries: 5, // TODO(mtewani): Reset this to 5. Find a way to run the tests without stepping over itself.
+  retries: 5,
   exit: true
 };
 

packages/database/test/helpers/syncpoint-util.ts

@@ -160,7 +160,6 @@ class TestEventRegistration implements EventRegistration {
 
   matches(otherEventRegistration: EventRegistration) {
     if (otherEventRegistration instanceof TestEventRegistration) {
-      // TODO(mtewas unknown as TestEventRegistration rit
       return (
         (this as unknown as TestEventRegistration) === otherEventRegistration
       );
@@ -172,22 +171,6 @@ class TestEventRegistration implements EventRegistration {
   }
 }
 
-function patchFakeAuthFunctions(app: FirebaseApp) {
-  const token_ = null;
-
-  app['INTERNAL'] = app['INTERNAL'] || {};
-
-  app['INTERNAL']['getToken'] = function (forceRefresh) {
-    return Promise.resolve(token_);
-  };
-
-  app['INTERNAL']['addAuthTokenListener'] = function (listener) {};
-
-  app['INTERNAL']['removeAuthTokenListener'] = function (listener) {};
-
-  return app;
-}
-
 class SyncPointListenProvider implements ListenProvider {
   private listens_: { [key: string]: boolean };
   constructor() {
@@ -237,7 +220,6 @@ export class SyncPointTestParser {
       { databaseURL: 'http://tests.fblocal.com:9000' },
       'SYNCPOINT'
     );
-    patchFakeAuthFunctions(this.app);
   }
 
   // Check the number of required arguments
@@ -325,7 +307,6 @@ export class SyncPointTestParser {
           const eventFn =
             actualEventData.eventRegistration.getEventRunner(actualEventData);
           eventFn();
-          console.log(currentSpec);
           const specStep = currentSpec;
           const actualPath = this.getTestPath(optBasePath, specStep.path);
           if (!pathEquals(currentPath, actualPath)) {
@@ -454,6 +435,7 @@ export class SyncPointTestParser {
     const registrations = {};
 
     for (let i = 0; i < testSpec.steps.length; ++i) {
+      // TODO: Create a separate object structure specifically for the steps.
       const spec = unsafeClone(testSpec.steps[i]);
       if ('.comment' in spec) {
         console.log(' > ' + spec['.comment']);

packages/database/test/syncpoint.test.ts

@@ -18,6 +18,7 @@
 import { SyncPointTestParser } from './helpers/syncpoint-util';
 import syncPointSpecs from './helpers/syncPointSpec.json';
 
+// TODO: We should eventually split this up into separate tests
 describe('Syncpoint Tests', () => {
   const util = new SyncPointTestParser();
   for (let i = 0; i < syncPointSpecs.length; i++) {