Skip to content

Commit 1c2552b

Browse files
Feiyang1Feiyang1
committed
disable no used var for params in firestore
1 parent c69bdd7 commit 1c2552b

38 files changed

+170
-163
lines changed

‎packages/firestore/.eslintrc.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,14 @@
88
],
99
"rules": {
1010
"no-console":[ "error", { "allow": ["warn", "error"] }],
11-
"import/no-default-export": "error"
11+
"import/no-default-export": "error",
12+
"@typescript-eslint/no-unused-vars": [
13+
"error",
14+
{
15+
"varsIgnorePattern": "^_",
16+
"args": "none"
17+
}
18+
]
1219
},
1320
"overrides": {
1421
"files": [

‎packages/firestore/src/api/user_data_converter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ class ParseContext {
220220
return context;
221221
}
222222

223-
childContextForArray(_index: number): ParseContext {
223+
childContextForArray(index: number): ParseContext {
224224
// TODO(b/34871131): We don't support array paths right now; so make path
225225
// null.
226226
return new ParseContext(

‎packages/firestore/src/local/indexeddb_persistence.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1311,7 +1311,7 @@ export class IndexedDbLruDelegate implements ReferenceDelegate, LruDelegate {
13111311
{
13121312
index: DbTargetDocument.documentTargetsIndex
13131313
},
1314-
([targetId, _docKey], { path, sequenceNumber }) => {
1314+
([targetId, docKey], { path, sequenceNumber }) => {
13151315
if (targetId === 0) {
13161316
// if nextToReport is valid, report it, this is a new key so the
13171317
// last one must not be a member of any targets.

‎packages/firestore/src/local/indexeddb_query_cache.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ export class IndexedDbQueryCache implements QueryCache {
330330
let result = documentKeySet();
331331

332332
return store
333-
.iterate({ range, keysOnly: true }, (key, _, _control) => {
333+
.iterate({ range, keysOnly: true }, (key, _, control) => {
334334
const path = EncodedResourcePath.decode(key[1]);
335335
const docKey = new DocumentKey(path);
336336
result = result.add(docKey);
@@ -357,7 +357,7 @@ export class IndexedDbQueryCache implements QueryCache {
357357
keysOnly: true,
358358
range
359359
},
360-
([targetId, _path], _, control) => {
360+
([targetId, path], _, control) => {
361361
// Having a sentinel row for a document does not count as containing that document;
362362
// For the query cache, containing the document means the document is part of some
363363
// target.

‎packages/firestore/src/local/indexeddb_schema.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ export class SchemaConverter implements SimpleDbSchemaConverter {
213213

214214
const promises: Array<PersistencePromise<void>> = [];
215215
return documentsStore
216-
.iterate((key, _doc) => {
216+
.iterate((key, doc) => {
217217
const path = new ResourcePath(key);
218218
const docSentinelKey = sentinelKey(path);
219219
promises.push(
@@ -272,7 +272,7 @@ export class SchemaConverter implements SimpleDbSchemaConverter {
272272
)
273273
.iterate(
274274
{ keysOnly: true },
275-
([_userID, encodedPath, _batchId], _) => {
275+
([userID, encodedPath, batchId], _) => {
276276
const path = decode(encodedPath);
277277
return addEntry(path.popLast());
278278
}

‎packages/firestore/src/local/local_store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ export class LocalStore {
516516

517517
let changedDocs = maybeDocumentMap();
518518
let updatedKeys = documentKeySet();
519-
remoteEvent.documentUpdates.forEach((key, _doc) => {
519+
remoteEvent.documentUpdates.forEach((key, doc) => {
520520
updatedKeys = updatedKeys.add(key);
521521
});
522522

‎packages/firestore/src/local/memory_mutation_queue.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export class MemoryMutationQueue implements MutationQueue {
5959
) {}
6060

6161
checkEmpty(
62-
_transaction: PersistenceTransaction
62+
transaction: PersistenceTransaction
6363
): PersistencePromise<boolean> {
6464
return PersistencePromise.resolve(this.mutationQueue.length === 0);
6565
}
@@ -91,13 +91,13 @@ export class MemoryMutationQueue implements MutationQueue {
9191
}
9292

9393
getLastStreamToken(
94-
_transaction: PersistenceTransaction
94+
transaction: PersistenceTransaction
9595
): PersistencePromise<ProtoByteString> {
9696
return PersistencePromise.resolve(this.lastStreamToken);
9797
}
9898

9999
setLastStreamToken(
100-
_transaction: PersistenceTransaction,
100+
transaction: PersistenceTransaction,
101101
streamToken: ProtoByteString
102102
): PersistencePromise<void> {
103103
this.lastStreamToken = streamToken;
@@ -180,13 +180,13 @@ export class MemoryMutationQueue implements MutationQueue {
180180
}
181181

182182
getAllMutationBatches(
183-
_transaction: PersistenceTransaction
183+
transaction: PersistenceTransaction
184184
): PersistencePromise<MutationBatch[]> {
185185
return PersistencePromise.resolve(this.mutationQueue.slice());
186186
}
187187

188188
getAllMutationBatchesAffectingDocumentKey(
189-
_transaction: PersistenceTransaction,
189+
transaction: PersistenceTransaction,
190190
documentKey: DocumentKey
191191
): PersistencePromise<MutationBatch[]> {
192192
const start = new DocReference(documentKey, 0);
@@ -209,7 +209,7 @@ export class MemoryMutationQueue implements MutationQueue {
209209
}
210210

211211
getAllMutationBatchesAffectingDocumentKeys(
212-
_transaction: PersistenceTransaction,
212+
transaction: PersistenceTransaction,
213213
documentKeys: SortedMap<DocumentKey, unknown>
214214
): PersistencePromise<MutationBatch[]> {
215215
let uniqueBatchIDs = new SortedSet<number>(primitiveComparator);
@@ -231,7 +231,7 @@ export class MemoryMutationQueue implements MutationQueue {
231231
}
232232

233233
getAllMutationBatchesAffectingQuery(
234-
_transaction: PersistenceTransaction,
234+
transaction: PersistenceTransaction,
235235
query: Query
236236
): PersistencePromise<MutationBatch[]> {
237237
assert(
@@ -317,12 +317,12 @@ export class MemoryMutationQueue implements MutationQueue {
317317
});
318318
}
319319

320-
removeCachedMutationKeys(_batchId: BatchId): void {
320+
removeCachedMutationKeys(batchId: BatchId): void {
321321
// No-op since the memory mutation queue does not maintain a separate cache.
322322
}
323323

324324
containsKey(
325-
_txn: PersistenceTransaction,
325+
txn: PersistenceTransaction,
326326
key: DocumentKey
327327
): PersistencePromise<boolean> {
328328
const ref = new DocReference(key, 0);
@@ -331,7 +331,7 @@ export class MemoryMutationQueue implements MutationQueue {
331331
}
332332

333333
performConsistencyCheck(
334-
_txn: PersistenceTransaction
334+
txn: PersistenceTransaction
335335
): PersistencePromise<void> {
336336
if (this.mutationQueue.length === 0) {
337337
assert(

‎packages/firestore/src/local/memory_persistence.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ export class MemoryPersistence implements Persistence {
139139
// No op.
140140
}
141141

142-
setNetworkEnabled(_networkEnabled: boolean): void {
142+
setNetworkEnabled(networkEnabled: boolean): void {
143143
// No op.
144144
}
145145

@@ -287,7 +287,7 @@ export class MemoryEagerDelegate implements ReferenceDelegate {
287287
});
288288
}
289289

290-
documentSize(_doc: MaybeDocument): number {
290+
documentSize(doc: MaybeDocument): number {
291291
// For eager GC, we don't care about the document size, there are no size thresholds.
292292
return 0;
293293
}
@@ -326,7 +326,7 @@ export class MemoryLruDelegate implements ReferenceDelegate, LruDelegate {
326326
onTransactionStarted(): void {}
327327

328328
onTransactionCommitted(
329-
_txn: PersistenceTransaction
329+
txn: PersistenceTransaction
330330
): PersistencePromise<void> {
331331
return PersistencePromise.resolve();
332332
}

‎packages/firestore/src/local/memory_query_cache.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,32 +56,32 @@ export class MemoryQueryCache implements QueryCache {
5656

5757
constructor(private readonly persistence: MemoryPersistence) {}
5858

59-
getTargetCount(_txn: PersistenceTransaction): PersistencePromise<number> {
59+
getTargetCount(txn: PersistenceTransaction): PersistencePromise<number> {
6060
return PersistencePromise.resolve(this.targetCount);
6161
}
6262

6363
forEachTarget(
64-
_txn: PersistenceTransaction,
64+
txn: PersistenceTransaction,
6565
f: (q: QueryData) => void
6666
): PersistencePromise<void> {
6767
this.queries.forEach((_, queryData) => f(queryData));
6868
return PersistencePromise.resolve();
6969
}
7070

7171
getLastRemoteSnapshotVersion(
72-
_transaction: PersistenceTransaction
72+
transaction: PersistenceTransaction
7373
): PersistencePromise<SnapshotVersion> {
7474
return PersistencePromise.resolve(this.lastRemoteSnapshotVersion);
7575
}
7676

7777
getHighestSequenceNumber(
78-
_transaction: PersistenceTransaction
78+
transaction: PersistenceTransaction
7979
): PersistencePromise<ListenSequenceNumber> {
8080
return PersistencePromise.resolve(this.highestSequenceNumber);
8181
}
8282

8383
allocateTargetId(
84-
_transaction: PersistenceTransaction
84+
transaction: PersistenceTransaction
8585
): PersistencePromise<TargetId> {
8686
const nextTargetId = this.targetIdGenerator.after(this.highestTargetId);
8787
this.highestTargetId = nextTargetId;
@@ -173,22 +173,22 @@ export class MemoryQueryCache implements QueryCache {
173173
}
174174

175175
getQueryCount(
176-
_transaction: PersistenceTransaction
176+
transaction: PersistenceTransaction
177177
): PersistencePromise<number> {
178178
return PersistencePromise.resolve(this.targetCount);
179179
}
180180

181181
getQueryData(
182-
_transaction: PersistenceTransaction,
182+
transaction: PersistenceTransaction,
183183
query: Query
184184
): PersistencePromise<QueryData | null> {
185185
const queryData = this.queries.get(query) || null;
186186
return PersistencePromise.resolve(queryData);
187187
}
188188

189189
getQueryDataForTarget(
190-
_transaction: PersistenceTransaction,
191-
_targetId: TargetId
190+
transaction: PersistenceTransaction,
191+
targetId: TargetId
192192
): never {
193193
// This method is only needed for multi-tab and we can't implement it
194194
// efficiently without additional data structures.

‎packages/firestore/src/local/memory_remote_document_cache.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ export class MemoryRemoteDocumentCache implements RemoteDocumentCache {
195195
}
196196

197197
getNewDocumentChanges(
198-
_transaction: PersistenceTransaction
198+
transaction: PersistenceTransaction
199199
): PersistencePromise<MaybeDocumentMap> {
200200
let changedDocs = maybeDocumentMap();
201201

@@ -216,7 +216,7 @@ export class MemoryRemoteDocumentCache implements RemoteDocumentCache {
216216
return new MemoryRemoteDocumentChangeBuffer(this.sizer, this);
217217
}
218218

219-
getSize(_txn: PersistenceTransaction): PersistencePromise<number> {
219+
getSize(txn: PersistenceTransaction): PersistencePromise<number> {
220220
return PersistencePromise.resolve(this.size);
221221
}
222222
}

‎packages/firestore/src/local/persistence_promise.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,13 +156,13 @@ export class PersistencePromise<T> {
156156
static resolve(): PersistencePromise<void>;
157157
static resolve<R>(result: R): PersistencePromise<R>;
158158
static resolve<R>(result?: R): PersistencePromise<R | void> {
159-
return new PersistencePromise<R | void>((resolve, _reject) => {
159+
return new PersistencePromise<R | void>((resolve, reject) => {
160160
resolve(result);
161161
});
162162
}
163163

164164
static reject<R>(error: Error): PersistencePromise<R> {
165-
return new PersistencePromise<R>((_resolve, reject) => {
165+
return new PersistencePromise<R>((resolve, reject) => {
166166
reject(error);
167167
});
168168
}

‎packages/firestore/src/local/shared_client_state.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,14 +1118,14 @@ export class MemorySharedClientState implements SharedClientState {
11181118
| ((sequenceNumber: ListenSequenceNumber) => void)
11191119
| null = null;
11201120

1121-
addPendingMutation(_batchId: BatchId): void {
1121+
addPendingMutation(batchId: BatchId): void {
11221122
// No op.
11231123
}
11241124

11251125
updateMutationState(
1126-
_batchId: BatchId,
1127-
_state: 'acknowledged' | 'rejected',
1128-
_error?: FirestoreError
1126+
batchId: BatchId,
1127+
state: 'acknowledged' | 'rejected',
1128+
error?: FirestoreError
11291129
): void {
11301130
// No op.
11311131
}
@@ -1138,7 +1138,7 @@ export class MemorySharedClientState implements SharedClientState {
11381138
updateQueryState(
11391139
targetId: TargetId,
11401140
state: QueryTargetState,
1141-
_error?: FirestoreError
1141+
error?: FirestoreError
11421142
): void {
11431143
this.queryState[targetId] = state;
11441144
}
@@ -1169,18 +1169,18 @@ export class MemorySharedClientState implements SharedClientState {
11691169
}
11701170

11711171
handleUserChange(
1172-
_user: User,
1173-
_removedBatchIds: BatchId[],
1174-
_addedBatchIds: BatchId[]
1172+
user: User,
1173+
removedBatchIds: BatchId[],
1174+
addedBatchIds: BatchId[]
11751175
): void {
11761176
// No op.
11771177
}
11781178

1179-
setOnlineState(_onlineState: OnlineState): void {
1179+
setOnlineState(onlineState: OnlineState): void {
11801180
// No op.
11811181
}
11821182

11831183
shutdown(): void {}
11841184

1185-
writeSequenceNumber(_sequenceNumber: ListenSequenceNumber): void {}
1185+
writeSequenceNumber(sequenceNumber: ListenSequenceNumber): void {}
11861186
}

‎packages/firestore/src/model/document_set.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export class DocumentSet {
9393

9494
/** Iterates documents in order defined by "comparator" */
9595
forEach(cb: (doc: Document) => void): void {
96-
this.sortedSet.inorderTraversal((k, _v) => {
96+
this.sortedSet.inorderTraversal((k, v) => {
9797
cb(k);
9898
return false;
9999
});

0 commit comments

Comments
 (0)