Skip to content

Commit 1e717d6

Browse files
committed
early return if no test tasks
1 parent 4b5ff69 commit 1e717d6

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

scripts/ci-test/build.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ export async function buildForTests(
2727
) {
2828
try {
2929
if (testTasks.length === 0) {
30-
chalk`{green No test tasks. Skipping all tests }`;
30+
console.log(chalk`{green No test tasks. Skipping all builds }`);
31+
return;
3132
}
3233

3334
// hack to build Firestore which depends on @firebase/app-exp (because of firestore exp),

scripts/ci-test/run_changed.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ const specialPaths = {
7979
],
8080
'scripts/emulator-testing/firestore-test-runner.ts': ['@firebase/firestore'],
8181
'scripts/emulator-testing/database-test-runner.ts': ['@firebase/database'],
82-
'packages/firestore': ['firebase-firestore-integration-test']
82+
'packages/firestore': ['firebase-firestore-integration-test'],
83+
'packages/messaging': ['firebase-messaging-integration-test']
8384
};
8485

8586
/**

scripts/ci-test/run_changed_fcm_integration.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ const includeOnlyPackages = ['firebase-messaging-integration-test'];
2323
async function run() {
2424
let testTasks = await getTestTasks();
2525
testTasks = testTasks.filter(t => includeOnlyPackages.includes(t.pkgName));
26+
2627
await buildForTests(testTasks);
2728
runTests(testTasks);
2829
}

0 commit comments

Comments
 (0)