Skip to content

Commit 1e7771c

Browse files
authored
use secret team as code owners to avoid review requests spam. (#1458)
* use secret teams to avoid review requests * [AUTOMATED]: Prettier Code Styling
1 parent 9982004 commit 1e7771c

File tree

2 files changed

+53
-18
lines changed

2 files changed

+53
-18
lines changed

.github/CODEOWNERS

Lines changed: 51 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,69 @@
11
# Lines starting with '#' are comments.
22
# Each line is a file pattern followed by one or more owners.
33

4+
######################################################################################################
5+
#
6+
# Team structure and memberships
7+
#
8+
#######################################################################################################
9+
10+
# ===========================================================
11+
# @firebase/jssdk-global-approvers
12+
# ===========================================================
13+
# Used for approving minor changes, large-scale refactorings, and emergency situations.
14+
# (secret team to avoid review requests)
15+
#
16+
# - @Feiyang1
17+
# - @hiranya911
18+
# - @mikelehen
19+
# - @bojeil-google
20+
# - @depoll
21+
# - @hsubox76
22+
23+
24+
# ===========================================================
25+
# @firebase/firestore-js-team
26+
# ===========================================================
27+
# Used for approving firestore changes.
28+
# (secret team to avoid review requests)
29+
#
30+
# - @mikelehen
31+
# - @schmidt-sebastian
32+
# - @wilhuff
33+
# - @gsoltis
34+
# - @var-const
35+
# - @rsgowman
36+
# - @zxu123
37+
38+
439
# These owners will be the default owners for everything in the repo.
5-
* @Feiyang1 @hiranya911 @mikelehen @bojeil-google @depoll
40+
* @Feiyang1 @hiranya911 @hsubox76 @firebase/jssdk-global-approvers
641

742
# Database Code
8-
packages/database @mikelehen @schmidt-sebastian
9-
packages/database-types @mikelehen @schmidt-sebastian
43+
packages/database @mikelehen @schmidt-sebastian @firebase/jssdk-global-approvers
44+
packages/database-types @mikelehen @schmidt-sebastian @firebase/jssdk-global-approvers
1045

1146
# Firestore Code
12-
packages/firestore @mikelehen @schmidt-sebastian @wilhuff @gsoltis @var-const @rsgowman @zxu123
13-
packages/webchannel-wrapper @mikelehen @schmidt-sebastian @wilhuff @gsoltis @var-const @rsgowman @zxu123
14-
packages/firestore-types @mikelehen @schmidt-sebastian @wilhuff @gsoltis @var-const @rsgowman @zxu123
15-
integration/firestore @mikelehen @schmidt-sebastian @wilhuff @gsoltis @var-const @rsgowman @zxu123
47+
packages/firestore @firebase/firestore-js-team @firebase/jssdk-global-approvers
48+
packages/webchannel-wrapper @firebase/firestore-js-team @firebase/jssdk-global-approvers
49+
packages/firestore-types @firebase/firestore-js-team @firebase/jssdk-global-approvers
50+
integration/firestore @firebase/firestore-js-team @firebase/jssdk-global-approvers
1651

1752
# Storage Code
18-
packages/storage @schmidt-sebastian
19-
packages/storage-types @schmidt-sebastian
53+
packages/storage @schmidt-sebastian @firebase/jssdk-global-approvers
54+
packages/storage-types @schmidt-sebastian @firebase/jssdk-global-approvers
2055

2156
# Messaging Code
22-
packages/messaging @pinarx @mmermerkaya @dwoffinden
23-
packages/messaging-types @pinarx @mmermerkaya @dwoffinden
24-
integration/messaging @pinarx @mmermerkaya @dwoffinden
57+
packages/messaging @pinarx @mmermerkaya @dwoffinden @firebase/jssdk-global-approvers
58+
packages/messaging-types @pinarx @mmermerkaya @dwoffinden @firebase/jssdk-global-approvers
59+
integration/messaging @pinarx @mmermerkaya @dwoffinden @firebase/jssdk-global-approvers
2560

2661
# Auth Code
27-
packages/auth @bojeil-google @wti806
28-
packages/auth-types @bojeil-google @wti806
62+
packages/auth @bojeil-google @wti806 @firebase/jssdk-global-approvers
63+
packages/auth-types @bojeil-google @wti806 @firebase/jssdk-global-approvers
2964

3065
# Testing Code
31-
packages/testing @tonymeng @ryanpbrewster
66+
packages/testing @tonymeng @ryanpbrewster @firebase/jssdk-global-approvers
3267

3368
# RxFire Code
34-
packages/rxfire @davideast
69+
packages/rxfire @davideast @firebase/jssdk-global-approvers

packages/testing/src/api/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,10 @@ function initializeApp(
109109
): firebase.app.App {
110110
let appOptions = {};
111111
if (databaseName) {
112-
appOptions["databaseURL"] = `http://${DATABASE_ADDRESS}?ns=${databaseName}`;
112+
appOptions['databaseURL'] = `http://${DATABASE_ADDRESS}?ns=${databaseName}`;
113113
}
114114
if (projectId) {
115-
appOptions["projectId"] = projectId;
115+
appOptions['projectId'] = projectId;
116116
}
117117
const appName = 'app-' + new Date().getTime() + '-' + Math.random();
118118
let app = firebase.initializeApp(appOptions, appName);

0 commit comments

Comments
 (0)