Address PR comments

Author: hsubox76

.changeset/mean-comics-cheat.md

@@ -71,14 +71,15 @@
     "@types/child-process-promise": "2.2.1",
     "@types/clone": "0.1.30",
     "@types/inquirer": "7.3.0",
+    "@types/listr": "0.14.2",
     "@types/long": "4.0.1",
     "@types/mocha": "7.0.2",
+    "@types/mz": "2.7.1",
     "@types/node": "12.12.53",
     "@types/sinon": "9.0.4",
     "@types/sinon-chai": "3.2.4",
     "@types/tmp": "0.2.0",
     "@types/yargs": "15.0.5",
-    "@types/listr": "0.14.2",
     "@typescript-eslint/eslint-plugin": "2.34.0",
     "@typescript-eslint/eslint-plugin-tslint": "2.34.0",
     "@typescript-eslint/parser": "2.34.0",
@@ -111,11 +112,11 @@
     "karma-coverage-istanbul-reporter": "2.1.1",
     "karma-firefox-launcher": "1.3.0",
     "karma-mocha": "2.0.1",
+    "karma-mocha-reporter": "2.2.5",
     "karma-safari-launcher": "1.0.0",
     "karma-sauce-launcher": "1.2.0",
     "karma-sourcemap-loader": "0.3.7",
     "karma-spec-reporter": "0.0.32",
-    "karma-mocha-reporter": "2.2.5",
     "karma-summary-reporter": "1.8.0",
     "karma-webpack": "4.0.2",
     "lcov-result-merger": "3.1.0",

package.json

@@ -15,11 +15,10 @@
  * limitations under the License.
  */
 
-const { resolve } = require('path');
-const { spawn, exec } = require('child-process-promise');
-const chalk = require('chalk');
-const simpleGit = require('simple-git/promise');
-const fs = require('mz/fs');
+import { resolve } from 'path';
+import chalk from 'chalk';
+import simpleGit from 'simple-git/promise';
+import fs from 'mz/fs';
 
 const root = resolve(__dirname, '..');
 const git = simpleGit(root);
@@ -34,7 +33,7 @@ async function getDiffData(): Promise<{
   const diff = await git.diff(['--name-only', 'origin/master...HEAD']);
   const changedFiles = diff.split('\n');
   let changesetFile = '';
-  const changedPackagesMap: { [key: string]: boolean } = {};
+  const changedPackagesMap = new Set();
   for (const filename of changedFiles) {
     // Check for an existing .changeset
     const changesetMatch = filename.match(/^\.changeset\/[a-zA-Z-]+\.md/);
@@ -51,7 +50,7 @@ async function getDiffData(): Promise<{
       ));
       if (changedPackage) {
         // Add the package itself.
-        changedPackagesMap[changedPackage.name] = true;
+        changedPackagesMap.add(changedPackage.name);
       }
     }
   }
@@ -86,10 +85,11 @@ async function main() {
         changedPkg => !changesetPackages.includes(changedPkg)
       );
       if (missingPackages.length > 0) {
-        // console.warn(chalk.yellow(`Warning: The following packages were `
-        // + `changed but not added to the changeset file, make sure this was `
-        // + `intentional:\n${missingPackages.join('\n')}`));
-        // process.exit(1);
+        /**
+         * Sets Github Actions output for a step. Pass missing package list to next
+         * step. See:
+         * https://github.com/actions/toolkit/blob/master/docs/commands.md#set-outputs
+         */
         console.log(
           `::set-output name=MISSING_PACKAGES::${missingPackages
             .map(pkg => `- ${pkg}`)

scripts/check_changeset.ts

@@ -2371,6 +2371,13 @@
   resolved "https://registry.npmjs.org/@types/mocha/-/mocha-7.0.2.tgz#b17f16cf933597e10d6d78eae3251e692ce8b0ce"
   integrity sha512-ZvO2tAcjmMi8V/5Z3JsyofMe3hasRcaw88cto5etSVMwVQfeivGAlEYmaQgceUSVYFofVjT+ioHsATjdWcFt1w==
 
+"@types/[email protected]":
+  version "2.7.1"
+  resolved "https://registry.npmjs.org/@types/mz/-/mz-2.7.1.tgz#1ac1d69b039c8b3cbe603972b5c12d3167a84f58"
+  integrity sha512-H86h7KmRDVs9UeSiQvtUeVhS+WYpJSYSsZrRvNYpGWGiytEqxwEtvgRnINESQtCgnojIH2wS2WgaMTJP0firBw==
+  dependencies:
+    "@types/node" "*"
+
 "@types/[email protected]":
   version "2.5.7"
   resolved "https://registry.npmjs.org/@types/node-fetch/-/node-fetch-2.5.7.tgz#20a2afffa882ab04d44ca786449a276f9f6bbf3c"