Remove circular dependency issue with AuthCredential (#3718)

* Fix circular dependency issue

* Formatting

Author: sam-gc

packages-exp/auth-exp/src/core/credentials/auth_credential.ts

@@ -18,7 +18,6 @@
 import { PhoneOrOauthTokenResponse } from '../../api/authentication/mfa';
 import { AuthCore } from '../../model/auth';
 import { IdTokenResponse } from '../../model/id_token';
-import { EmailAuthCredential, OAuthCredential, PhoneAuthCredential } from './';
 import { debugFail } from '../util/assert';
 
 export class AuthCredential {
@@ -27,21 +26,6 @@ export class AuthCredential {
     readonly signInMethod: string
   ) {}
 
-  static fromJSON(json: object | string): AuthCredential | null {
-    for (const fn of [
-      /* SAMLAuthCredential.fromJSON, */
-      OAuthCredential.fromJSON,
-      EmailAuthCredential.fromJSON,
-      PhoneAuthCredential.fromJSON
-    ]) {
-      const credential = fn(json);
-      if (credential) {
-        return credential;
-      }
-    }
-    return null;
-  }
-
   toJSON(): object {
     return debugFail('not implemented');
   }

packages-exp/auth-exp/src/core/credentials/email.ts

@@ -27,7 +27,7 @@ import { AuthCore } from '../../model/auth';
 import { IdTokenResponse } from '../../model/id_token';
 import { AuthErrorCode } from '../errors';
 import { fail } from '../util/assert';
-import { AuthCredential } from './';
+import { AuthCredential } from './auth_credential';
 
 export class EmailAuthCredential
   extends AuthCredential

packages-exp/auth-exp/src/core/credentials/oauth.ts

@@ -23,10 +23,10 @@ import {
   SignInWithIdpRequest
 } from '../../api/authentication/idp';
 import { AuthCore } from '../../model/auth';
+import { IdTokenResponse } from '../../model/id_token';
 import { AuthErrorCode } from '../errors';
 import { fail } from '../util/assert';
-import { AuthCredential } from './';
-import { IdTokenResponse } from '../../model/id_token';
+import { AuthCredential } from './auth_credential';
 
 const IDP_REQUEST_URI = 'http://localhost';
 

packages-exp/auth-exp/src/core/credentials/phone.ts

@@ -26,7 +26,7 @@ import {
 } from '../../api/authentication/sms';
 import { AuthCore } from '../../model/auth';
 import { IdTokenResponse } from '../../model/id_token';
-import { AuthCredential } from './';
+import { AuthCredential } from './auth_credential';
 
 export interface PhoneAuthCredentialParameters {
   verificationId?: string;