Skip to content

Commit 211a790

Browse files
committed
PR feedback
1 parent af674ac commit 211a790

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

packages-exp/auth-exp/src/core/user/token_manager.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,14 @@ describe('core/user/token_manager', () => {
7474
});
7575
});
7676

77+
describe('#clearRefreshToken', () => {
78+
it('sets refresh token to null', () => {
79+
stsTokenManager.refreshToken = 'refresh-token';
80+
stsTokenManager.clearRefreshToken();
81+
expect(stsTokenManager.refreshToken).to.be.null;
82+
});
83+
});
84+
7785
describe('#getToken', () => {
7886
context('with endpoint setup', () => {
7987
let mock: fetch.Route;

packages-exp/auth-exp/src/core/user/token_manager.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,10 @@ export class StsTokenManager {
8181
};
8282
}
8383

84+
clearRefreshToken(): void {
85+
this.refreshToken = null;
86+
}
87+
8488
toPlainObject(): object {
8589
return {
8690
refreshToken: this.refreshToken,

packages-exp/auth-exp/src/core/user/user_impl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export class UserImpl implements User {
103103
async delete(): Promise<void> {
104104
const idToken = await this.getIdToken();
105105
await deleteAccount(this.auth, { idToken });
106-
this.stsTokenManager.refreshToken = null;
106+
this.stsTokenManager.clearRefreshToken();
107107

108108
// TODO: Determine if cancellable-promises are necessary to use in this class so that delete()
109109
// cancels pending actions...

0 commit comments

Comments
 (0)