Merge branch 'master' into fei-health

Author: Feiyang1

.changeset/blue-rice-ring.md

@@ -0,0 +1,6 @@
+---
+"firebase": minor
+"@firebase/remote-config": minor
+---
+
+Issue 2393 - Add environment check to Remote-Config Module

.changeset/clean-cameras-check.md

@@ -0,0 +1,5 @@
+---
+'@firebase/firestore': minor
+---
+
+Fixed a bug where `UpdateData` did not recognize union types or optional, dot-separated string fields.

.changeset/curly-elephants-cover.md

@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Fix bug with the user `emailVerified` field persistence across tabs

.changeset/fast-brooms-tie.md

@@ -0,0 +1,5 @@
+---
+"@firebase/rules-unit-testing": patch
+---
+
+Fix typing issues where Database/Firestore/Storage compat instances returned by RulesTestContext are not compatible with v9 modular APIs.

.changeset/little-foxes-own.md

@@ -0,0 +1,5 @@
+---
+"@firebase/rules-unit-testing": patch
+---
+
+Set RTDB namespace to be same as projectId by default instead of `${projectId}-default-rtdb`. This fixes rules not being applied and other issues related to namespace mismatch.

.changeset/neat-pants-wonder.md

@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Add missing phone FACTOR_ID static property to the PhoneMultiFactorGenerator class

.changeset/shiny-rats-move.md

@@ -0,0 +1,5 @@
+---
+"@firebase/webchannel-wrapper": patch
+---
+
+Remove an unused option (`backgroundChannelTest`).

.changeset/tender-walls-hang.md

@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Fix wrongly-typed tenantId fields in requests to some endpoints

.github/CODEOWNERS

@@ -25,9 +25,10 @@
 #  (secret team to avoid review requests)
 #
 # - @schmidt-sebastian
-# - @wilhuff
-# - @var-const
-# - @zxu123
+# - @thebrianchen
+# - @wu-hui
+# - @ehsannas
+# - @dconeybe
 
 
 # These owners will be the default owners for everything in the repo.
@@ -40,6 +41,7 @@ packages/database-types @schmidt-sebastian @jsdt @firebase/jssdk-global-approver
 
 # Firestore Code
 packages/firestore  @firebase/firestore-js-team @firebase/jssdk-global-approvers
+packages/firestore-compat  @firebase/firestore-js-team @firebase/jssdk-global-approvers
 packages/webchannel-wrapper  @firebase/firestore-js-team @firebase/jssdk-global-approvers
 packages/firestore-types  @firebase/firestore-js-team @firebase/jssdk-global-approvers
 integration/firestore  @firebase/firestore-js-team @firebase/jssdk-global-approvers

.github/workflows/release-log.yml

@@ -0,0 +1,23 @@
+name: Log Release PR
+
+on:
+  pull_request:
+    branches:
+      - release
+      - v8-releasebranch
+
+jobs:
+  release:
+    name: Send PR number to tracker endpoint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@master
+
+      - name: Setup Node.js 14.x
+        uses: actions/setup-node@master
+        with:
+          node-version: 14.x
+
+      - name: Get PR number and send to tracker.
+        run: node scripts/ci/log-changesets.js

.github/workflows/release.yml

@@ -23,7 +23,9 @@ jobs:
         run: yarn
 
       - name: Add a changeset for @firebase/app
-        run: yarn ts-node-script scripts/ci/add_changeset.ts
+        run: |
+          git pull -f origin master:master
+          yarn ts-node-script scripts/ci/add_changeset.ts
 
       - name: Create Release Pull Request
         uses: changesets/action@master

.gitignore

@@ -4,7 +4,7 @@ dist
 .awcache
 .cache
 /config/project.json
-scripts/docgen/html
+scripts/docgen-compat/html
 
 # OS Specific Files
 .DS_Store

common/api-review/auth.api.md

@@ -596,6 +596,7 @@ export interface PhoneMultiFactorEnrollInfoOptions {
 // @public
 export class PhoneMultiFactorGenerator {
     static assertion(credential: PhoneAuthCredential): PhoneMultiFactorAssertion;
+    static FACTOR_ID: string;
 }
 
 // @public

common/api-review/firestore-lite.api.md

@@ -32,6 +32,9 @@ export class Bytes {
     toUint8Array(): Uint8Array;
 }
 
+// @public
+export type ChildUpdateFields<K extends string, V> = V extends Record<string, unknown> ? AddPrefixToKeys<K, UpdateData<V>> : never;
+
 // @public
 export function collection(firestore: Firestore, path: string, ...pathSegments: string[]): CollectionReference<DocumentData>;
 
@@ -191,7 +194,7 @@ export { LogLevel }
 
 // @public
 export type NestedUpdateFields<T extends Record<string, unknown>> = UnionToIntersection<{
-    [K in keyof T & string]: T[K] extends Record<string, unknown> ? AddPrefixToKeys<K, UpdateData<T[K]>> : never;
+    [K in keyof T & string]: ChildUpdateFields<K, T[K]>;
 }[keyof T & string]>;
 
 // @public
@@ -332,7 +335,7 @@ export class Transaction {
 export type UnionToIntersection<U> = (U extends unknown ? (k: U) => void : never) extends (k: infer I) => void ? I : never;
 
 // @public
-export type UpdateData<T> = T extends Primitive ? T : T extends Map<infer K, infer V> ? Map<UpdateData<K>, UpdateData<V>> : T extends {} ? {
+export type UpdateData<T> = T extends Primitive ? T : T extends {} ? {
     [K in keyof T]?: UpdateData<T[K]> | FieldValue;
 } & NestedUpdateFields<T> : Partial<T>;