TS changes before splitting database

Author: hsubox76

config/tsconfig.base.json

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "declaration": true,
     "importHelpers": true,
+    "strictNullChecks": true,
     "lib": [
       "es2015",
       "dom"

packages/app/src/firebaseApp.ts

@@ -115,7 +115,7 @@ export class FirebaseAppImpl implements FirebaseApp {
 
         return Promise.all(
           services.map(service => {
-            return service.INTERNAL.delete();
+            return service.INTERNAL ? service.INTERNAL.delete() : Promise.resolve();
           })
         );
       })

packages/app/src/lite/firebaseAppLite.ts

@@ -97,7 +97,7 @@ export class FirebaseAppLiteImpl implements FirebaseApp {
 
         return Promise.all(
           services.map(service => {
-            return service.INTERNAL.delete();
+            return service.INTERNAL ? service.INTERNAL.delete() : Promise.resolve();
           })
         );
       })

packages/database/index.node.ts

@@ -81,7 +81,7 @@ export function registerDatabase(instance: FirebaseNamespace) {
       ServerValue,
       TEST_ACCESS
     },
-    null,
+    undefined,
     true
   );
 

packages/database/src/api/Database.ts

@@ -32,7 +32,7 @@ import { RepoInfo } from '../core/RepoInfo';
  * @implements {FirebaseService}
  */
 export class Database implements FirebaseService {
-  INTERNAL: DatabaseInternals;
+  INTERNAL?: DatabaseInternals;
   private root_: Reference;
 
   static readonly ServerValue = {
@@ -141,7 +141,7 @@ export class Database implements FirebaseService {
 
 export class DatabaseInternals {
   /** @param {!Database} database */
-  constructor(public database: Database) {}
+  constructor(public database?: Database) {}
 
   /** @return {Promise<void>} */
   async delete(): Promise<void> {
@@ -150,7 +150,9 @@ export class DatabaseInternals {
 
     (this.database as any).repo_ = null;
     (this.database as any).root_ = null;
-    this.database.INTERNAL = null;
-    this.database = null;
+    if (this.database) {
+      this.database.INTERNAL = undefined;
+    }
+    this.database = undefined;
   }
 }

packages/database/src/api/Query.ts

@@ -254,7 +254,7 @@ export class Query {
     const container = new ChildEventRegistration(
       callbacks,
       cancelCallback,
-      context
+      context || undefined
     );
     this.repo.addEventCallbackForQuery(this, container);
   }
@@ -270,7 +270,7 @@ export class Query {
     context?: Object | null
   ): void {
     validateArgCount('Query.off', 0, 3, arguments.length);
-    validateEventType('Query.off', 1, eventType, true);
+    validateEventType('Query.off', 1, eventType || '', true);
     validateCallback('Query.off', 2, callback, true);
     validateContextObject('Query.off', 3, context, true);
 
@@ -288,7 +288,7 @@ export class Query {
         callbacks = {};
         callbacks[eventType] = callback;
       }
-      container = new ChildEventRegistration(callbacks, null, context || null);
+      container = new ChildEventRegistration(callbacks, null, context || undefined);
     }
     this.repo.removeEventCallbackForQuery(this, container);
   }
@@ -498,7 +498,7 @@ export class Query {
   ): Query {
     validateArgCount('Query.startAt', 0, 2, arguments.length);
     validateFirebaseDataArg('Query.startAt', 1, value, this.path, true);
-    validateKey('Query.startAt', 2, name, true);
+    validateKey('Query.startAt', 2, name || undefined, true);
 
     const newParams = this.queryParams_.startAt(value, name);
     Query.validateLimit_(newParams);
@@ -529,7 +529,7 @@ export class Query {
   ): Query {
     validateArgCount('Query.endAt', 0, 2, arguments.length);
     validateFirebaseDataArg('Query.endAt', 1, value, this.path, true);
-    validateKey('Query.endAt', 2, name, true);
+    validateKey('Query.endAt', 2, name || undefined, true);
 
     const newParams = this.queryParams_.endAt(value, name);
     Query.validateLimit_(newParams);

packages/database/src/core/Repo.ts

@@ -132,7 +132,7 @@ export class Repo {
     }
 
     authTokenProvider.addTokenChangeListener(token => {
-      this.server_.refreshAuthToken(token);
+      token && this.server_.refreshAuthToken(token);
     });
 
     // In the case of multiple Repos for the same repoInfo (i.e. there are multiple Firebase.Contexts being used),
@@ -240,7 +240,7 @@ export class Repo {
     data = this.interceptServerDataCallback_
       ? this.interceptServerDataCallback_(pathString, data)
       : data;
-    let events = [];
+    let events: Array<Event> = [];
     if (tag) {
       if (isMerge) {
         const taggedChildren = map(data as { [k: string]: any }, (raw: any) =>
@@ -602,7 +602,7 @@ export class Repo {
    */
   removeEventCallbackForQuery(
     query: Query,
-    eventRegistration: EventRegistration
+    eventRegistration: EventRegistration | null
   ) {
     // These are guaranteed not to raise events, since we're not passing in a cancelError. However, we can future-proof
     // a little bit by handling the return values anyways.

packages/database/src/core/RepoManager.ts

@@ -80,7 +80,7 @@ export class RepoManager {
    * @return {!Database}
    */
   databaseFromApp(app: FirebaseApp, url?: string): Database {
-    const dbUrl: string = url || app.options[DATABASE_URL_OPTION];
+    const dbUrl: string | undefined = url || app.options[DATABASE_URL_OPTION];
     if (dbUrl === undefined) {
       fatal(
         "Can't determine Firebase Database URL.  Be sure to include " +
@@ -89,7 +89,7 @@ export class RepoManager {
       );
     }
 
-    const parsedUrl = parseRepoInfo(dbUrl);
+    const parsedUrl = parseRepoInfo(dbUrl || '');
     const repoInfo = parsedUrl.repoInfo;
 
     validateUrl('Invalid Firebase Database URL', 1, parsedUrl);

packages/database/src/core/SparseSnapshotTree.ts

@@ -48,7 +48,7 @@ export class SparseSnapshotTree {
     if (this.value_ != null) {
       return this.value_.getChild(path);
     } else if (!path.isEmpty() && this.children_ != null) {
-      const childKey = path.getFront();
+      const childKey = path.getFront() || '';
       path = path.popFront();
       if (this.children_.contains(childKey)) {
         const childTree = this.children_.get(childKey) as SparseSnapshotTree;
@@ -79,7 +79,7 @@ export class SparseSnapshotTree {
         this.children_ = new CountedSet<string, SparseSnapshotTree>();
       }
 
-      const childKey = path.getFront();
+      const childKey = path.getFront() || '';
       if (!this.children_.contains(childKey)) {
         this.children_.add(childKey, new SparseSnapshotTree());
       }
@@ -118,7 +118,7 @@ export class SparseSnapshotTree {
           return this.forget(path);
         }
       } else if (this.children_ !== null) {
-        const childKey = path.getFront();
+        const childKey = path.getFront() || '';
         path = path.popFront();
         if (this.children_.contains(childKey)) {
           const safeToRemove = (this.children_.get(

packages/database/src/core/SyncPoint.ts

@@ -149,7 +149,7 @@ export class SyncPoint {
           false
         ),
         new CacheNode(
-          /** @type {!Node} */ (serverCache),
+          /** @type {!Node} */ (serverCache as Node),
           serverCacheComplete,
           false
         )

packages/database/src/core/SyncTree.ts

@@ -163,7 +163,7 @@ export class SyncTree {
   ackUserWrite(writeId: number, revert: boolean = false) {
     const write = this.pendingWriteTree_.getWrite(writeId);
     const needToReevaluate = this.pendingWriteTree_.removeWrite(writeId);
-    if (!needToReevaluate) {
+    if (!needToReevaluate || !write) {
       return [];
     } else {
       let affectedTree = ImmutableTree.Empty;
@@ -350,7 +350,7 @@ export class SyncTree {
       const subtree = this.syncPointTree_.subtree(path);
       subtree.foreachChild(function(childName, childSyncPoint) {
         const completeCache = childSyncPoint.getCompleteServerCache(Path.Empty);
-        if (completeCache) {
+        if (completeCache && serverCache) {
           serverCache = serverCache.updateImmediateChild(
             childName,
             completeCache
@@ -381,7 +381,7 @@ export class SyncTree {
       serverCacheComplete
     );
     if (!viewAlreadyExists && !foundAncestorDefaultView) {
-      const view /** @type !View */ = syncPoint.viewForQuery(query);
+      const view /** @type !View */ = syncPoint.viewForQuery(query) as View;
       events = events.concat(this.setupListener_(query, view));
     }
     return events;
@@ -530,7 +530,7 @@ export class SyncTree {
     });
     return writeTree.calcCompleteEventCache(
       path,
-      serverCache,
+      serverCache || null,
       writeIdsToExclude,
       includeHiddenSets
     );
@@ -551,7 +551,7 @@ export class SyncTree {
       (relativePath, maybeChildSyncPoint, childMap) => {
         if (maybeChildSyncPoint && maybeChildSyncPoint.hasCompleteView()) {
           const completeView = maybeChildSyncPoint.getCompleteView();
-          return [completeView];
+          return [completeView as View];
         } else {
           // No complete view here, flatten any deeper listens into an array
           let views: View[] = [];
@@ -628,10 +628,12 @@ export class SyncTree {
     // The root of this subtree has our query. We're here because we definitely need to send a listen for that, but we
     // may need to shadow other listens as well.
     if (tag) {
-      assert(
-        !subtree.value.hasCompleteView(),
-        "If we're adding a query, it shouldn't be shadowed"
-      );
+      if (subtree.value) {
+        assert(
+          !subtree.value.hasCompleteView(),
+          "If we're adding a query, it shouldn't be shadowed"
+        );
+      }
     } else {
       // Shadow everything at or below this location, this is a default listener.
       const queriesToStop = subtree.fold<Query[]>(function(
@@ -644,7 +646,7 @@ export class SyncTree {
           maybeChildSyncPoint &&
           maybeChildSyncPoint.hasCompleteView()
         ) {
-          return [maybeChildSyncPoint.getCompleteView().getQuery()];
+          return [(maybeChildSyncPoint.getCompleteView() as View).getQuery()];
         } else {
           // No default listener here, flatten any deeper queries into an array
           let queries: Query[] = [];
@@ -787,7 +789,7 @@ export class SyncTree {
     queryPath: Path,
     operation: Operation
   ): Event[] {
-    const syncPoint = this.syncPointTree_.get(queryPath);
+    const syncPoint = this.syncPointTree_.get(queryPath) as SyncPoint;
     assert(syncPoint, "Missing sync point for query tag that we're tracking");
     const writesCache = this.pendingWriteTree_.childWrites(queryPath);
     return syncPoint.applyOperation(
@@ -855,7 +857,7 @@ export class SyncTree {
       }
 
       let events: Event[] = [];
-      const childName = operation.path.getFront();
+      const childName = operation.path.getFront() || '';
       const childOperation = operation.operationForChild(childName);
       const childTree = syncPointTree.children.get(childName);
       if (childTree && childOperation) {

packages/database/src/core/WriteTree.ts

@@ -278,7 +278,7 @@ export class WriteTree {
               (!writeIdsToExclude ||
                 !~writeIdsToExclude.indexOf(write.writeId)) &&
               (write.path.contains(treePath) || treePath.contains(write.path))
-            );
+            ) || false;
           };
           const mergeAtPath = WriteTree.layerTree_(
             this.allWrites_,
@@ -398,15 +398,15 @@ export class WriteTree {
       const childMerge = this.visibleWrites_.childCompoundWrite(path);
       if (childMerge.isEmpty()) {
         // We're not shadowing at all. Case 1
-        return existingServerSnap.getChild(childPath);
+        return (existingServerSnap as Node).getChild(childPath);
       } else {
         // This could be more efficient if the serverNode + updates doesn't change the eventSnap
         // However this is tricky to find out, since user updates don't necessary change the server
         // snap, e.g. priority updates on empty nodes, or deep deletes. Another special case is if the server
         // adds nodes, but doesn't change any existing writes. It is therefore not enough to
         // only check if the updates change the serverNode.
         // Maybe check if the merge tree contains these special cases and only do a full overwrite in that case?
-        return childMerge.apply(existingServerSnap.getChild(childPath));
+        return childMerge.apply((existingServerSnap as Node).getChild(childPath));
       }
     }
   }
@@ -486,7 +486,7 @@ export class WriteTree {
     }
     toIterate = toIterate.withIndex(index);
     if (!toIterate.isEmpty() && !toIterate.isLeafNode()) {
-      const nodes = [];
+      const nodes: Array<NamedNode> = [];
       const cmp = index.getCompare();
       const iter = reverse
         ? (toIterate as ChildrenNode).getReverseIteratorFrom(startPost, index)

packages/database/src/core/util/Path.ts

@@ -131,7 +131,7 @@ export class Path {
   parent(): Path | null {
     if (this.pieceNum_ >= this.pieces_.length) return null;
 
-    const pieces = [];
+    const pieces: Array<string> = [];
     for (let i = this.pieceNum_; i < this.pieces_.length - 1; i++)
       pieces.push(this.pieces_[i]);
 
@@ -143,7 +143,7 @@ export class Path {
    * @return {!Path}
    */
   child(childPathObj: string | Path): Path {
-    const pieces = [];
+    const pieces: Array<string> = [];
     for (let i = this.pieceNum_; i < this.pieces_.length; i++)
       pieces.push(this.pieces_[i]);
 

packages/database/src/core/util/ServerValues.ts

@@ -94,7 +94,6 @@ export const resolveDeferredValueSnapshot = function(
   const rawPri = node.getPriority().val() as
     | object
     | boolean
-    | null
     | number
     | string;
   const priority = resolveDeferredValue(rawPri, serverValues);