Don't use index.ts

Author: schmidt-sebastian

packages/firestore/exp/index.ts

@@ -15,10 +15,7 @@
  * limitations under the License.
  */
 
-import { version } from '../package.json';
-import { _registerComponent, registerVersion } from '@firebase/app-exp';
-import { Component, ComponentType } from '@firebase/component';
-import { Firestore } from './src/api/database';
+import './register';
 
 export { FieldPath, documentId } from '../lite/src/api/field_path';
 
@@ -103,22 +100,3 @@ export { GeoPoint } from '../src/api/geo_point';
 export { Timestamp } from '../src/api/timestamp';
 
 export { refEqual, queryEqual } from '../lite/src/api/reference';
-
-export function registerFirestore(): void {
-  _registerComponent(
-    new Component(
-      'firestore-exp',
-      container => {
-        const app = container.getProvider('app-exp').getImmediate()!;
-        return ((app, auth) => new Firestore(app, auth))(
-          app,
-          container.getProvider('auth-internal')
-        );
-      },
-      ComponentType.PUBLIC
-    )
-  );
-  registerVersion('firestore-exp', version, 'node');
-}
-
-registerFirestore();

packages/firestore/exp/register.ts

@@ -0,0 +1,41 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { _registerComponent, registerVersion } from '@firebase/app-exp';
+import { Component, ComponentType } from '@firebase/component';
+
+import { Firestore } from './src/api/database';
+import { version } from '../package.json';
+
+export function registerFirestore(): void {
+  _registerComponent(
+    new Component(
+      'firestore-exp',
+      container => {
+        const app = container.getProvider('app-exp').getImmediate()!;
+        return ((app, auth) => new Firestore(app, auth))(
+          app,
+          container.getProvider('auth-internal')
+        );
+      },
+      ComponentType.PUBLIC
+    )
+  );
+  registerVersion('firestore-exp', version, 'node');
+}
+
+registerFirestore();

packages/firestore/exp/test/bootstrap.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import '../';
+import '../register';
 
 /**
  * This will include all of the test files and compile them as needed
@@ -29,7 +29,7 @@ import '../';
 const testsContext = (require as any).context(
   '../../test/integration/api',
   true,
-  /^*\.test$/
+  /^.*\.test\.ts$/
 );
 const browserTests = testsContext.keys();
 browserTests.forEach(testsContext);

packages/firestore/karma.conf.js

@@ -26,7 +26,7 @@ module.exports = function (config) {
     preprocessors: {
       'exp/test/**/*.ts': ['webpack', 'sourcemap'],
       'lite/test/**/*.ts': ['webpack', 'sourcemap'],
-      'test/**/*.ts': ['webpack', 'sourcemap'],
+      'test/**/*.ts': ['webpack', 'sourcemap']
     },
 
     // frameworks to use

packages/firestore/lite/index.ts

@@ -15,10 +15,7 @@
  * limitations under the License.
  */
 
-import { registerVersion, _registerComponent } from '@firebase/app-exp';
-import { Firestore } from './src/api/database';
-import { version } from '../package.json';
-import { Component, ComponentType } from '@firebase/component';
+import './register';
 
 export {
   Firestore as FirebaseFirestore,
@@ -86,22 +83,3 @@ export { Blob } from '../src/api/blob';
 export { GeoPoint } from '../src/api/geo_point';
 
 export { Timestamp } from '../src/api/timestamp';
-
-export function registerFirestore(): void {
-  _registerComponent(
-    new Component(
-      'firestore/lite',
-      container => {
-        const app = container.getProvider('app-exp').getImmediate()!;
-        return ((app, auth) => new Firestore(app, auth))(
-          app,
-          container.getProvider('auth-internal')
-        );
-      },
-      ComponentType.PUBLIC
-    )
-  );
-  registerVersion('firestore-lite', version, 'node');
-}
-
-registerFirestore();

packages/firestore/lite/register.ts

@@ -0,0 +1,41 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { _registerComponent, registerVersion } from '@firebase/app-exp';
+import { Component, ComponentType } from '@firebase/component';
+
+import { Firestore } from './src/api/database';
+import { version } from '../package.json';
+
+export function registerFirestore(): void {
+  _registerComponent(
+    new Component(
+      'firestore/lite',
+      container => {
+        const app = container.getProvider('app-exp').getImmediate()!;
+        return ((app, auth) => new Firestore(app, auth))(
+          app,
+          container.getProvider('auth-internal')
+        );
+      },
+      ComponentType.PUBLIC
+    )
+  );
+  registerVersion('firestore-lite', version, 'node');
+}
+
+registerFirestore();

packages/firestore/lite/src/api/reference.ts

@@ -526,7 +526,11 @@ export function parent<T>(
     if (parentPath.isEmpty()) {
       return null;
     } else {
-      return new DocumentReference(child.firestore,  /* converter= */ null, parentPath);
+      return new DocumentReference(
+        child.firestore,
+        /* converter= */ null,
+        parentPath
+      );
     }
   } else {
     const doc = cast<DocumentReference<T>>(child, DocumentReference);

packages/firestore/lite/test/bootstrap.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import '../';
+import '../register';
 
 /**
  * This will include all of the test files and compile them as needed
@@ -26,6 +26,6 @@ import '../';
 
 // 'context()' definition requires additional dependency on webpack-env package.
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
-const testsContext = (require as any).context('.', true, /^.*\.test$/);
+const testsContext = (require as any).context('.', true, /^.*\.test.*$/);
 const browserTests = testsContext.keys();
 browserTests.forEach(testsContext);

packages/firestore/scripts/build-bundle.ts

@@ -22,11 +22,7 @@ const typescriptPlugin = require('rollup-plugin-typescript2');
 const alias = require('@rollup/plugin-alias');
 const json = require('rollup-plugin-json');
 
-import {
-  removeAssertTransformer,
-  resolveNodeExterns,
-  generateAliasConfig
-} from '../rollup.shared';
+const util = require('../rollup.shared');
 
 const argv = yargs.options({
   input: {
@@ -52,18 +48,18 @@ async function buildBundle(input: string, output: string): Promise<void> {
   const bundle = await rollup({
     input,
     plugins: [
-      alias(generateAliasConfig('node')),
+      alias(util.generateAliasConfig('node')),
       typescriptPlugin({
         tsconfigOverride: {
           compilerOptions: {
             target: 'es2017'
           }
         },
-        transformers: removeAssertTransformer
+        transformers: util.removeAssertTransformer
       }),
       json({ preferConst: true })
     ],
-    external: resolveNodeExterns
+    external: util.resolveNodeExterns
   });
   await bundle.write({ file: output, format: 'es' });
 }