Fix build

Author: schmidt-sebastian

packages/firestore/exp/src/api/database.ts

@@ -32,7 +32,8 @@ import {
   MemoryOfflineComponentProvider,
   OfflineComponentProvider,
   IndexedDbOfflineComponentProvider,
-  MultiTabOfflineComponentProvider, MultiTabOnlineComponentProvider
+  MultiTabOfflineComponentProvider,
+  MultiTabOnlineComponentProvider
 } from '../../../src/core/component_provider';
 
 import {
@@ -61,7 +62,7 @@ export class Firestore extends LiteFirestore
   private readonly _queue = new AsyncQueue();
   private readonly _firestoreClient: FirestoreClient;
   private readonly _persistenceKey: string;
-  private _offlineComponentProvider : OfflineComponentProvider= new MemoryOfflineComponentProvider();
+  private _offlineComponentProvider: OfflineComponentProvider = new MemoryOfflineComponentProvider();
   private _onlineComponentProvider = new OnlineComponentProvider();
 
   // Assigned via _getFirestoreClient()

packages/firestore/index.node.memory.ts

@@ -21,7 +21,7 @@ import { FirebaseNamespace } from '@firebase/app-types';
 import { Firestore } from './src/api/database';
 import {
   MemoryOfflineComponentProvider,
-  MemoryOnlineComponentProvider
+  OnlineComponentProvider
 } from './src/core/component_provider';
 import { configureForFirebase } from './src/config';
 import './register-module';
@@ -40,7 +40,7 @@ export function registerFirestore(instance: FirebaseNamespace): void {
         app,
         auth,
         new MemoryOfflineComponentProvider(),
-        new MemoryOnlineComponentProvider()
+        new OnlineComponentProvider()
       )
   );
   instance.registerVersion(name, version, 'node');

packages/firestore/lite/src/api/reference.ts

@@ -526,7 +526,11 @@ export function parent<T>(
     if (parentPath.isEmpty()) {
       return null;
     } else {
-      return new DocumentReference(child.firestore,  /* converter= */ null, parentPath);
+      return new DocumentReference(
+        child.firestore,
+        /* converter= */ null,
+        parentPath
+      );
     }
   } else {
     const doc = cast<DocumentReference<T>>(child, DocumentReference);

packages/firestore/src/core/component_provider.ts

@@ -42,7 +42,7 @@ import { DatabaseId, DatabaseInfo } from './database_info';
 import { Datastore, newDatastore } from '../remote/datastore';
 import { User } from '../auth/user';
 import { PersistenceSettings } from './firestore_client';
-import {debugAssert, debugCast} from '../util/assert';
+import { debugAssert, debugCast } from '../util/assert';
 import { GarbageCollectionScheduler, Persistence } from '../local/persistence';
 import { Code, FirestoreError } from '../util/error';
 import { OnlineStateSource } from './types';
@@ -79,7 +79,7 @@ export interface ComponentConfiguration {
 }
 
 /**
- * Initializes and wires the offline-only components for Firestore. 
+ * Initializes and wires the offline-only components for Firestore.
  * Implementations override `initialize()` to provide all components.
  */
 export interface OfflineComponentProvider {
@@ -258,7 +258,7 @@ export class MultiTabOfflineComponentProvider extends IndexedDbOfflineComponentP
 }
 
 /**
- * Initializes and wires the components that are needed to interface with the 
+ * Initializes and wires the components that are needed to interface with the
  * network.
  */
 export class OnlineComponentProvider {
@@ -345,15 +345,27 @@ export class MultiTabOnlineComponentProvider extends OnlineComponentProvider {
     cfg: ComponentConfiguration
   ): Promise<void> {
     await super.initialize(offlineComponentProvider, cfg);
-    if (cfg.persistenceSettings.durable && cfg.persistenceSettings.synchronizeTabs) {
-      const sharedClientState = debugCast(offlineComponentProvider.sharedClientState, WebStorageSharedClientState);
-      const persistence = debugCast(offlineComponentProvider.persistence, IndexedDbPersistence);
+    if (
+      cfg.persistenceSettings.durable &&
+      cfg.persistenceSettings.synchronizeTabs
+    ) {
+      const sharedClientState = debugCast(
+        offlineComponentProvider.sharedClientState,
+        WebStorageSharedClientState
+      );
+      const persistence = debugCast(
+        offlineComponentProvider.persistence,
+        IndexedDbPersistence
+      );
       const syncEngine = this.syncEngine;
 
       sharedClientState.syncEngine = {
         applyBatchState: applyBatchState.bind(null, syncEngine),
         applyTargetState: applyTargetState.bind(null, syncEngine),
-        applyActiveTargetsChange: applyActiveTargetsChange.bind(null, syncEngine),
+        applyActiveTargetsChange: applyActiveTargetsChange.bind(
+          null,
+          syncEngine
+        ),
         getActiveClients: getActiveClients.bind(null, syncEngine)
       };
 
@@ -364,21 +376,18 @@ export class MultiTabOnlineComponentProvider extends OnlineComponentProvider {
 
       // NOTE: This will immediately call the listener, so we make sure to
       // set it after localStore / remoteStore are started.
-      await persistence.setPrimaryStateListener(
-        async isPrimary => {
-          await applyPrimaryState(syncEngine, isPrimary);
-          if (offlineComponentProvider.gcScheduler) {
-            if (isPrimary && !offlineComponentProvider.gcScheduler.started) {
-              offlineComponentProvider.gcScheduler.start(
-                offlineComponentProvider.localStore
-              );
-            } else if (!isPrimary) {
-              offlineComponentProvider.gcScheduler.stop();
-            }
+      await persistence.setPrimaryStateListener(async isPrimary => {
+        await applyPrimaryState(syncEngine, isPrimary);
+        if (offlineComponentProvider.gcScheduler) {
+          if (isPrimary && !offlineComponentProvider.gcScheduler.started) {
+            offlineComponentProvider.gcScheduler.start(
+              offlineComponentProvider.localStore
+            );
+          } else if (!isPrimary) {
+            offlineComponentProvider.gcScheduler.stop();
           }
         }
-      );
+      });
     }
   }
 }
-

packages/firestore/test/unit/specs/spec_test_components.ts

@@ -19,7 +19,8 @@ import {
   ComponentConfiguration,
   MemoryOfflineComponentProvider,
   OnlineComponentProvider,
-  MultiTabOfflineComponentProvider, MultiTabOnlineComponentProvider
+  MultiTabOfflineComponentProvider,
+  MultiTabOnlineComponentProvider
 } from '../../../src/core/component_provider';
 import {
   GarbageCollectionScheduler,
@@ -154,7 +155,6 @@ export class MockMultiTabOnlineComponentProvider extends MultiTabOnlineComponent
   }
 }
 
-
 export class MockMultiTabOfflineComponentProvider extends MultiTabOfflineComponentProvider {
   persistence!: MockIndexedDbPersistence;
 

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -127,7 +127,8 @@ import {
   SharedWriteTracker,
   MockMultiTabOfflineComponentProvider,
   MockMemoryOfflineComponentProvider,
-  MockOnlineComponentProvider, MockMultiTabOnlineComponentProvider
+  MockOnlineComponentProvider,
+  MockMultiTabOnlineComponentProvider
 } from './spec_test_components';
 import { IndexedDbPersistence } from '../../../src/local/indexeddb_persistence';
 import { encodeBase64 } from '../../../src/platform/base64';
@@ -295,7 +296,7 @@ abstract class TestRunner {
   protected abstract initializeOnlineComponentProvider(
     offlineComponentProvider: OfflineComponentProvider,
     configuration: ComponentConfiguration
-  ): Promise<MockMultiTabOnlineComponentProvider| MockOnlineComponentProvider>;
+  ): Promise<MockMultiTabOnlineComponentProvider | MockOnlineComponentProvider>;
 
   get isPrimaryClient(): boolean {
     return this.syncEngine.isPrimaryClient;

packages/firestore/test/util/api_helpers.ts

@@ -30,7 +30,7 @@ import {
   MultiTabOfflineComponentProvider,
   OnlineComponentProvider
 } from '../../src/core/component_provider';
-import {newQueryForPath, Query as InternalQuery} from '../../src/core/query';
+import { newQueryForPath, Query as InternalQuery } from '../../src/core/query';
 import {
   ChangeType,
   DocumentViewChange,