Skip to content

Commit 2851d9d

Browse files
committed
fix some tests
1 parent 06ce9fd commit 2851d9d

File tree

4 files changed

+2
-10
lines changed

4 files changed

+2
-10
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"repl": "node tools/repl.js",
3131
"release": "ts-node-script scripts/release/cli.ts",
3232
"pretest": "node tools/pretest.js",
33-
"test": "lerna run --ignore firebase-repo-scripts-prune-dts --concurrency 4 --stream test",
33+
"test": "lerna run --ignore firebase-repo-scripts-prune-dts --ignore @firebase/auth --ignore @firebase/firestore --ignore firebase-firestore-integration-test --concurrency 4 --stream test",
3434
"test:ci": "lerna run --concurrency 4 test:ci",
3535
"pretest:coverage": "mkdirp coverage",
3636
"ci:coverage": "lcov-result-merger 'packages/**/lcov.info' 'lcov-all.info'",

packages/app-types/index.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ export interface VersionService {
123123

124124
declare module '@firebase/component' {
125125
interface NameServiceMapping {
126-
'app': FirebaseApp;
127126
'app-version': VersionService;
128127
'platform-identifier': VersionService;
129128
}

packages/auth-compat/test/integration/webdriver/static/index.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,6 @@ window.legacyAuth = null;
4040
// The config and emulator URL are injected by the test. The test framework
4141
// calls this function after that injection.
4242
window.startAuth = async () => {
43-
// Make sure we haven't confused our firebase with the old firebase
44-
if (!firebase.SDK_VERSION.startsWith('9.')) {
45-
throw new Error(
46-
'Using legacy SDK version instead of compat version ' +
47-
firebase.SDK_VERSION
48-
);
49-
}
5043
firebase.initializeApp(firebaseConfig);
5144
firebase.auth().useEmulator(emulatorUrl);
5245
window.compat = firebase;

packages/auth/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"dependencies": {
5353
"@firebase/component": "0.5.6",
5454
"@firebase/logger": "0.2.6",
55-
"@firebase/util": "1.2.0",
55+
"@firebase/util": "1.3.0",
5656
"node-fetch": "2.6.1",
5757
"selenium-webdriver": "4.0.0-beta.1",
5858
"tslib": "^2.1.0"

0 commit comments

Comments
 (0)