Update app-compat

Author: hsubox76

packages-exp/app-compat/src/firebaseApp.ts

@@ -68,7 +68,7 @@ export class FirebaseAppImpl implements FirebaseApp {
   }
 
   delete(): Promise<void> {
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       this.app.checkDestroyed();
       resolve();
     }).then(() => {

packages-exp/app-exp/package.json

@@ -41,7 +41,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.1.3"
   },
   "repository": {
     "directory": "packages-exp/app-exp",

packages-exp/app-exp/src/api.ts

@@ -285,7 +285,8 @@ export function onLog(
 ): void {
   if (logCallback !== null && typeof logCallback !== 'function') {
     throw ERROR_FACTORY.create(AppError.INVALID_LOG_ARGUMENT, {
-      appName: name
+      // appName isn't used in INVALID_LOG_ARGUMENT error but ErrorFactory requires it
+      appName: ''
     });
   }
   setUserLogHandler(logCallback, options);

packages/app/package.json

@@ -39,7 +39,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.1.3"
   },
   "repository": {
     "directory": "packages/app",

packages/app/src/firebaseApp.ts

@@ -86,7 +86,7 @@ export class FirebaseAppImpl implements FirebaseApp {
   }
 
   delete(): Promise<void> {
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       this.checkDestroyed_();
       resolve();
     })

packages/app/src/firebaseNamespaceCore.ts

@@ -288,7 +288,8 @@ export function createFirebaseNamespaceCore(
   function onLog(logCallback: LogCallback | null, options?: LogOptions): void {
     if (logCallback !== null && typeof logCallback !== 'function') {
       throw ERROR_FACTORY.create(AppError.INVALID_LOG_ARGUMENT, {
-        appName: name
+        // appName isn't used in INVALID_LOG_ARGUMENT error but ErrorFactory requires it
+        appName: ''
       });
     }
     setUserLogHandler(logCallback, options);

packages/app/src/lite/firebaseAppLite.ts

@@ -90,7 +90,7 @@ export class FirebaseAppLiteImpl implements FirebaseApp {
   }
 
   delete(): Promise<void> {
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       this.checkDestroyed_();
       resolve();
     })

packages/app/src/lite/firebaseNamespaceLite.ts

@@ -48,7 +48,9 @@ export function createFirebaseNamespaceLite(): FirebaseNamespace {
       component.name !== 'performance' &&
       component.name !== 'installations'
     ) {
-      throw Error(`${name} cannot register with the standalone perf instance`);
+      throw Error(
+        `${component.name} cannot register with the standalone perf instance`
+      );
     }
 
     return registerComponent(component);