Remove flush from tests due to globals conflict.

Author: bryanatkinson

packages/performance/src/services/oob_resources_service.test.ts

@@ -43,6 +43,7 @@ import {
   LCPMetricWithAttribution
 } from 'web-vitals/attribution';
 
+// eslint-disable-next-line no-restricted-properties
 describe('Firebase Performance > oob_resources_service', () => {
   const MOCK_ID = 'idasdfsffe';
 

packages/performance/src/services/perf_logger.test.ts

@@ -32,6 +32,7 @@ import { mergeStrings } from '../utils/string_merger';
 import { FirebaseInstallations } from '@firebase/installations-types';
 import { PerformanceController } from '../controllers/perf';
 
+// eslint-disable-next-line no-restricted-properties
 describe('Performance Monitoring > perf_logger', () => {
   const IID = 'idasdfsffe';
   const PAGE_URL = 'http://mock-page.com';
@@ -54,7 +55,6 @@ describe('Performance Monitoring > perf_logger', () => {
     Array<{ message: string; eventTime: number }>,
     void
   >;
-  const flushQueuedEventsStub = stub(transportService, 'flushQueuedEvents');
   let getIidStub: SinonStub<[], string | undefined>;
   let clock: SinonFakeTimers;
 
@@ -142,8 +142,6 @@ describe('Performance Monitoring > perf_logger', () => {
       expect(addToQueueStub.getCall(0).args[0].message).to.be.equal(
         EXPECTED_TRACE_MESSAGE
       );
-      // Only page load traces should be immediately flushed
-      expect(flushQueuedEventsStub).not.to.be.called;
     });
 
     it('does not log an event if cookies are disabled in the browser', () => {
@@ -185,8 +183,6 @@ describe('Performance Monitoring > perf_logger', () => {
       expect(addToQueueStub.getCall(0).args[0].message).to.be.equal(
         EXPECTED_TRACE_MESSAGE
       );
-      // Only page load traces should be immediately flushed
-      expect(flushQueuedEventsStub).not.to.be.called;
     });
 
     it('ascertains that the max number of custom attributes allowed is 5', () => {
@@ -212,8 +208,6 @@ describe('Performance Monitoring > perf_logger', () => {
       expect(addToQueueStub.getCall(0).args[0].message).to.be.equal(
         EXPECTED_TRACE_MESSAGE
       );
-      // Only page load traces should be immediately flushed
-      expect(flushQueuedEventsStub).not.to.be.called;
     });
   });
 
@@ -297,7 +291,6 @@ describe('Performance Monitoring > perf_logger', () => {
       expect(addToQueueStub.getCall(0).args[0].message).to.be.equal(
         EXPECTED_TRACE_MESSAGE
       );
-      expect(flushQueuedEventsStub).to.be.called;
     });
   });
 

packages/performance/src/services/transport_service.test.ts

@@ -27,8 +27,7 @@ import { SettingsService } from './settings_service';
 
 use(sinonChai);
 
-// eslint-disable-next-line no-restricted-properties
-describe.only('Firebase Performance > transport_service', () => {
+describe('Firebase Performance > transport_service', () => {
   const sendBeaconSpy = spy(navigator, 'sendBeacon');
   const INITIAL_SEND_TIME_DELAY_MS = 5.5 * 1000;
   const DEFAULT_SEND_INTERVAL_MS = 10 * 1000;