Merge branch 'master' into wuandy/Bundles

Author: wu-hui

.changeset/config.json

@@ -3,7 +3,7 @@
   "changelog": ["@changesets/changelog-github", { "repo": "firebase/firebase-js-sdk"}],
   "commit": false,
   "linked": [],
-  "access": "restricted",
+  "access": "public",
   "baseBranch": "master",
   "updateInternalDependencies": "patch",
   "ignore": [

.changeset/cuddly-rivers-add.md

@@ -0,0 +1,7 @@
+---
+"firebase": patch
+"@firebase/storage-types": patch
+"@firebase/storage": patch
+---
+
+[fix] Updated the TypeScript types for all APIs using Observers to allow callback omission. 

.changeset/cyan-books-melt.md

@@ -0,0 +1,6 @@
+---
+"firebase": patch
+"@firebase/firestore": patch
+---
+
+The SDK no longer crashes if an IndexedDB failure occurs when unsubscribing from a Query.

.changeset/firebsae-messaging.md

@@ -0,0 +1,8 @@
+---
+"firebase": patch
+"@firebase/firestore": patch
+---
+
+[fixed] Removed a delay that may have prevented Firestore from immediately
+reestablishing a network connection if a connectivity change occurred while
+the app was in the background.

.changeset/breezy-queens-give.md renamed to .changeset/friendly-crews-dream.md

@@ -1,3 +1,2 @@
 ---
-
 ---

.changeset/poor-eggs-bow.md renamed to .changeset/gorgeous-beers-build.md

@@ -85,4 +85,4 @@ packages/firebase/index.d.ts @egilmorez @firebase/jssdk-global-approvers
 scripts/docgen/content-sources/ @egilmorez @firebase/jssdk-global-approvers
 
 # Changeset
-.changeset @egilmorez @erikeldridge @alikn @zijianjoy @andirayo @avolkovi @samhorlbeck @scottcrossen @yuchenshi @zwu52 @firebase/firestore-js-team @firebase/jssdk-global-approvers
+.changeset @firebase/jssdk-changeset-approvers @firebase/firestore-js-team @firebase/jssdk-global-approvers

.changeset/kind-melons-obey.md

@@ -27,4 +27,4 @@ jobs:
       - name: Create Release Pull Request
         uses: changesets/action@master
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_TOKEN: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}

.changeset/tall-pots-brush.md renamed to .changeset/late-ladybugs-wash.md

@@ -1,5 +1,7 @@
 {
   singleQuote: true,
   printWidth: 80,
-  quoteProps: preserve
-}
+  quoteProps: preserve,
+  trailingComma: none,
+  arrowParens: avoid
+}

.changeset/many-gifts-invent.md

@@ -3,11 +3,11 @@
   "description": "Cloud Functions for Firebase",
   "dependencies": {
     "cors": "2.8.5",
-    "firebase-admin": "8.11.0",
-    "firebase-functions": "3.6.1"
+    "firebase-admin": "8.13.0",
+    "firebase-functions": "3.7.0"
   },
   "private": true,
   "engines": {
-    "node": "8"
+    "node": "10"
   }
 }

.changeset/ten-plants-sort.md renamed to .changeset/nice-deers-suffer.md

@@ -67,7 +67,7 @@ const config = {
   // test results reporter to use
   // possible values: 'dots', 'progress'
   // available reporters: https://npmjs.org/browse/keyword/karma-reporter
-  reporters: ['spec', 'coverage-istanbul' /*, 'saucelabs' */],
+  reporters: ['mocha', 'coverage-istanbul' /*, 'saucelabs' */],
 
   // web server port
   port: 8089,
@@ -124,13 +124,13 @@ const config = {
 if (false /* process.env.TRAVIS */) {
   config.browsers = [...config.browsers, ...Object.keys(sauceLabsBrowsers)];
 }
-
+config.mochaReporter = {
+  showDiff: true
+};
 // Make it easy to spot failed tests in CI
 if (process.env.CI) {
-  config.specReporter = {
-    suppressErrorSummary: true,
-    suppressPassed: true, // do not print information about passed tests
-    suppressSkipped: true
+  config.mochaReporter = {
+    output: 'minimal'
   };
 }
 

.changeset/popular-beds-yell.md

@@ -46,11 +46,22 @@ const browserMap = {
  * Any special options per package.
  */
 const packageConfigs = {
-  messaging: {
+  '@firebase/messaging': {
     // Messaging currently only supports these browsers.
     browsers: ['Chrome_Windows', 'Firefox_Windows', 'Edge_Windows']
   },
-  firestore: {
+  // Firestore unit tests have OOM problems compiling with Babel for IE.
+  // Firestore integration/firestore tests do run on all browsers.
+  '@firebase/firestore': {
+    browsers: [
+      'Chrome_Windows',
+      'Firefox_Windows',
+      'Edge_Windows',
+      'Safari_macOS'
+    ]
+  },
+  // Installations has IE errors related to `idb` library that need to be figured out.
+  '@firebase/installations': {
     browsers: [
       'Chrome_Windows',
       'Firefox_Windows',
@@ -84,12 +95,12 @@ function getSauceLabsBrowsers(packageName) {
  */
 function getPackageLabels() {
   const match = testConfigFile.match(
-    /([a-zA-Z]+)\/([a-zA-Z-]+)\/karma\.conf\.js/
+    /([a-zA-Z]+\/[a-zA-Z-]+)\/karma\.conf\.js/
   );
-  return {
-    type: match[1],
-    name: match[2]
-  };
+  const packagePath = match[1];
+  const root = path.resolve(__dirname, '..');
+  const pkg = require(path.join(root, packagePath, 'package.json'));
+  return pkg.name;
 }
 
 /**
@@ -106,11 +117,8 @@ function getTestFiles() {
 }
 
 function seleniumLauncher(browserName, platform, version) {
-  const { name, type } = getPackageLabels();
-  const testName =
-    type === 'integration'
-      ? `${type}-${name}-${browserName}`
-      : `${name}-${browserName}`;
+  const { name } = getPackageLabels();
+  const testName = `${name}-${browserName}`;
   return {
     base: 'SauceLabs',
     browserName: browserName,
@@ -145,13 +153,13 @@ function appiumLauncher(
   };
 }
 
-module.exports = function(config) {
+module.exports = function (config) {
   const { packageName, files: testFiles } = getTestFiles();
   const sauceLabsBrowsers = getSauceLabsBrowsers(packageName);
 
   const sauceLabsConfig = {
-    tunnelIdentifier: process.env.TRAVIS_JOB_NUMBER + '-' + packageName,
-    build: process.env.TRAVIS_BUILD_NUMBER || argv['buildNumber'],
+    tunnelIdentifier: process.env.GITHUB_RUN_ID + '-' + packageName,
+    build: process.env.GITHUB_RUN_ID || argv['buildNumber'],
     username: process.env.SAUCE_USERNAME,
     accessKey: process.env.SAUCE_ACCESS_KEY,
     startConnect: true,
@@ -210,7 +218,7 @@ module.exports = function(config) {
       maxLogLines: 5,
       suppressErrorSummary: false,
       suppressFailed: false,
-      suppressPassed: false,
+      suppressPassed: true,
       suppressSkipped: true,
       showSpecTiming: true,
       failFast: false

.changeset/popular-beds-yell2.md

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google Inc.
+ * Copyright 2017 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@ const karmaBase = require('../../config/karma.base');
 
 const files = [`dist/**/*`];
 
-module.exports = function(config) {
+module.exports = function (config) {
   const karmaConfig = Object.assign({}, karmaBase, {
     // files to load into karma
     files: files,

.changeset/popular-cups-melt.md

@@ -8,19 +8,19 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.15.5",
-    "@babel/core": "7.9.6",
-    "@babel/preset-env": "7.9.6",
+    "firebase": "7.16.0",
+    "@babel/core": "7.10.4",
+    "@babel/preset-env": "7.10.4",
     "browserify": "16.5.1",
     "chai": "4.2.0",
-    "karma": "4.4.1",
+    "karma": "5.1.0",
     "karma-babel-preprocessor": "8.0.1",
     "karma-chrome-launcher": "3.1.0",
     "karma-firefox-launcher": "1.3.0",
-    "karma-mocha": "1.3.0",
+    "karma-mocha": "2.0.1",
     "karma-sauce-launcher": "1.2.0",
     "karma-spec-reporter": "0.0.32",
     "mkdirp": "1.0.4",
-    "mocha": "7.1.2"
+    "mocha": "7.2.0"
   }
 }

.changeset/quiet-coats-type.md

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google Inc.
+ * Copyright 2017 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -29,6 +29,6 @@ firebase.initializeApp({
   appId: 'myAppId'
 });
 
-describe('Firebase Namespace Validation', function() {
+describe('Firebase Namespace Validation', function () {
   validateNamespace(namespaceDefinition, firebase);
 });

.changeset/tricky-rocks-dream.md renamed to .changeset/rotten-owls-drive.md

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.15.5",
-    "typescript": "3.8.3"
+    "firebase": "7.16.0",
+    "typescript": "3.9.6"
   }
 }

.changeset/small-ghosts-visit.md

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google Inc.
+ * Copyright 2017 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -19,13 +19,9 @@ const karma = require('karma');
 const path = require('path');
 const karmaBase = require('../../config/karma.base');
 
-const files = [
-  `${path.dirname(require.resolve('firebase'))}/firebase.js`,
-  `${path.dirname(require.resolve('firebase'))}/firebase-firestore.js`,
-  './dist/test-harness.js'
-];
+const files = ['./dist/test-harness.js'];
 
-module.exports = function(config) {
+module.exports = function (config) {
   const karmaConfig = Object.assign({}, karmaBase, {
     // files to load into karma
     files: files,

.changeset/smart-cars-doubt.md

@@ -16,16 +16,16 @@
   "devDependencies": {
     "@types/mocha": "7.0.2",
     "gulp": "4.0.2",
-    "gulp-filter": "5.1.0",
+    "gulp-filter": "6.0.0",
     "gulp-replace": "1.0.0",
-    "karma": "4.4.1",
+    "karma": "5.1.0",
     "karma-chrome-launcher": "3.1.0",
     "karma-firefox-launcher": "1.3.0",
-    "karma-mocha": "1.3.0",
+    "karma-mocha": "2.0.1",
     "karma-spec-reporter": "0.0.32",
-    "mocha": "7.1.2",
+    "mocha": "7.2.0",
     "ts-loader": "6.2.2",
-    "typescript": "3.8.3",
+    "typescript": "3.9.6",
     "webpack": "4.43.0",
     "webpack-stream": "5.2.1"
   }