Skip to content

Commit 2c756f4

Browse files
committed
Merge branch 'master' into fei-revert-fetch
2 parents fbd9a4e + 1f3bdec commit 2c756f4

File tree

4 files changed

+1
-9
lines changed

4 files changed

+1
-9
lines changed

packages-exp/app-check-exp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"dependencies": {
3333
"@firebase/logger": "0.2.6",
3434
"@firebase/util": "1.1.0",
35-
"@firebase/component": "0.5.2",
35+
"@firebase/component": "0.5.3",
3636
"tslib": "^2.1.0"
3737
},
3838
"license": "Apache-2.0",

packages-exp/app-exp/src/constants.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import { name as appName } from '../package.json';
1919
import { name as appCompatName } from '../../app-compat/package.json';
20-
import { name as appCheckName } from '../../../packages-exp/app-check-exp/package.json';
2120
import { name as analyticsCompatName } from '../../../packages-exp/analytics-compat/package.json';
2221
import { name as analyticsName } from '../../../packages-exp/analytics-exp/package.json';
2322
import { name as authName } from '../../../packages-exp/auth-exp/package.json';
@@ -50,7 +49,6 @@ export const DEFAULT_ENTRY_NAME = '[DEFAULT]';
5049
export const PLATFORM_LOG_STRING = {
5150
[appName]: 'fire-core',
5251
[appCompatName]: 'fire-core-compat',
53-
[appCheckName]: 'fire-app-check',
5452
[analyticsName]: 'fire-analytics',
5553
[analyticsCompatName]: 'fire-analytics-compat',
5654
[authName]: 'fire-auth',

packages/firestore/test/integration/api/batch_writes.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,6 @@ apiDescribe('Database batch writes', (persistence: boolean) => {
231231
},
232232
err => {
233233
expect(err.message).to.exist;
234-
// TODO: Change this to just match "no document to update" once
235-
// the backend response is consistent.
236-
expect(err.message).to.match(/no (document|entity) to update/i);
237234
expect(err.code).to.equal('not-found');
238235
unsubscribe();
239236
}

packages/firestore/test/integration/api/database.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -470,9 +470,6 @@ apiDescribe('Database', (persistence: boolean) => {
470470
() => Promise.reject('update should have failed.'),
471471
err => {
472472
expect(err.message).to.exist;
473-
// TODO: Change this to just match "no document to update" once the
474-
// backend response is consistent.
475-
expect(err.message).to.match(/no (document|entity) to update/i);
476473
expect(err.code).to.equal('not-found');
477474
}
478475
)

0 commit comments

Comments
 (0)