Catch transaction.done errors

Author: hsubox76

.changeset/few-drinks-kiss.md

@@ -0,0 +1,5 @@
+---
+'@firebase/app': patch
+---
+
+Catch `transaction.done` errors in `readHeartbeatsFromIndexedDB` and log them as a warning, because platform logging errors should never throw or block user app functionality.

packages/app/src/indexeddb.ts

@@ -69,10 +69,13 @@ export async function readHeartbeatsFromIndexedDB(
 ): Promise<HeartbeatsInIndexedDB | undefined> {
   try {
     const db = await getDbPromise();
-    const result = await db
-      .transaction(STORE_NAME)
+    const tx = db.transaction(STORE_NAME);
+    const result = await tx
       .objectStore(STORE_NAME)
       .get(computeKey(app));
+    // We already have the value but tx.done can throw,
+    // so we need to await it here to catch errors
+    await tx.done;
     return result;
   } catch (e) {
     if (e instanceof FirebaseError) {