Skip to content

Commit 2e0849a

Browse files
committed
fix typings
1 parent d3c9c86 commit 2e0849a

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

packages/app/src/firebaseApp.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export class FirebaseAppImpl implements FirebaseApp {
148148
/**
149149
* @param component the component being added to this app's container
150150
*/
151-
_addComponent(component: Component): void {
151+
_addComponent<T extends Name>(component: Component<T>): void {
152152
try {
153153
this.container.addComponent(component);
154154
} catch (e) {

packages/app/src/platformLoggerService.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export class PlatformLoggerService {
3333
return providers
3434
.map(provider => {
3535
if (isVersionServiceProvider(provider)) {
36-
const service = provider.getImmediate();
36+
const service = (provider as Provider<'app-version'>).getImmediate();
3737
return `${service.library}/${service.version}`;
3838
} else {
3939
return null;
@@ -51,9 +51,7 @@ export class PlatformLoggerService {
5151
* provides VersionService. The provider is not necessarily a 'app-version'
5252
* provider.
5353
*/
54-
function isVersionServiceProvider(
55-
provider: Provider<Name>
56-
): provider is Provider<'app-version'> {
54+
function isVersionServiceProvider(provider: Provider<Name>): boolean {
5755
const component = provider.getComponent();
5856
return component?.type === ComponentType.VERSION;
5957
}

0 commit comments

Comments
 (0)