Review

Author: schmidt-sebastian

packages/firestore/test/unit/local/counting_query_engine.ts

@@ -25,6 +25,10 @@ import { RemoteDocumentCache } from '../../../src/local/remote_document_cache';
 import { MutationQueue } from '../../../src/local/mutation_queue';
 import { DocumentKeySet, DocumentMap } from '../../../src/model/collections';
 
+export enum QueryEngineType {
+  IndexFree, Simple
+}
+
 /**
  * A test-only query engine that forwards all API calls and exposes the number
  * of documents and mutations read.
@@ -59,7 +63,7 @@ export class CountingQueryEngine implements QueryEngine {
 
   constructor(
     private readonly queryEngine: QueryEngine,
-    readonly type: 'index-free' | 'simple'
+    readonly type: QueryEngineType
   ) {}
 
   resetCounts(): void {

packages/firestore/test/unit/local/indexeddb_persistence.test.ts

@@ -125,7 +125,7 @@ async function withCustomPersistence(
     new SharedFakeWebStorage()
   );
   const persistence = new IndexedDbPersistence(
-    /* allowTabSynchronization= */ multiClient,
+    multiClient,
     TEST_PERSISTENCE_PREFIX,
     clientId,
     platform,

packages/firestore/test/unit/local/local_store.test.ts

@@ -80,7 +80,7 @@ import {
   byteStringFromString
 } from '../../util/helpers';
 
-import { CountingQueryEngine } from './counting_query_engine';
+import {CountingQueryEngine, QueryEngineType} from './counting_query_engine';
 import * as persistenceHelpers from './persistence_test_helpers';
 import { ByteString } from '../../../src/util/byte_string';
 
@@ -398,7 +398,7 @@ describe('LocalStore w/ Memory Persistence (SimpleQueryEngine)', () => {
   async function initialize(): Promise<LocalStoreComponents> {
     const queryEngine = new CountingQueryEngine(
       new SimpleQueryEngine(),
-      'simple'
+      QueryEngineType.Simple
     );
     const persistence = await persistenceHelpers.testMemoryEagerPersistence();
     const localStore = new LocalStore(
@@ -416,7 +416,7 @@ describe('LocalStore w/ Memory Persistence (IndexFreeQueryEngine)', () => {
   async function initialize(): Promise<LocalStoreComponents> {
     const queryEngine = new CountingQueryEngine(
       new IndexFreeQueryEngine(),
-      'index-free'
+      QueryEngineType.IndexFree
     );
     const persistence = await persistenceHelpers.testMemoryEagerPersistence();
     const localStore = new LocalStore(
@@ -469,7 +469,7 @@ describe('LocalStore w/ IndexedDB Persistence (IndexFreeQueryEngine)', () => {
   async function initialize(): Promise<LocalStoreComponents> {
     const queryEngine = new CountingQueryEngine(
       new IndexFreeQueryEngine(),
-      'index-free'
+      QueryEngineType.IndexFree
     );
     const persistence = await persistenceHelpers.testIndexedDbPersistence();
     const localStore = new MultiTabLocalStore(