Skip to content

Commit 317d1a9

Browse files
committed
Remove functions changes
1 parent 5093ab6 commit 317d1a9

File tree

3 files changed

+3
-41
lines changed

3 files changed

+3
-41
lines changed

packages-exp/functions-exp/src/config.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@ import {
2424
InstanceFactory
2525
} from '@firebase/component';
2626
import { FUNCTIONS_TYPE } from './constants';
27-
import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
2827

29-
const APP_CHECK_INTERNAL_NAME: AppCheckInternalComponentName =
30-
'app-check-internal';
3128
export function registerFunctions(fetchImpl: typeof fetch): void {
3229
const factory: InstanceFactory<'functions-exp'> = (
3330
container: ComponentContainer,
@@ -37,14 +34,12 @@ export function registerFunctions(fetchImpl: typeof fetch): void {
3734
const app = container.getProvider('app-exp').getImmediate();
3835
const authProvider = container.getProvider('auth-internal');
3936
const messagingProvider = container.getProvider('messaging');
40-
const appCheckProvider = container.getProvider(APP_CHECK_INTERNAL_NAME);
4137

4238
// eslint-disable-next-line @typescript-eslint/no-explicit-any
4339
return new FunctionsService(
4440
app,
4541
authProvider,
4642
messagingProvider,
47-
appCheckProvider,
4843
regionOrCustomDomain,
4944
fetchImpl
5045
);

packages-exp/functions-exp/src/context.ts

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ import {
2323
FirebaseAuthInternalName
2424
} from '@firebase/auth-interop-types';
2525
import { Provider } from '@firebase/component';
26-
import {
27-
AppCheckInternalComponentName,
28-
FirebaseAppCheckInternal
29-
} from '@firebase/app-check-interop-types';
3026

3127
/**
3228
* The metadata that should be supplied with function calls.
@@ -35,7 +31,6 @@ import {
3531
export interface Context {
3632
authToken?: string;
3733
messagingToken?: string;
38-
appCheckToken: string | null;
3934
}
4035

4136
/**
@@ -45,11 +40,9 @@ export interface Context {
4540
export class ContextProvider {
4641
private auth: FirebaseAuthInternal | null = null;
4742
private messaging: FirebaseMessaging | null = null;
48-
private appCheck: FirebaseAppCheckInternal | null = null;
4943
constructor(
5044
authProvider: Provider<FirebaseAuthInternalName>,
51-
messagingProvider: Provider<FirebaseMessagingName>,
52-
appCheckProvider: Provider<AppCheckInternalComponentName>
45+
messagingProvider: Provider<FirebaseMessagingName>
5346
) {
5447
this.auth = authProvider.getImmediate({ optional: true });
5548
this.messaging = messagingProvider.getImmediate({
@@ -73,10 +66,6 @@ export class ContextProvider {
7366
}
7467
);
7568
}
76-
77-
if (!this.appCheck) {
78-
this.appCheck = appCheckProvider.getImmediate({ optional: true });
79-
}
8069
}
8170

8271
async getAuthToken(): Promise<string | undefined> {
@@ -113,22 +102,9 @@ export class ContextProvider {
113102
}
114103
}
115104

116-
async getAppCheckToken(): Promise<string | null> {
117-
if (this.appCheck) {
118-
const result = await this.appCheck.getToken();
119-
// If getToken() fails, it will still return a dummy token that also has
120-
// an error field containing the error message. We will send any token
121-
// provided here and show an error if/when it is rejected by the functions
122-
// endpoint.
123-
return result.token;
124-
}
125-
return null;
126-
}
127-
128105
async getContext(): Promise<Context> {
129106
const authToken = await this.getAuthToken();
130107
const messagingToken = await this.getMessagingToken();
131-
const appCheckToken = await this.getAppCheckToken();
132-
return { authToken, messagingToken, appCheckToken };
108+
return { authToken, messagingToken };
133109
}
134110
}

packages-exp/functions-exp/src/service.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { encode, decode } from './serializer';
2727
import { Provider } from '@firebase/component';
2828
import { FirebaseAuthInternalName } from '@firebase/auth-interop-types';
2929
import { FirebaseMessagingName } from '@firebase/messaging-types';
30-
import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
3130

3231
export const DEFAULT_REGION = 'us-central1';
3332

@@ -87,15 +86,10 @@ export class FunctionsService implements _FirebaseService {
8786
readonly app: FirebaseApp,
8887
authProvider: Provider<FirebaseAuthInternalName>,
8988
messagingProvider: Provider<FirebaseMessagingName>,
90-
appCheckProvider: Provider<AppCheckInternalComponentName>,
9189
regionOrCustomDomain: string = DEFAULT_REGION,
9290
readonly fetchImpl: typeof fetch
9391
) {
94-
this.contextProvider = new ContextProvider(
95-
authProvider,
96-
messagingProvider,
97-
appCheckProvider
98-
);
92+
this.contextProvider = new ContextProvider(authProvider, messagingProvider);
9993
// Cancels all ongoing requests when resolved.
10094
this.cancelAllRequests = new Promise(resolve => {
10195
this.deleteService = () => {
@@ -240,9 +234,6 @@ async function call(
240234
if (context.messagingToken) {
241235
headers['Firebase-Instance-ID-Token'] = context.messagingToken;
242236
}
243-
if (context.appCheckToken !== null) {
244-
headers['X-Firebase-AppCheck'] = context.appCheckToken;
245-
}
246237

247238
// Default timeout to 70s, but let the options override it.
248239
const timeout = options.timeout || 70000;

0 commit comments

Comments
 (0)