Address comments.

Author: visumickey

packages/performance/src/services/remote_config_service.test.ts

@@ -236,5 +236,39 @@ describe('Performance Monitoring > remote_config_service', () => {
 
       expect(SettingsService.getInstance().loggingEnabled).to.be.true;
     });
+
+    it('gets the config from RC even with deprecated transport flag', async () => {
+      // Expired local config.
+      const EXPIRY_LOCAL_STORAGE_VALUE = '1556524895320';
+      const STRINGIFIED_CUSTOM_CONFIG = `{"entries":{\
+        "fpr_vc_network_request_sampling_rate":"0.250000",\
+        "fpr_log_transport_web_percent":"100.0",\
+        "fpr_vc_session_sampling_rate":"0.250000","fpr_vc_trace_sampling_rate":"0.500000"},\
+        "state":"UPDATE"}`;
+
+      const { storageGetItemStub: getItemStub } = setup(
+        {
+          expiry: EXPIRY_LOCAL_STORAGE_VALUE,
+          config: STRINGIFIED_CUSTOM_CONFIG
+        },
+        { reject: false, value: new Response(STRINGIFIED_CONFIG) }
+      );
+
+      await getConfig(IID);
+
+      expect(getItemStub).to.be.calledOnce;
+      expect(SettingsService.getInstance().loggingEnabled).to.be.true;
+      expect(SettingsService.getInstance().logEndPointUrl).to.equal(LOG_URL);
+      expect(SettingsService.getInstance().transportKey).to.equal(
+        TRANSPORT_KEY
+      );
+      expect(SettingsService.getInstance().logSource).to.equal(LOG_SOURCE);
+      expect(
+        SettingsService.getInstance().networkRequestsSamplingRate
+      ).to.equal(NETWORK_SAMPLIG_RATE);
+      expect(SettingsService.getInstance().tracesSamplingRate).to.equal(
+        TRACE_SAMPLING_RATE
+      );
+    });
   });
 });

packages/performance/src/services/remote_config_service.ts

@@ -231,30 +231,3 @@ function configValid(expiry: string): boolean {
 function shouldLogAfterSampling(samplingRate: number): boolean {
   return Math.random() <= samplingRate;
 }
-
-/**
- * True if event should be sent to Fl transport endpoint rather than CC transport endpoint.
- * rolloutPercent is in range [0.0, 100.0].
- * @param iid Installation ID which identifies a web app installed on client.
- * @param rolloutPercent the possibility of this app sending events to Fl endpoint.
- * @return true if this installation should send events to Fl endpoint.
- */
-export function isDestFl(iid: string, rolloutPercent: number): boolean {
-  if (iid.length === 0) {
-    return false;
-  }
-  return getHashPercent(iid) < rolloutPercent;
-}
-/**
- * Generate integer value range in [0, 99]. Implementation from String.hashCode() in Java.
- * @param seed Same seed will generate consistent hash value using this algorithm.
- * @return Hash value in range [0, 99], generated from seed and hash algorithm.
- */
-function getHashPercent(seed: string): number {
-  let hash = 0;
-  for (let i = 0; i < seed.length; i++) {
-    hash = (hash << 3) + hash - seed.charCodeAt(i);
-  }
-  hash = Math.abs(hash % 100);
-  return hash;
-}