Skip to content

Commit 37729fb

Browse files
committed
move protobufjs to devdeps
1 parent 2b50685 commit 37729fb

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

packages/firestore/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
"@firebase/webchannel-wrapper": "0.2.21",
3434
"@grpc/proto-loader": "^0.5.0",
3535
"@firebase/util": "0.2.20",
36-
"protobufjs": "6.8.8",
3736
"grpc": "1.20.3",
3837
"tslib": "1.9.3"
3938
},
@@ -66,6 +65,7 @@
6665
"npm-run-all": "4.1.5",
6766
"nyc": "14.1.0",
6867
"prettier": "1.17.0",
68+
"protobufjs": "6.8.8",
6969
"rollup": "1.11.0",
7070
"rollup-plugin-copy-assets": "1.1.0",
7171
"rollup-plugin-node-resolve": "4.2.3",

packages/firestore/src/platform_node/load_protos.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import * as protoLoader from '@grpc/proto-loader';
1919
import * as grpc from 'grpc';
2020
import * as path from 'path';
21+
// eslint-disable-next-line import/no-extraneous-dependencies, only used in tests
2122
import * as ProtobufJS from 'protobufjs';
2223

2324
/** Used by tests so we can match @grpc/proto-loader behavior. */

0 commit comments

Comments
 (0)