j/k phone credential/provider are actually public

Author: avolkovi

packages-exp/auth-exp/src/core/credentials/phone.ts

@@ -34,7 +34,7 @@ export interface PhoneAuthCredentialParameters {
   temporaryProof?: string;
 }
 
-export class PhoneAuthCredential implements AuthCredential {
+export class PhoneAuthCredential implements AuthCredential, externs.PhoneAuthCredential {
   readonly providerId = externs.ProviderId.PHONE;
   readonly signInMethod = externs.SignInMethod.PHONE;
 

packages-exp/auth-exp/src/core/providers/phone.ts

@@ -24,7 +24,7 @@ import { PhoneAuthCredential } from '../credentials/phone';
 import { _verifyPhoneNumber } from '../strategies/phone';
 import { debugFail } from '../util/assert';
 
-export class PhoneAuthProvider implements externs.AuthProvider {
+export class PhoneAuthProvider implements externs.PhoneAuthProvider {
   static readonly PROVIDER_ID = externs.ProviderId.PHONE;
   static readonly PHONE_SIGN_IN_METHOD = externs.SignInMethod.PHONE;
 
@@ -50,21 +50,21 @@ export class PhoneAuthProvider implements externs.AuthProvider {
     return new PhoneAuthCredential({ verificationId, verificationCode });
   }
 
-  static credentialFromResult(
+  static _credentialFromResult(
     userCredential: externs.UserCredential
   ): externs.AuthCredential | null {
     void userCredential;
     return debugFail('not implemented');
   }
 
-  static credentialFromError(
+  static _credentialFromError(
     error: FirebaseError
   ): externs.AuthCredential | null {
     void error;
     return debugFail('not implemented');
   }
 
-  static credentialFromJSON(json: string | object): externs.AuthCredential {
+  static _credentialFromJSON(json: string | object): externs.AuthCredential {
     void json;
     return debugFail('not implemented');
   }

packages-exp/auth-types-exp/index.d.ts

@@ -192,13 +192,17 @@ export abstract class AuthCredential {
 }
 
 export abstract class OAuthCredential extends AuthCredential {
-  static fromJSON ( json :  object | string ) : OAuthCredential | null;
-
+  static fromJSON(json: object | string): OAuthCredential | null;
+  
   readonly accessToken?: string;
   readonly idToken?: string;
   readonly secret?: string;
 }
 
+export abstract class PhoneAuthCredential extends AuthCredential {
+  static fromJSON ( json :  object | string ) : PhoneAuthCredential | null;
+}
+
 export const enum OperationType {
   LINK = 'link',
   REAUTHENTICATE = 'reauthenticate',
@@ -235,6 +239,28 @@ export interface AuthProvider {
   readonly providerId: ProviderId;
 }
 
+/** 
+ * A provider for generating phone credentials
+ */
+export class PhoneAuthProvider implements AuthProvider {
+ static readonly PROVIDER_ID: string;
+ static readonly PHONE_SIGN_IN_METHOD: string;
+ static credential(
+   verificationId: string,
+   verificationCode: string
+ ): AuthCredential;
+
+ constructor(auth?: Auth | null);
+
+ readonly providerId: ProviderId;
+
+ verifyPhoneNumber(
+   phoneNumber: string,
+   applicationVerifier: ApplicationVerifier,
+   /* multiFactorSession?: MultiFactorSession */
+ ): Promise<string>;
+}
+
 /**
  * A provider for generating email & password and email link credentials
  */