Skip to content

Commit 394ea1b

Browse files
author
Brian Chen
authored
Fix lint against master (#2095)
1 parent c8abbaa commit 394ea1b

File tree

4 files changed

+30
-19
lines changed

4 files changed

+30
-19
lines changed

packages/firestore/src/core/sync_engine.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -635,11 +635,7 @@ export class SyncEngine implements RemoteSyncer, SharedClientStateSyncer {
635635
private rejectOutstandingPendingWritesCallbacks(errorMessage: string): void {
636636
this.pendingWritesCallbacks.forEach(callbacks => {
637637
callbacks.forEach(callback => {
638-
callback.reject(
639-
new FirestoreError(
640-
Code.CANCELLED, errorMessage
641-
)
642-
);
638+
callback.reject(new FirestoreError(Code.CANCELLED, errorMessage));
643639
});
644640
});
645641

@@ -845,7 +841,7 @@ export class SyncEngine implements RemoteSyncer, SharedClientStateSyncer {
845841
if (userChanged) {
846842
// Fails tasks waiting for pending writes requested by previous user.
847843
this.rejectOutstandingPendingWritesCallbacks(
848-
"'waitForPendingWrites' promise is rejected due to a user change."
844+
"'waitForPendingWrites' promise is rejected due to a user change."
849845
);
850846

851847
const result = await this.localStore.handleUserChange(user);

packages/firestore/src/local/indexeddb_mutation_queue.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,10 @@ export class IndexedDbMutationQueue implements MutationQueue {
268268
getHighestUnacknowledgedBatchId(
269269
transaction: PersistenceTransaction
270270
): PersistencePromise<BatchId> {
271-
const range = IDBKeyRange.upperBound(
272-
[this.userId, Number.POSITIVE_INFINITY]
273-
);
271+
const range = IDBKeyRange.upperBound([
272+
this.userId,
273+
Number.POSITIVE_INFINITY
274+
]);
274275

275276
let batchId = BATCHID_UNKNOWN;
276277
return mutationsStore(transaction)

packages/firestore/src/util/async_queue.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,8 +328,8 @@ export class AsyncQueue {
328328
`Attempted to schedule an operation with a negative delay of ${delayMs}`
329329
);
330330

331-
// Fast-forward delays for timerIds that have been overriden.
332-
if (this.timerIdsToSkip.indexOf(timerId) > -1) {
331+
// Fast-forward delays for timerIds that have been overriden.
332+
if (this.timerIdsToSkip.indexOf(timerId) > -1) {
333333
delayMs = 0;
334334
}
335335

packages/firestore/test/integration/util/helpers.ts

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@
1818
import * as firestore from '@firebase/firestore-types';
1919
import { clearTestPersistence } from './../../unit/local/persistence_test_helpers';
2020
import firebase from './firebase_export';
21-
import { EmptyCredentialsProvider, CredentialChangeListener } from '../../../src/api/credentials';
21+
import {
22+
EmptyCredentialsProvider,
23+
CredentialChangeListener
24+
} from '../../../src/api/credentials';
2225
import { User } from '../../../src/auth/user';
2326

2427
/**
@@ -127,7 +130,6 @@ apiDescribe.skip = apiDescribeInternal.bind(null, describe.skip);
127130
apiDescribe.only = apiDescribeInternal.bind(null, describe.only);
128131

129132
export class MockCredentialsProvider extends EmptyCredentialsProvider {
130-
131133
private listener: CredentialChangeListener | null = null;
132134

133135
triggerUserChange(newUser: User): void {
@@ -181,16 +183,26 @@ export function withTestDb(
181183

182184
export function withMockCredentialProviderTestDb(
183185
persistence: boolean,
184-
fn: (db: firestore.FirebaseFirestore, mockCredential: MockCredentialsProvider) => Promise<void>
186+
fn: (
187+
db: firestore.FirebaseFirestore,
188+
mockCredential: MockCredentialsProvider
189+
) => Promise<void>
185190
): Promise<void> {
186191
const mockCredentialsProvider = new MockCredentialsProvider();
187192
// eslint-disable-next-line @typescript-eslint/no-explicit-any
188-
const settings = {... DEFAULT_SETTINGS,
189-
credentials: { client: mockCredentialsProvider, type: 'provider' }};
190-
return withTestDbsSettings(persistence, DEFAULT_PROJECT_ID, settings, 1,
193+
const settings = {
194+
...DEFAULT_SETTINGS,
195+
credentials: { client: mockCredentialsProvider, type: 'provider' }
196+
};
197+
return withTestDbsSettings(
198+
persistence,
199+
DEFAULT_PROJECT_ID,
200+
settings,
201+
1,
191202
([db]) => {
192203
return fn(db, mockCredentialsProvider);
193-
});
204+
}
205+
);
194206
}
195207

196208
/** Runs provided fn with a db for an alternate project id. */
@@ -351,7 +363,9 @@ export function shutdownDb(db: firestore.FirebaseFirestore): Promise<void> {
351363
return (db as any)._shutdown();
352364
}
353365

354-
export function waitForPendingWrites(db: firestore.FirebaseFirestore): Promise<void> {
366+
export function waitForPendingWrites(
367+
db: firestore.FirebaseFirestore
368+
): Promise<void> {
355369
// eslint-disable-next-line @typescript-eslint/no-explicit-any
356370
return (db as any)._waitForPendingWrites();
357371
}

0 commit comments

Comments
 (0)