Skip to content

Commit 3b1b051

Browse files
Merge 70e946e into c2b737b
2 parents c2b737b + 70e946e commit 3b1b051

28 files changed

+1606
-1681
lines changed

packages/firestore/test/unit/api/document_change.test.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import {
3232
documentSetAsArray,
3333
key,
3434
orderBy,
35-
path
35+
query
3636
} from '../../util/helpers';
3737
import { firestore } from '../../util/api_helpers';
3838

@@ -85,31 +85,31 @@ describe('DocumentChange:', () => {
8585
}
8686

8787
it('positions are correct for additions', () => {
88-
const query = Query.atPath(path('c'));
88+
const query1 = query('c');
8989
const initialDocs = [
9090
doc('c/a', 1, {}),
9191
doc('c/c', 1, {}),
9292
doc('c/e', 1, {})
9393
];
9494
const updates = [doc('c/b', 2, {}), doc('c/d', 2, {})];
9595

96-
expectPositions(query, initialDocs, updates);
96+
expectPositions(query1, initialDocs, updates);
9797
});
9898

9999
it('positions are correct for deletions', () => {
100-
const query = Query.atPath(path('c'));
100+
const query1 = query('c');
101101
const initialDocs = [
102102
doc('c/a', 1, {}),
103103
doc('c/b', 1, {}),
104104
doc('c/c', 1, {})
105105
];
106106
const updates = [key('c/a'), key('c/c')];
107107

108-
expectPositions(query, initialDocs, updates);
108+
expectPositions(query1, initialDocs, updates);
109109
});
110110

111111
it('positions are correct for modifications', () => {
112-
const query = Query.atPath(path('c'));
112+
const query1 = query('c');
113113
const initialDocs = [
114114
doc('c/a', 1, { value: 'a-1' }),
115115
doc('c/b', 1, { value: 'b-1' }),
@@ -120,11 +120,11 @@ describe('DocumentChange:', () => {
120120
doc('c/c', 2, { value: 'c-2' })
121121
];
122122

123-
expectPositions(query, initialDocs, updates);
123+
expectPositions(query1, initialDocs, updates);
124124
});
125125

126126
it('positions are correct for sort order changes', () => {
127-
const query = Query.atPath(path('c')).addOrderBy(orderBy('sort'));
127+
const query1 = query('c', orderBy('sort'));
128128
const initialDocs = [
129129
doc('c/a', 1, { sort: 10 }),
130130
doc('c/b', 1, { sort: 20 }),
@@ -138,11 +138,11 @@ describe('DocumentChange:', () => {
138138
doc('c/a', 2, { sort: 35 })
139139
];
140140

141-
expectPositions(query, initialDocs, updates);
141+
expectPositions(query1, initialDocs, updates);
142142
});
143143

144144
it('positions are correct for randomly chosen examples', () => {
145-
const query = Query.atPath(path('c')).addOrderBy(orderBy('sort'));
145+
const query1 = query('c', orderBy('sort'));
146146
for (let run = 0; run < 100; run++) {
147147
const initialDocs: Document[] = [];
148148
const updates: Array<DocumentKey | Document> = [];
@@ -165,7 +165,7 @@ describe('DocumentChange:', () => {
165165
}
166166
}
167167

168-
expectPositions(query, initialDocs, updates);
168+
expectPositions(query1, initialDocs, updates);
169169
}
170170
});
171171
});

0 commit comments

Comments
 (0)