import package.json for version directly (#1775)

* import package.json for version

* [AUTOMATED]: Prettier Code Styling

* use var in es5 build

Author: Feiyang1

packages/app/declarations.d.ts

@@ -52,6 +52,7 @@
     "rollup": "1.11.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.21.0",
+    "rollup-plugin-json": "4.0.0",
     "sinon": "7.3.2",
     "source-map-loader": "0.2.4",
     "ts-loader": "5.4.5",

packages/app/package.json

@@ -16,12 +16,10 @@
  */
 
 import typescriptPlugin from 'rollup-plugin-typescript2';
-import replace from 'rollup-plugin-replace';
+import json from 'rollup-plugin-json';
 import typescript from 'typescript';
 import pkg from './package.json';
 
-import firebasePkg from '../firebase/package.json';
-
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
 );
@@ -33,12 +31,7 @@ const es5BuildPlugins = [
   typescriptPlugin({
     typescript
   }),
-  replace({
-    delimiters: ['__', '__'],
-    values: {
-      JSCORE_VERSION: JSON.stringify(firebasePkg.version)
-    }
-  })
+  json()
 ];
 
 const es5Builds = [
@@ -98,11 +91,8 @@ const es2017BuildPlugins = [
       }
     }
   }),
-  replace({
-    delimiters: ['__', '__'],
-    values: {
-      JSCORE_VERSION: JSON.stringify(firebasePkg.version)
-    }
+  json({
+    preferConst: true
   })
 ];
 

packages/app/rollup.config.js

@@ -34,6 +34,7 @@ import { FirebaseAppImpl } from './firebaseApp';
 import { error, AppError } from './errors';
 import { FirebaseAppLiteImpl } from './lite/firebaseAppLite';
 import { DEFAULT_ENTRY_NAME } from './constants';
+import { version } from '../../firebase/package.json';
 
 function contains(obj: object, key: string) {
   return Object.prototype.hasOwnProperty.call(obj, key);
@@ -62,7 +63,7 @@ export function createFirebaseNamespaceCore(
     initializeApp: initializeApp,
     app: app as any,
     apps: null as any,
-    SDK_VERSION: __JSCORE_VERSION__,
+    SDK_VERSION: version,
     INTERNAL: {
       registerService,
       removeApp,

packages/app/src/firebaseNamespaceCore.ts

@@ -28,7 +28,7 @@ import { createFirebaseNamespaceCore } from '../firebaseNamespaceCore';
 export function createFirebaseNamespaceLite(): FirebaseNamespace {
   const namespace = createFirebaseNamespaceCore(FirebaseAppLiteImpl);
 
-  namespace.SDK_VERSION = `${__JSCORE_VERSION__}_LITE`;
+  namespace.SDK_VERSION = `${namespace.SDK_VERSION}_LITE`;
 
   const registerService = (namespace as _FirebaseNamespace).INTERNAL
     .registerService;

packages/app/src/lite/firebaseNamespaceLite.ts

@@ -15,8 +15,6 @@
  * limitations under the License.
  */
 
-import './setup';
-
 import { FirebaseApp, FirebaseNamespace } from '@firebase/app-types';
 import {
   _FirebaseApp,

packages/app/test/firebaseApp.test.ts

@@ -1,7 +1,8 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist"
+    "outDir": "dist",
+    "resolveJsonModule": true
   },
   "exclude": [
     "dist/**/*"

packages/app/test/setup.ts

@@ -11964,6 +11964,13 @@ [email protected]:
   dependencies:
     fs-extra "^5.0.0"
 
+[email protected]:
+  version "4.0.0"
+  resolved "https://registry.npmjs.org/rollup-plugin-json/-/rollup-plugin-json-4.0.0.tgz#a18da0a4b30bf5ca1ee76ddb1422afbb84ae2b9e"
+  integrity sha512-hgb8N7Cgfw5SZAkb3jf0QXii6QX/FOkiIq2M7BAQIEydjHvTyxXHQiIzZaTFgx1GK0cRCHOCBHIyEkkLdWKxow==
+  dependencies:
+    rollup-pluginutils "^2.5.0"
+
 [email protected]:
   version "0.8.1"
   resolved "https://registry.npmjs.org/rollup-plugin-license/-/rollup-plugin-license-0.8.1.tgz#cdcfee2a32f27790e5019a2a7abd9234476ac589"
@@ -12039,7 +12046,7 @@ [email protected], rollup-pluginutils@^2.0.1:
     estree-walker "^0.6.0"
     micromatch "^3.1.10"
 
-rollup-pluginutils@^2.6.0:
+rollup-pluginutils@^2.5.0, rollup-pluginutils@^2.6.0:
   version "2.6.0"
   resolved "https://registry.npmjs.org/rollup-pluginutils/-/rollup-pluginutils-2.6.0.tgz#203706edd43dfafeaebc355d7351119402fc83ad"
   integrity sha512-aGQwspEF8oPKvg37u3p7h0cYNwmJR1sCBMZGZ5b9qy8HGtETknqjzcxrDRrcAnJNXN18lBH4Q9vZYth/p4n8jQ==