Skip to content

Commit 3d2f0ec

Browse files
committed
WIP test compat typing
1 parent 045e4b5 commit 3d2f0ec

File tree

1 file changed

+16
-3
lines changed

1 file changed

+16
-3
lines changed

packages-exp/functions-compat/src/register.ts

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,14 @@ import {
2424
Component,
2525
ComponentType,
2626
InstanceFactory,
27-
ComponentContainer
27+
ComponentContainer,
28+
InstanceFactoryOptions
2829
} from '@firebase/component';
29-
import { Functions as FunctionsServiceExp } from '@firebase/functions-exp';
30+
import {
31+
Functions as FunctionsServiceExp,
32+
HttpsCallableOptions,
33+
HttpsCallable
34+
} from '@firebase/functions-exp';
3035

3136
declare module '@firebase/component' {
3237
interface NameServiceMapping {
@@ -36,9 +41,17 @@ declare module '@firebase/component' {
3641
}
3742
}
3843

44+
declare module '@firebase/functions-exp' {
45+
export function httpsCallable<RequestData = unknown, ResponseData = unknown>(
46+
functionsInstance: FunctionsService | FunctionsServiceExp,
47+
name: string,
48+
options?: HttpsCallableOptions
49+
): HttpsCallable<RequestData, ResponseData>;
50+
}
51+
3952
const factory: InstanceFactory<'functions-compat'> = (
4053
container: ComponentContainer,
41-
regionOrCustomDomain?: string
54+
{ instanceIdentifier: regionOrCustomDomain }: InstanceFactoryOptions
4255
) => {
4356
// Dependencies
4457
const app = container.getProvider('app-compat').getImmediate();

0 commit comments

Comments
 (0)