Skip to content

Commit 3db3e59

Browse files
WIP
1 parent 9fb9e1f commit 3db3e59

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

packages/firestore/rollup.shared.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ const browserDeps = Object.keys(
3131
const nodeDeps = [...browserDeps, 'util', 'path'];
3232

3333
/** Resolves the external dependencies for the browser build. */
34-
export function resolveBrowserExterns(id, importedFrom) {
34+
export function resolveBrowserExterns(id) {
3535
return browserDeps.some(dep => id === dep || id.startsWith(`${dep}/`));
3636
}
3737

3838
/** Resolves the external dependencies for the Node build. */
39-
export function resolveNodeExterns(id, importedFrom) {
39+
export function resolveNodeExterns(id) {
4040
return nodeDeps.some(dep => id === dep || id.startsWith(`${dep}/`));
4141
}
4242

packages/firestore/src/platform/format_json.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ import * as node from '../platform_node/node_format_json';
1919
import * as browser from '../platform_browser/browser_format_json';
2020
import { isNode } from '@firebase/util';
2121

22+
// This file provides additional platform specific APIs. It acts an add on to
23+
// "platform.ts" and exists separately to avoid circular dependency issues with
24+
// ts-node.
25+
2226
/** Formats an object as a JSON string, suitable for logging. */
2327
export function formatJSON(value: unknown): string {
2428
return isNode() ? node.formatJSON(value) : browser.formatJSON(value);

packages/firestore/src/platform/random_bytes.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ import * as node from '../platform_node/node_random_bytes';
1919
import * as browser from '../platform_browser/browser_random_bytes';
2020
import { isNode } from '@firebase/util';
2121

22+
// This file provides additional platform specific APIs. It acts an add on to
23+
// "platform.ts" and exists separately to avoid circular dependency issues with
24+
// ts-node.
25+
2226
/**
2327
* Generates `nBytes` of random bytes.
2428
*

0 commit comments

Comments
 (0)