Skip to content

Commit 3e1287b

Browse files
committed
fix disablePersistentCacheIndexAutoCreation() and deleteAllPersistentCacheIndexes() to throw if invoked on a terminated instance
1 parent fbf3b35 commit 3e1287b

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/firestore/src/api/persistent_cache_index_manager.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,8 @@ export function enablePersistentCacheIndexAutoCreation(
119119
export function disablePersistentCacheIndexAutoCreation(
120120
indexManager: PersistentCacheIndexManager
121121
): void {
122+
indexManager._client.verifyNotTerminated();
123+
122124
// TODO: Refactor this code such that disabling persistent cache auto creation
123125
// does _not_ need FieldIndexManagementApiImpl (i.e. it just uses the
124126
// interface) so that FieldIndexManagementApiImpl can be tree-shaken away if
@@ -137,6 +139,8 @@ export function disablePersistentCacheIndexAutoCreation(
137139
export function deleteAllPersistentCacheIndexes(
138140
indexManager: PersistentCacheIndexManager
139141
): void {
142+
indexManager._client.verifyNotTerminated();
143+
140144
// TODO: Refactor this code such that deleting field indexes does _not_ need
141145
// FieldIndexManagementApiImpl so that FieldIndexManagementApiImpl can be
142146
// tree-shaken away if the only client-side indexing function used is this

0 commit comments

Comments
 (0)