Test for getHighestListenSequenceNumber() recovery

Author: schmidt-sebastian

integration/browserify/package.json

@@ -8,7 +8,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "dependencies": {
-    "firebase": "7.14.4"
+    "firebase": "7.14.3"
   },
   "devDependencies": {
     "@babel/core": "7.9.6",

integration/firebase-typings/package.json

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "dependencies": {
-    "firebase": "7.14.4"
+    "firebase": "7.14.3"
   },
   "devDependencies": {
     "typescript": "3.8.3"

integration/messaging/package.json

@@ -8,7 +8,7 @@
     "test:manual": "mocha --exit"
   },
   "dependencies": {
-    "firebase": "7.14.4"
+    "firebase": "7.14.3"
   },
   "devDependencies": {
     "chai": "4.2.0",

integration/typescript/package.json

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "dependencies": {
-    "firebase": "7.14.4"
+    "firebase": "7.14.3"
   },
   "devDependencies": {
     "@babel/core": "7.9.6",

integration/webpack/package.json

@@ -8,7 +8,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "dependencies": {
-    "firebase": "7.14.4"
+    "firebase": "7.14.3"
   },
   "devDependencies": {
     "@babel/core": "7.9.6",

packages/firebase/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase",
-  "version": "7.14.4",
+  "version": "7.14.3",
   "description": "Firebase JavaScript library for web and Node.js",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "license": "Apache-2.0",
@@ -49,7 +49,7 @@
     "@firebase/app-types": "0.6.0",
     "@firebase/auth": "0.14.5",
     "@firebase/database": "0.6.2",
-    "@firebase/firestore": "1.14.4",
+    "@firebase/firestore": "1.14.3",
     "@firebase/functions": "0.4.43",
     "@firebase/installations": "0.4.9",
     "@firebase/messaging": "0.6.15",

packages/firestore/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firebase/firestore",
-  "version": "1.14.4",
+  "version": "1.14.3",
   "engines": {
     "node": "^8.13.0 || >=10.10.0"
   },

packages/firestore/src/local/indexeddb_persistence.ts

@@ -45,7 +45,6 @@ import {
   DbPrimaryClient,
   DbPrimaryClientKey,
   DbTargetDocument,
-  DbTargetGlobal,
   SCHEMA_VERSION,
   SchemaConverter
 } from './indexeddb_schema';
@@ -306,10 +305,13 @@ export class IndexedDbPersistence implements Persistence {
 
         this.scheduleClientMetadataAndPrimaryLeaseRefreshes();
 
-        return this.simpleDb.runTransaction(
+        return this.runTransaction(
+          'getHighestListenSequenceNumber',
           'readonly',
-          [DbTargetGlobal.store],
-          txn => getHighestListenSequenceNumber(txn)
+          txn =>
+            getHighestListenSequenceNumber(
+              (txn as IndexedDbTransaction).simpleDbTransaction
+            )
         );
       })
       .then(highestListenSequenceNumber => {

packages/firestore/test/unit/local/indexeddb_persistence.test.ts

@@ -15,7 +15,9 @@
  * limitations under the License.
  */
 
-import { expect } from 'chai';
+import * as chaiAsPromised from 'chai-as-promised';
+
+import { expect, use } from 'chai';
 import { Query } from '../../../src/core/query';
 import { SnapshotVersion } from '../../../src/core/snapshot_version';
 import {
@@ -74,6 +76,8 @@ import {
   TEST_SERIALIZER
 } from './persistence_test_helpers';
 
+use(chaiAsPromised);
+
 /* eslint-disable no-restricted-globals */
 
 function withDb(
@@ -1158,13 +1162,32 @@ describe('IndexedDb: allowTabSynchronization', () => {
       'clientA',
       /* multiClient= */ true,
       async db => {
-        db.injectFailures = { updateClientMetadataAndTryBecomePrimary: true };
+        db.injectFailures = {
+          updateClientMetadataAndTryBecomePrimary: true,
+          getHighestListenSequenceNumber: false
+        };
         await db.start();
         await db.shutdown();
       }
     );
   });
 
+  it('blocks start() when getHighestListenSequenceNumber() fails', async () => {
+    await withUnstartedCustomPersistence(
+      'clientA',
+      /* multiClient= */ false,
+      async db1 => {
+        db1.injectFailures = {
+          updateClientMetadataAndTryBecomePrimary: false,
+          getHighestListenSequenceNumber: true
+        };
+        await expect(db1.start()).to.eventually.be.rejectedWith(
+          'IndexedDB transaction failed'
+        );
+      }
+    );
+  });
+
   it('ignores intermittent IndexedDbTransactionError during lease refresh', async () => {
     await withPersistence('clientA', async (db, _, queue) => {
       db.injectFailures = { updateClientMetadataAndTryBecomePrimary: true };

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -1215,7 +1215,8 @@ export type PersistenceAction =
   | 'Get target data'
   | 'Get new document changes'
   | 'Synchronize last document change read time'
-  | 'updateClientMetadataAndTryBecomePrimary';
+  | 'updateClientMetadataAndTryBecomePrimary'
+  | 'getHighestListenSequenceNumber';
 
 /** Specifies failure or success for a list of database actions. */
 export type SpecDatabaseFailures = Partial<

packages/rxfire/package.json

@@ -1,6 +1,6 @@
 {
   "name": "rxfire",
-  "version": "3.12.4",
+  "version": "3.12.3",
   "private": false,
   "description": "Firebase JavaScript library RxJS",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
@@ -43,7 +43,7 @@
     "rxjs": "6.x.x"
   },
   "devDependencies": {
-    "firebase": "7.14.4",
+    "firebase": "7.14.3",
     "rollup": "2.7.6",
     "rollup-plugin-commonjs": "10.1.0",
     "rollup-plugin-node-resolve": "5.2.0",

packages/testing/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firebase/testing",
-  "version": "0.19.4",
+  "version": "0.19.3",
   "description": "",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "main": "dist/index.cjs.js",
@@ -20,7 +20,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "firebase": "7.14.4",
+    "firebase": "7.14.3",
     "@firebase/logger": "0.2.3",
     "@firebase/util": "0.2.46",
     "@types/request": "2.48.4",