Skip to content

Commit 3f9736f

Browse files
committed
modified comments
1 parent c56b85d commit 3f9736f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

packages/auth/test/helpers/integration/helpers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,4 +115,5 @@ export function delay(dt: number): Promise<void> {
115115
}
116116

117117
export const email = '[email protected]';
118+
//1000000 is always incorrect since it has 7 digits and we expect 6.
118119
export const incorrectTotpCode = '1000000';

packages/auth/test/integration/flows/totp.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @license
3-
* Copyright 2020 Google LLC
3+
* Copyright 2022 Google LLC
44
*
55
* Licensed under the Apache License, Version 2.0 (the "License");
66
* you may not use this file except in compliance with the License.
@@ -124,8 +124,9 @@ describe(' Integration tests: Mfa TOTP', () => {
124124
let resolver;
125125

126126
await delay(30 * 1000);
127-
// Added a delay so that getTotpCode() actually generates a new totp code
128-
127+
//TODO(bhparijat) generate the otp code for the next time window by passing the appropriate
128+
//timestamp to avoid the 30s delay. The delay is needed because the otp code used for enrollment
129+
//cannot be reused for signing in.
129130
try {
130131
await signInWithEmailAndPassword(auth, email, 'password');
131132

0 commit comments

Comments
 (0)