Add TODO for later

schmidt-sebastian · schmidt-sebastian · commit 403da9ea77e9 · 2020-02-26T16:39:08.000-08:00
diff --git a/packages/firestore/src/remote/serializer.ts b/packages/firestore/src/remote/serializer.ts
@@ -352,6 +352,9 @@ export class JsonProtoSerializer {
     );
   }
 
+  // TODO(mrschmidt): Even when we remove our custom FieldValues, we still
+  // need to re-encode field values to their expected type based on the
+  // `useProto3Json` setting.
   toValue(val: fieldValue.FieldValue): api.Value {
     if (val instanceof fieldValue.NullValue) {
       return { nullValue: 'NULL_VALUE' };

Original file line number	Diff line number	Diff line change
`@@ -352,6 +352,9 @@ export class JsonProtoSerializer {`
`352`	`352`	`);`
`353`	`353`	`}`
`354`	`354`
	`355`	`+ // TODO(mrschmidt): Even when we remove our custom FieldValues, we still`
	`356`	`+ // need to re-encode field values to their expected type based on the`
	`357`	+ // `useProto3Json` setting.
`355`	`358`	`toValue(val: fieldValue.FieldValue): api.Value {`
`356`	`359`	`if (val instanceof fieldValue.NullValue) {`
`357`	`360`	`return { nullValue: 'NULL_VALUE' };`