remove old node_persistence

Author: Brian Chen

packages/firestore/src/core/sync_engine.ts

@@ -401,8 +401,8 @@ export class SyncEngine implements RemoteSyncer, SharedClientStateSyncer {
 
   async applyRemoteEvent(remoteEvent: RemoteEvent): Promise<void> {
     this.assertSubscribed('applyRemoteEvent()');
+    const changes = await this.localStore.applyRemoteEvent(remoteEvent);
     try {
-      const changes = await this.localStore.applyRemoteEvent(remoteEvent);
       // Update `receivedDocument` as appropriate for any limbo targets.
       objUtils.forEach(remoteEvent.targetChanges, (targetId, targetChange) => {
         const limboResolution = this.limboResolutionsByTarget[Number(targetId)];
@@ -576,8 +576,8 @@ export class SyncEngine implements RemoteSyncer, SharedClientStateSyncer {
     // before listen events.
     this.processUserCallback(batchId, /*error=*/ null);
 
+    const changes = await this.localStore.acknowledgeBatch(mutationBatchResult);
     try {
-      const changes = await this.localStore.acknowledgeBatch(mutationBatchResult);
       this.sharedClientState.updateMutationState(batchId, 'acknowledged');
       await this.emitNewSnapsAndNotifyLocalStore(changes);
     } catch (error) {
@@ -597,8 +597,8 @@ export class SyncEngine implements RemoteSyncer, SharedClientStateSyncer {
     // listen events.
     this.processUserCallback(batchId, error);
 
+    const changes = await this.localStore.rejectBatch(batchId);
     try {
-      const changes = await this.localStore.rejectBatch(batchId);
       this.sharedClientState.updateMutationState(batchId, 'rejected', error);
       await this.emitNewSnapsAndNotifyLocalStore(changes);
     } catch (error) {

packages/firestore/test/util/node_persistence.ts

@@ -16,7 +16,6 @@
  */
 
 import * as fs from 'fs';
-// @ts-ignore
 import * as registerIndexedDBShim from 'indexeddbshim';
 import * as os from 'os';