Skip to content

Commit 441ac6a

Browse files
committed
Address PR comments
1 parent 2da83d1 commit 441ac6a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/util/src/errors.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,7 @@ export interface StringLike {
6666
}
6767

6868
export interface ErrorData {
69-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
70-
[key: string]: any;
69+
[key: string]: unknown;
7170
}
7271

7372
export interface FirebaseError extends Error, ErrorData {
@@ -149,7 +148,7 @@ export class ErrorFactory<
149148
function replaceTemplate(template: string, data: ErrorData): string {
150149
return template.replace(PATTERN, (_, key) => {
151150
const value = data[key];
152-
return value != null ? value.toString() : `<${key}?>`;
151+
return value != null ? String(value) : `<${key}?>`;
153152
});
154153
}
155154

scripts/exp/update-internal-dep-versions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const fs = require('mz/fs');
3232
async function updateField(pkg, fieldName) {
3333
const field = pkg[fieldName];
3434
for (const depName in field) {
35-
if (!depName.includes('@firebase')) continue;
35+
if (!depName.includes('@firebase') && depName !== 'firebase') continue;
3636
const depJson = await mapPkgNameToPkgJson(depName);
3737
if (!depJson.version) continue;
3838
field[depName] = depJson.version;

0 commit comments

Comments
 (0)