removing getters as they don't support tree-shakeable property

Author: bhparijat

packages/auth/src/mfa/assertions/totp.ts

@@ -15,8 +15,7 @@
  * limitations under the License.
  */
 import { TotpSecret } from '../../platform_browser/mfa/assertions/totp';
-import { TotpMultiFactorAssertion, MultiFactorSession  } from '../../model/public_types';
-import { FactorId } from '../../model/enum_maps';
+import { TotpMultiFactorAssertion, MultiFactorSession, FactorId  } from '../../model/public_types';
 /**
  * Provider for generating a {@link TotpMultiFactorAssertion}.
  *
@@ -68,7 +67,7 @@ export class TotpMultiFactorGenerator {
     throw new Error('Unimplemented');
   }
   /**
-   * The identifier of the phone second factor: `totp`.
+   * The identifier of the TOTP second factor: `totp`.
    */
   static FACTOR_ID = FactorId.TOTP;
 }

packages/auth/src/platform_browser/mfa/assertions/totp.ts

@@ -18,51 +18,15 @@
 /**
  * Stores the shared secret key and other parameters to generate time-based OTPs.
  * Implements methods to retrieve the shared secret key, generate a QRCode URL.
+ * @public
  */
-
 export class TotpSecret {
   constructor(
     readonly secretKey: string,
     readonly hashingAlgorithm: string,
     readonly codeLength: number,
     readonly codeIntervalSeconds: number
   ) {}
-  /**
-   * Returns the shared secret key/seed used to generate time-based one-time passwords.
-   *
-   * @returns Shared secret key/seed used for enrolling in TOTP MFA and generating otps.
-   */
-  sharedSecretKey(): string {
-    return this.secretKey;
-  }
-
-  /**
-   * Returns the hashing algorithm used to generate time-based one-time passwords.
-   *
-   * @returns Hashing algorithm used.
-   */
-  getHashingAlgorithm(): string {
-    return this.hashingAlgorithm;
-  }
-
-  /**
-   * Returns the length of the OTP codes to be generated.
-   *
-   * @returns Length of the one-time passwords to be generated.
-   */
-  getCodeLength(): number {
-    return this.codeLength;
-  }
-
-  /**
-   * Returns the interval(in seconds) when the OTP codes should change.
-   *
-   * @returns The interval (in seconds) when the OTP codes should change.
-   */
-  getCodeIntervalSeconds(): number {
-    return this.codeIntervalSeconds;
-  }
-
   /**
    * Returns a QRCode URL as described in
    * https://github.com/google/google-authenticator/wiki/Key-Uri-Format
@@ -73,8 +37,7 @@ export class TotpSecret {
    * @param issuer issuer of the TOTP(likely the app name).
    * @returns A QRCode URL string.
    */
-
-  generateQrCodeUrl(_accountName?: string, issuer?: string): string {
-    return null as any;
+  generateQrCodeUrl(_accountName?: string, _issuer?: string): string {
+    throw new Error('Unimplemented');
   }
 }