isSupported fixes

Author: jamesdaniels

packages/messaging/src/api/isSupported.ts

@@ -28,9 +28,9 @@ export async function isWindowSupported(): Promise<boolean> {
   // might be prohibited to run. In these contexts, an error would be thrown during the messaging
   // instantiating phase, informing the developers to import/call isSupported for special handling.
   return (
+    typeof window !== 'undefined' &&
+    typeof indexedDB !== 'undefined' &&
     (await validateIndexedDBOpenable()) &&
-    'indexedDB' in window &&
-    indexedDB !== null &&
     navigator.cookieEnabled &&
     'serviceWorker' in navigator &&
     'PushManager' in window &&

packages/performance/src/services/api_service.ts

@@ -16,7 +16,7 @@
  */
 
 import { ERROR_FACTORY, ErrorCode } from '../utils/errors';
-import { isIndexedDBAvailable } from '@firebase/util';
+import { isIndexedDBAvailable, areCookiesEnabled } from '@firebase/util';
 import { consoleLogger } from '../utils/console_logger';
 
 declare global {
@@ -112,12 +112,7 @@ export class Api {
   }
 
   requiredApisAvailable(): boolean {
-    if (
-      !fetch ||
-      !Promise ||
-      !this.navigator ||
-      !this.navigator.cookieEnabled
-    ) {
+    if (!fetch || !Promise || !areCookiesEnabled()) {
       consoleLogger.info(
         'Firebase Performance cannot start if browser does not support fetch and Promise or cookie is disabled.'
       );

packages/util/src/environment.ts

@@ -184,7 +184,7 @@ export function validateIndexedDBOpenable(): Promise<boolean> {
  * @return true if cookie is enabled within current browser
  */
 export function areCookiesEnabled(): boolean {
-  if (!navigator || !navigator.cookieEnabled) {
+  if (typeof navigator === 'undefined' || !navigator.cookieEnabled) {
     return false;
   }
   return true;