Skip to content

Commit 4624bc1

Browse files
committed
move comments to the same line as the suppression
1 parent 2204d79 commit 4624bc1

File tree

6 files changed

+8
-16
lines changed

6 files changed

+8
-16
lines changed

packages/firestore/src/remote/rpc_error.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ export function isPermanentWriteError(code: Code): boolean {
110110
* there is no match.
111111
*/
112112
export function mapCodeFromRpcStatus(status: string): Code | undefined {
113-
// lookup by string
114-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
113+
// eslint-disable-next-line @typescript-eslint/no-explicit-any, lookup by string
115114
const code: RpcCode = RpcCode[status as any] as any;
116115
if (code === undefined) {
117116
return undefined;

packages/firestore/src/remote/serializer.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,7 @@ export class JsonProtoSerializer {
171171
*/
172172
private toInt32Value(val: number | null): number | undefined {
173173
if (!typeUtils.isNullOrUndefined(val)) {
174-
// We need to match generated Proto types.
175-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
174+
// eslint-disable-next-line @typescript-eslint/no-explicit-any, We need to match generated Proto types.
176175
return { value: val } as any;
177176
} else {
178177
return undefined;
@@ -189,8 +188,7 @@ export class JsonProtoSerializer {
189188
private fromInt32Value(val: number | undefined): number | null {
190189
let result;
191190
if (typeof val === 'object') {
192-
// We need to match generated Proto types.
193-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
191+
// eslint-disable-next-line @typescript-eslint/no-explicit-any, We need to match generated Proto types.
194192
result = (val as any).value;
195193
} else {
196194
// We accept raw numbers (without the {value: ... } wrapper) for

packages/firestore/src/util/async_queue.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ import { Code, FirestoreError } from './error';
2020
import * as log from './log';
2121
import { CancelablePromise, Deferred } from './promise';
2222

23-
// Accept any return type from setTimeout().
24-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
23+
// eslint-disable-next-line @typescript-eslint/no-explicit-any, Accept any return type from setTimeout(). Accept any return type from setTimeout(). Accept any return type from setTimeout().
2524
type TimerHandle = any;
2625

2726
/**

packages/firestore/src/util/sorted_map.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,8 +273,7 @@ export class LLRBNode<K, V> {
273273
readonly right: LLRBNode<K, V> | LLRBEmptyNode<K, V>;
274274
readonly size: number;
275275

276-
//Empty node is shared between all LLRB trees.
277-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
276+
// eslint-disable-next-line @typescript-eslint/no-explicit-any, Empty node is shared between all LLRB trees.
278277
static EMPTY: LLRBEmptyNode<any, any> = null as any;
279278

280279
static RED = true;

packages/firestore/test/unit/remote/remote_event.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,8 @@ import {
4444
version
4545
} from '../../util/helpers';
4646

47-
/* eslint-disable @typescript-eslint/prefer-interface */
4847
interface TargetMap {
49-
[targetId: number]: QueryData;
48+
[targetId: string]: QueryData;
5049
}
5150
interface PendingTargetResponses {
5251
[targetId: string]: number;

packages/firestore/test/unit/specs/spec_builder.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,8 @@ export interface LimboMap {
6161
[key: string]: TargetId;
6262
}
6363

64-
// number index signature doesn't work well with interface, so we use type instead
65-
// eslint-disable-next-line @typescript-eslint/prefer-interface
66-
export type ActiveTargetMap = {
67-
[targetId: number]: { query: SpecQuery; resumeToken: string };
64+
export interface ActiveTargetMap {
65+
[targetId: string]: { query: SpecQuery; resumeToken: string };
6866
};
6967

7068
/**

0 commit comments

Comments
 (0)