failing: attempt using default <U> in DocumentReference converter

Brian Chen · Brian Chen · commit 47f882d7654f · 2021-03-03T11:33:55.000-06:00
diff --git a/packages/firestore/src/api/database.ts b/packages/firestore/src/api/database.ts
@@ -836,11 +836,11 @@ export class DocumentReference<T = PublicDocumentData>
   ): PublicDocumentReference<U>;
   withConverter<U>(
     converter: PublicFirestoreDataConverter<U> | null
-  ): PublicDocumentReference<U> | PublicDocumentReference<PublicDocumentData> {
-    return new DocumentReference(
+  ): PublicDocumentReference<U> {
+    return new DocumentReference<U>(
       this.firestore,
       converter
-        ? this._delegate.withConverter(
+        ? this._delegate.withConverter<U>(
             FirestoreDataConverter.getInstance(this.firestore, converter)
           )
         : this._delegate.withConverter(null)
