Update dependency typescript to v4.2.2 (#4098)

* Update dependency typescript to v4.2.2

* fix ts errors

* remove type coercion

* fix typings in tests

* fix database tests

* fix lint error

* fix typing error in integration tests

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Feiyang1 <[email protected]>

Author: 3 people

integration/firebase/package.json

@@ -20,6 +20,6 @@
     "karma-typescript": "5.2.0",
     "mocha": "7.2.0",
     "npm-run-all": "4.1.5",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   }
 }

integration/firestore/package.json

@@ -27,7 +27,7 @@
     "karma-spec-reporter": "0.0.32",
     "mocha": "7.2.0",
     "ts-loader": "8.0.12",
-    "typescript": "4.0.5",
+    "typescript": "4.2.2",
     "webpack": "4.44.2",
     "webpack-stream": "6.1.1"
   }

package.json

@@ -153,7 +153,7 @@
     "ts-node": "9.1.1",
     "tslint": "6.1.3",
     "typedoc": "0.16.11",
-    "typescript": "4.0.5",
+    "typescript": "4.2.2",
     "watch": "1.0.2",
     "webpack": "4.44.2",
     "yargs": "16.2.0"

packages-exp/analytics-compat/package.json

@@ -18,7 +18,7 @@
     "rollup": "2.35.1",
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages-exp/analytics-compat",

packages-exp/analytics-exp/package.json

@@ -46,7 +46,7 @@
     "@rollup/plugin-json": "4.1.0",
     "@rollup/plugin-node-resolve": "9.0.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/analytics",

packages-exp/app-compat/package.json

@@ -42,7 +42,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages-exp/app-compat",

packages-exp/app-exp/package.json

@@ -42,7 +42,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages-exp/app-exp",

packages-exp/auth-compat-exp/demo/package.json

@@ -35,7 +35,7 @@
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.29.0",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages-exp/auth-compat-exp/demo",

packages-exp/auth-compat-exp/demo/yarn.lock

@@ -5213,10 +5213,10 @@ typedarray@^0.0.6:
   resolved "https://registry.npmjs.org/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@4.0.5:
-  version "4.0.5"
-  resolved "https://registry.npmjs.org/typescript/-/typescript-4.0.5.tgz#ae9dddfd1069f1cb5beb3ef3b2170dd7c1332389"
-  integrity sha512-ywmr/VrTVCmNTJ6iV2LwIrfG1P+lv6luD8sUJs+2eI9NLGigaN+nUQc13iHqisq7bra9lnmUSYqbJvegraBOPQ==
+typescript@4.2.2:
+  version "4.2.2"
+  resolved "https://registry.npmjs.org/typescript/-/typescript-4.2.2.tgz#1450f020618f872db0ea17317d16d8da8ddb8c4c"
+  integrity sha512-tbb+NVrLfnsJy3M59lsDgrzWIflR4d4TIUjz+heUnHZwdF7YsrMTKoRERiIvI2lvBG95dfpLxB21WZhys1bgaQ==
 
 uglify-js@^3.1.4, uglify-js@^3.4.9:
   version "3.12.7"

packages-exp/auth-compat-exp/package.json

@@ -41,7 +41,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages-exp/auth-compat-exp",

packages-exp/auth-exp/package.json

@@ -61,7 +61,7 @@
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.29.0",
     "@rollup/plugin-strip": "2.0.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages-exp/auth-exp",

packages-exp/firebase-exp/package.json

@@ -60,7 +60,7 @@
     "gulp": "4.0.2",
     "gulp-sourcemaps": "3.0.0",
     "gulp-concat": "2.6.1",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "components": [
     "analytics",

packages-exp/functions-compat/package.json

@@ -20,7 +20,7 @@
     "rollup": "2.35.1",
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages-exp/functions-compat",

packages-exp/functions-exp/package.json

@@ -39,7 +39,7 @@
     "rollup": "2.35.1",
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/functions",

packages-exp/installations-compat/package.json

@@ -44,7 +44,7 @@
     "@rollup/plugin-node-resolve": "9.0.0",
     "rollup-plugin-typescript2": "0.29.0",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "peerDependencies": {
     "@firebase/app-compat": "0.x"

packages-exp/installations-exp/package.json

@@ -50,7 +50,7 @@
     "@rollup/plugin-node-resolve": "9.0.0",
     "rollup-plugin-typescript2": "0.29.0",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "peerDependencies": {
     "@firebase/app-exp": "0.x"

packages-exp/messaging-exp/package.json

@@ -42,7 +42,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.29.0",
     "ts-essentials": "7.0.1",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/messaging",

packages-exp/performance-exp/package.json

@@ -44,7 +44,7 @@
     "rollup": "2.35.1",
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/performance-exp",

packages-exp/remote-config-compat/package.json

@@ -40,7 +40,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5",
+    "typescript": "4.2.2",
     "@firebase/app-compat": "0.0.900"
   },
   "repository": {

packages-exp/remote-config-exp/package.json

@@ -45,7 +45,7 @@
     "@firebase/app-exp": "0.0.900",
     "rollup": "2.35.1",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/remote-config",

packages/analytics-interop-types/package.json

@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   }
 }

packages/analytics-types/package.json

@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   }
 }

packages/analytics/package.json

@@ -41,7 +41,7 @@
     "@rollup/plugin-json": "4.1.0",
     "@rollup/plugin-node-resolve": "9.0.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/analytics",

packages/app-types/package.json

@@ -21,6 +21,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   }
 }

packages/app/package.json

@@ -41,7 +41,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/app",

packages/auth-interop-types/package.json

@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   }
 }

packages/auth-types/package.json

@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   }
 }

packages/component/package.json

@@ -30,7 +30,7 @@
   "devDependencies": {
     "rollup": "2.35.1",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/component",

packages/component/src/provider.test.ts

@@ -19,6 +19,7 @@ import { expect } from 'chai';
 import { fake, SinonSpy } from 'sinon';
 import { ComponentContainer } from './component_container';
 import { FirebaseService } from '@firebase/app-types/private';
+// eslint-disable-next-line import/no-extraneous-dependencies
 import { _FirebaseService } from '@firebase/app-exp';
 import { Provider } from './provider';
 import { getFakeApp, getFakeComponent } from '../test/util';

packages/database-types/package.json

@@ -23,6 +23,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   }
 }

packages/database/package.json

@@ -45,7 +45,7 @@
     "@firebase/app-types": "0.6.1",
     "rollup": "2.35.1",
     "rollup-plugin-typescript2": "0.29.0",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/database",

packages/database/rollup.config.exp.js

@@ -21,7 +21,8 @@ import typescript from 'typescript';
 import path from 'path';
 import { importPathTransformer } from '../../scripts/exp/ts-transform-import-path';
 
-import pkg from './exp/package.json';
+import expPkg from './exp/package.json';
+import pkg from './package.json';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -46,7 +47,7 @@ const es5Builds = [
   {
     input: 'exp/index.ts',
     output: [
-      { file: path.resolve('exp', pkg.main), format: 'cjs', sourcemap: true }
+      { file: path.resolve('exp', expPkg.main), format: 'cjs', sourcemap: true }
     ],
     plugins: es5BuildPlugins,
     treeshake: {
@@ -60,7 +61,11 @@ const es5Builds = [
   {
     input: 'exp/index.ts',
     output: [
-      { file: path.resolve('exp', pkg.module), format: 'es', sourcemap: true }
+      {
+        file: path.resolve('exp', expPkg.module),
+        format: 'es',
+        sourcemap: true
+      }
     ],
     plugins: es5BuildPlugins,
     treeshake: {
@@ -94,7 +99,11 @@ const es2017Builds = [
   {
     input: 'exp/index.ts',
     output: [
-      { file: path.resolve('exp', pkg.esm2017), format: 'es', sourcemap: true }
+      {
+        file: path.resolve('exp', expPkg.esm2017),
+        format: 'es',
+        sourcemap: true
+      }
     ],
     plugins: es2017BuildPlugins,
     treeshake: {

packages/database/test/helpers/util.ts

@@ -117,7 +117,7 @@ export function getQueryValue(query: Query) {
 }
 
 export function pause(milliseconds: number) {
-  return new Promise(resolve => {
+  return new Promise<void>(resolve => {
     setTimeout(() => resolve(), milliseconds);
   });
 }

packages/database/test/info.test.ts

@@ -75,7 +75,7 @@ describe('.info Tests', function () {
   });
 
   it('Can watch .info/connected.', () => {
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       const f = (getRandomNode() as Reference).root;
       f.child('.info/connected').on('value', snap => {
         if (snap.val() === true) {

packages/database/test/order.test.ts

@@ -27,7 +27,7 @@ describe('Order Tests', () => {
   // arrive in that order.  But if we aren't connected yet, the "reconnection" code will send them
   // in the opposite order.
   beforeEach(() => {
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       const ref = getRandomNode() as Reference;
       let connected = false;
       ref.root.child('.info/connected').on('value', s => {

packages/firebase/package.json

@@ -68,7 +68,7 @@
     "rollup-plugin-terser": "7.0.2",
     "rollup-plugin-typescript2": "0.29.0",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "typings": "index.d.ts",
   "components": [

packages/firestore-types/package.json

@@ -23,6 +23,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   }
 }

packages/firestore/package.json

@@ -94,7 +94,7 @@
     "rollup-plugin-terser": "7.0.2",
     "rollup-plugin-typescript2": "0.29.0",
     "ts-node": "9.1.1",
-    "typescript": "4.0.5"
+    "typescript": "4.2.2"
   },
   "repository": {
     "directory": "packages/firestore",